Attachment 338782 Details for Bug 184998 – Patch

[patch] Patch

bug-184998-20180425133912.patch (text/plain), 1.66 KB, created by Keith Miller on 2018-04-25 13:39:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2018-04-25 13:39:13 PDT

Size: 1.66 KB

patch

obsolete

>Subversion Revision: 231015
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 6431338cc961e5074bdb2c6b7e839ae9911bfb59..7ebbd74d710798cdd0fbed33a9eb11288f678056 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-04-25  Keith Miller  <keith_miller@apple.com>
>+
>+        getUnlinkedGlobalFunctionExecutable should only save things to the code cache if the option is set
>+        https://bugs.webkit.org/show_bug.cgi?id=184998
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Also only if was successfully able to parse the function.
>+
>+        * runtime/CodeCache.cpp:
>+        (JSC::CodeCache::getUnlinkedGlobalFunctionExecutable):
>+
> 2018-04-25  Keith Miller  <keith_miller@apple.com>
> 
>         Add missing scope release to functionProtoFuncToString
>diff --git a/Source/JavaScriptCore/runtime/CodeCache.cpp b/Source/JavaScriptCore/runtime/CodeCache.cpp
>index ad25439187cd1d4c871ac08af19fceb0da322e88..443cd10465b5b035f02b2a498f3dcec0a3ebb94b 100644
>--- a/Source/JavaScriptCore/runtime/CodeCache.cpp
>+++ b/Source/JavaScriptCore/runtime/CodeCache.cpp
>@@ -158,7 +158,8 @@ UnlinkedFunctionExecutable* CodeCache::getUnlinkedGlobalFunctionExecutable(VM& v
>     functionExecutable->setSourceURLDirective(source.provider()->sourceURL());
>     functionExecutable->setSourceMappingURLDirective(source.provider()->sourceMappingURL());
> 
>-    m_sourceCode.addCache(key, SourceCodeValue(vm, functionExecutable, m_sourceCode.age()));
>+    if (functionExecutable && Options::useCodeCache())
>+        m_sourceCode.addCache(key, SourceCodeValue(vm, functionExecutable, m_sourceCode.age()));
>     return functionExecutable;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 184998: 338782 | 338785