Attachment 338779 Details for Bug 184995 – Patch

[patch] Patch

bug-184995-20180425132605.patch (text/plain), 2.37 KB, created by Keith Miller on 2018-04-25 13:26:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2018-04-25 13:26:06 PDT

Size: 2.37 KB

patch

obsolete

>Subversion Revision: 230980
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 60f3b8874988320fa52dc8cbdbfee25f3cb7d10c..c80ec92721b396b24d53b193d18087b3d96aface 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-04-25  Keith Miller  <keith_miller@apple.com>
>+
>+        Add missing scope release to functionProtoFuncToString
>+        https://bugs.webkit.org/show_bug.cgi?id=184995
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * runtime/FunctionPrototype.cpp:
>+        (JSC::functionProtoFuncToString):
>+
> 2018-04-24  Keith Miller  <keith_miller@apple.com>
> 
>         fromCharCode is missing some exception checks
>diff --git a/Source/JavaScriptCore/runtime/FunctionPrototype.cpp b/Source/JavaScriptCore/runtime/FunctionPrototype.cpp
>index 7ca6923c2079598463f6a01e1ac95f523fe4fb30..a39539bd0146e397c51164763b574aeb02d4c2fb 100644
>--- a/Source/JavaScriptCore/runtime/FunctionPrototype.cpp
>+++ b/Source/JavaScriptCore/runtime/FunctionPrototype.cpp
>@@ -104,6 +104,7 @@ EncodedJSValue JSC_HOST_CALL functionProtoFuncToString(ExecState* exec)
>             StringView source = executable->source().provider()->getRange(
>                 executable->parametersStartOffset(),
>                 executable->parametersStartOffset() + executable->source().length());
>+            scope.release();
>             return JSValue::encode(jsMakeNontrivialString(exec, functionHeader, function->name(vm), source));
>         }
> 
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index 6629c69ad2e12746f713312ea8e89d3f6a76bda8..214465ae7367937f676e01a9068c8731af37d1a5 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-04-25  Keith Miller  <keith_miller@apple.com>
>+
>+        Add missing scope release to functionProtoFuncToString
>+        https://bugs.webkit.org/show_bug.cgi?id=184995
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * stress/function-toString-arrow.js: Added.
>+        (async):
>+
> 2018-04-24  Keith Miller  <keith_miller@apple.com>
> 
>         fromCharCode is missing some exception checks
>diff --git a/JSTests/stress/function-toString-arrow.js b/JSTests/stress/function-toString-arrow.js
>new file mode 100644
>index 0000000000000000000000000000000000000000..9a0f7d32eff4d3e2874ada7eb71c5c0f58bae84e
>--- /dev/null
>+++ b/JSTests/stress/function-toString-arrow.js
>@@ -0,0 +1 @@
>+(async () => {}).toString();

Flags:

saam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 184995: 338779