Attachment 338778 Details for Bug 184994 – Patch

[patch] Patch

bug-184994-20180425132247.patch (text/plain), 1.90 KB, created by zalan on 2018-04-25 13:22:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2018-04-25 13:22:48 PDT

Size: 1.90 KB

patch

obsolete

>Subversion Revision: 231013
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d4d3cabfd7adc69f98bb4af1f21a05a7eb1c25d3..03f4304e37a37b4da5df22761ef2d32b34918f07 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-04-25  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC] Implement Layout::BlockContainer functions.
>+        https://bugs.webkit.org/show_bug.cgi?id=184994
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * layout/layouttree/LayoutBlockContainer.cpp:
>+        (WebCore::Layout::BlockContainer::BlockContainer):
>+        (WebCore::Layout::BlockContainer::establishesInlineFormattingContext const):
>+
> 2018-04-25  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Implement Layout::Container functions.
>diff --git a/Source/WebCore/layout/layouttree/LayoutBlockContainer.cpp b/Source/WebCore/layout/layouttree/LayoutBlockContainer.cpp
>index a64ef1e9cf5dcadd5fb628d0df7b26bf94353295..d847cd449bd0b9a9a6b6d0aeb17c528c1df72399 100644
>--- a/Source/WebCore/layout/layouttree/LayoutBlockContainer.cpp
>+++ b/Source/WebCore/layout/layouttree/LayoutBlockContainer.cpp
>@@ -25,3 +25,34 @@
> 
> #include "config.h"
> #include "LayoutBlockContainer.h"
>+
>+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
>+
>+#include "RenderStyle.h"
>+#include <wtf/IsoMallocInlines.h>
>+
>+namespace WebCore {
>+namespace Layout {
>+
>+WTF_MAKE_ISO_ALLOCATED_IMPL(BlockContainer);
>+
>+BlockContainer::BlockContainer(RenderStyle&& style)
>+    : Container(WTFMove(style))
>+{
>+}
>+
>+bool BlockContainer::establishesInlineFormattingContext() const
>+{
>+    // 9.4.2 Inline formatting contexts
>+    // An inline formatting context is established by a block container box that contains no block-level boxes.
>+    for (auto* child = firstInFlowChild(); child; child = child->nextInFlowSibling()) {
>+        if (child->isBlockLevelBox())
>+            return false;
>+    }
>+    return hasInFlowOrFloatingChild();
>+}
>+
>+}
>+}
>+
>+#endif

Flags:

koivisto: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 184994: 338778