ChangeLog

2021-05-09  Dean Jackson  <dino@apple.com>

        [WebXR] Allow WebXR to be tested on PLATFORM(COCOA)

        https://bugs.webkit.org/show_bug.cgi?id=225578

        Reviewed by NOBODY (OOPS!).

        Compile-time enabled on all Cocoa platforms.

        * wtf/PlatformEnableCocoa.h:

2021-05-08  Diego Pino Garcia  <dpino@igalia.com>

        [GLIB] REGRESSION(r277158) imported/w3c/web-platform-tests/xhr/FormData-append.html is crashing

Source/WebKit/ChangeLog

2021-05-09  Dean Jackson  <dino@apple.com>

        [WebXR] Allow WebXR to be tested on PLATFORM(COCOA)

        https://bugs.webkit.org/show_bug.cgi?id=225578

        Reviewed by NOBODY (OOPS!).

        Remove checking for a WebXR feature flag.

        * Shared/WebPreferencesDefaultValues.cpp:

        (WebKit::defaultWebXREnabled):

2021-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        [SOUP] Use the new libsoup network metrics API

Source/WTF/wtf/PlatformEnableCocoa.h

#define ENABLE_WEBPROCESS_NSRUNLOOP 1

#endif

602 #if !defined(ENABLE_WEBXR) && H~~AVE(WEBXR_INTERNAL~~S)

602#if !defined(ENABLE_WEBXR) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

#define ENABLE_WEBXR 1

#endif

Source/WebCore/platform/xr/cocoa/PlatformXRCocoa.h

#if ENABLE(WEBXR) && PLATFORM(COCOA)

#include "PlatformXR.h"

30 #include <WebKitAdditions/PlatformXRAdditions.h>

3130#endif

Source/WebCore/platform/xr/cocoa/PlatformXRCocoa.mm

#if ENABLE(WEBXR) && PLATFORM(COCOA)

31 #import <WebKitAdditions/PlatformXRAdditions.mm>

#import <wtf/NeverDestroyed.h>

using namespace WebCore;

namespace PlatformXR {

struct Instance::Impl {

    WTF_MAKE_FAST_ALLOCATED;

public:

    Impl() = default;

    ~Impl() = default;

};

Instance& Instance::singleton()

{

    static LazyNeverDestroyed<Instance> s_instance;

    static std::once_flag s_onceFlag;

    std::call_once(s_onceFlag,

        [&] {

            s_instance.construct();

        });

    return s_instance.get();

}

Instance::Instance()

    : m_impl(makeUniqueRef<Impl>())

{

}

void Instance::enumerateImmersiveXRDevices(CompletionHandler<void(const DeviceList& devices)>&& callback)

{

    callback({ });

}

}

3266

3367#endif

Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

@@bool defaultWebXREnabled()

{

#if HAVE(WEBXR_INTERNALS)

    return true;

270 #elif HAVE(SYSTEM_FEATURE_FLAGS)

271 return isFeatureFlagEnabled("WebXR");

#else

    return false;

#endif

LayoutTests/ChangeLog

2021-05-09  Dean Jackson  <dino@apple.com>

        [WebXR] Allow WebXR to be tested on PLATFORM(COCOA)

        https://bugs.webkit.org/show_bug.cgi?id=225578

        Reviewed by NOBODY (OOPS!).

        Remove the skip rule for the WebXR directory, and add more

        specific expected results.

        * TestExpectations:

2021-05-08  Ricky Mondello  <rmondello@apple.com>

        Fix a typo

LayoutTests/imported/w3c/ChangeLog

2021-05-09  Dean Jackson  <dino@apple.com>

        [WebXR] Allow WebXR to be tested on PLATFORM(COCOA)

        https://bugs.webkit.org/show_bug.cgi?id=225578

        Reviewed by NOBODY (OOPS!).

        New expected results.

        * web-platform-tests/webxr/exclusive_requestFrame_nolayer.https-expected.txt: Added.

        * web-platform-tests/webxr/render_state_vertical_fov_inline.https-expected.txt: Added.

        * web-platform-tests/webxr/webxr-supported-by-feature-policy-expected.txt: Added.

        * web-platform-tests/webxr/webxr_availability.http.sub-expected.txt: Added.

        * web-platform-tests/webxr/webxr_feature_policy.https-expected.txt: Added.

        * web-platform-tests/webxr/xrFrame_lifetime.https-expected.txt: Added.

        * web-platform-tests/webxr/xrPose_transform_sameObject.https-expected.txt: Added.

        * web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt: Added.

        * web-platform-tests/webxr/xrSession_input_events_end.https-expected.txt: Added.

        * web-platform-tests/webxr/xrSession_visibilityState.https-expected.txt: Added.

        * web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https-expected.txt: Added.

        * web-platform-tests/webxr/xrWebGLLayer_framebuffer_scale.https-expected.txt: Added.

        * web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer_stencil.https-expected.txt: Added.

2021-05-06  Tim Nguyen  <ntim@apple.com>

        Re-import css/mediaqueries/test_media_queries.html WPT

LayoutTests/TestExpectations

@@webkit.org/b/207260 imported/w3c/web-platform-tests/web-animations/timing-model/

webkit.org/b/207262 imported/w3c/web-platform-tests/web-animations/timing-model/animations/sync-start-times.html [ Pass ImageOnlyFailure ]

# WebXR is being implemented

webkit.org/b/208988 http/wpt/webxr [ Skip ]

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr [ Skip ]

webkit.org/b/210963 imported/w3c/web-platform-tests/css/css-animations/animation-important-002.html [ ImageOnlyFailure ]

webkit.org/b/209080 imported/w3c/web-platform-tests/css/css-writing-modes/central-baseline-alignment-003.xht [ ImageOnlyFailure Pass ]

@@webkit.org/b/225247 [ Debug ] fast/multicol/span/float-becomes-spanner-crash.htm

imported/w3c/web-platform-tests/webstorage/storage_session_setitem_quotaexceedederr.window.html [ Skip ]

# This webstorage test has timed out since it was imported.

imported/w3c/web-platform-tests/webstorage/document-domain.html [ Skip ]

# WebXR - Missing modules.

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/anchors [ Skip ]

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/ar-module [ Skip ]

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/dom-overlay [ Skip ]

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/gamepads-module [ Skip ]

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/hit-test [ Skip ]

# WebXR - These currently timeout due to missing features.

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/events_referenceSpace_reset_immersive.https.html [ Skip ]

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/events_referenceSpace_reset_inline.https.html [ Skip ]

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/getInputPose_pointer.https.html [ Skip ]

webkit.org/b/208988 imported/w3c/web-platform-tests/webxr/xrDevice_disconnect_ends.https.html [ Skip ]

webkit.org/b/208988 http/wpt/webxr/xrSession_ended_by_system.https.html [ Skip ]

LayoutTests/imported/w3c/web-platform-tests/webxr/exclusive_requestFrame_nolayer.https-expected.txt

FAIL XRSession requestAnimationFrame must fail if the session has no baseLayer for immersive assert_equals: expected object "[object XRWebGLLayer]" but got object "[object XRWebGLLayer]"

FAIL XRSession requestAnimationFrame must fail if the session has no baseLayer for non immersive assert_equals: expected object "[object XRWebGLLayer]" but got object "[object XRWebGLLayer]"

LayoutTests/imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_inline.https-expected.txt

FAIL inlineVerticalFieldOfView is set appropriately on inline sessions promise_test: Unhandled rejection with value: object "InvalidStateError: The object is in an invalid state."

LayoutTests/imported/w3c/web-platform-tests/webxr/webxr-supported-by-feature-policy-expected.txt

FAIL document.featurePolicy.features should advertise xr-spatial-tracking. undefined is not an object (evaluating 'document.featurePolicy.features')

LayoutTests/imported/w3c/web-platform-tests/webxr/webxr_availability.http.sub-expected.txt

FAIL Test webxr not available in insecure context assert_equals: navigator.xr was defined in insecure context. expected (undefined) undefined but got (object) object "[object XRSystem]"

FAIL Test webxr not available in secure context in insecure context assert_equals: Some objects were defined in insecure context: navigator.xr,XRSession,XRFrame,XRLayer,XRView,XRViewport,XRViewerPose,XRWebGLLayer,XRSessionEvent expected 0 but got 9

LayoutTests/imported/w3c/web-platform-tests/webxr/webxr_feature_policy.https-expected.txt

Harness Error (FAIL), message = Test named 'Validate devicechange event behavior without xr-spatial-tracking policy' specified 1 'cleanup' function, and 1 failed.

FAIL Validate isSessionSupported behavior without xr-spatial-tracking policy assert_unreached: Should have rejected: Immersive isSessionSupported should reject Reached unreachable code

FAIL Validate requestSession behavior without xr-spatial-tracking policy assert_unreached: Should have rejected: Inline with features should reject without feature policy Reached unreachable code

PASS Validate devicechange event behavior without xr-spatial-tracking policy

LayoutTests/imported/w3c/web-platform-tests/webxr/xrFrame_lifetime.https-expected.txt

PASS XRFrame methods throw exceptions outside of the requestAnimationFrame callback for immersive sessions

PASS XRFrame methods throw exceptions outside of the requestAnimationFrame callback for non-immersive sessions

LayoutTests/imported/w3c/web-platform-tests/webxr/xrPose_transform_sameObject.https-expected.txt

PASS XRPose.transform meets [SameObject] requirement

LayoutTests/imported/w3c/web-platform-tests/webxr/xrReferenceSpace_originOffsetBounded.https-expected.txt

FAIL Updating XRBoundedReferenceSpace origin offset updates view, input matrices, and bounds geometry. The object is in an invalid state.

LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_input_events_end.https-expected.txt

FAIL Calling end during an input callback stops processing at the right time assert_equals: Expected end event, but got selectstart event instead expected "end" but got "selectstart"

LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_visibilityState.https-expected.txt

FAIL Ensures that the XRSession's visibilityState is correctly reported and that the associated visibilitychange event fires. promise_test: Unhandled rejection with value: "Session with params \"immersive-vr\" was rejected on device {\"supportsImmersive\":true,\"supportedModes\":[\"inline\",\"immersive-vr\"],\"views\":[{\"eye\":\"left\",\"projectionMatrix\":[1,0,0,0,0,1,0,0,3,2,-1,-1,0,0,-0.2,0],\"viewOffset\":{\"position\":[-0.1,0,0],\"orientation\":[0,0,0,1]},\"resolution\":{\"width\":200,\"height\":200}},{\"eye\":\"right\",\"projectionMatrix\":[1,0,0,0,0,1,0,0,3,2,-1,-1,0,0,-0.2,0],\"viewOffset\":{\"position\":[0.1,0,0],\"orientation\":[0,0,0,1]},\"resolution\":{\"width\":200,\"height\":200}}],\"viewerOrigin\":{\"position\":[0,0,0],\"orientation\":[0,0,0,1]},\"supportedFeatures\":[\"viewer\",\"local\",\"local-floor\",\"bounded-floor\",\"unbounded\",\"hit-test\",\"dom-overlay\",\"light-estimation\",\"anchors\"]} with error: OperationError: Unable to allocate XRWebGLLayer GPU resources."

LayoutTests/imported/w3c/web-platform-tests/webxr/xrStationaryReferenceSpace_floorlevel_updates.https-expected.txt

FAIL 'floor-level' XRStationaryReferenceSpace updates properly when the transform changes for immersive sessions promise_test: Unhandled rejection with value: "Session with params \"immersive-vr\" was rejected on device {\"supportsImmersive\":true,\"supportedModes\":[\"inline\",\"immersive-vr\"],\"views\":[{\"eye\":\"left\",\"projectionMatrix\":[1,0,0,0,0,1,0,0,3,2,-1,-1,0,0,-0.2,0],\"viewOffset\":{\"position\":[-0.1,0,0],\"orientation\":[0,0,0,1]},\"resolution\":{\"width\":200,\"height\":200}},{\"eye\":\"right\",\"projectionMatrix\":[1,0,0,0,0,1,0,0,3,2,-1,-1,0,0,-0.2,0],\"viewOffset\":{\"position\":[0.1,0,0],\"orientation\":[0,0,0,1]},\"resolution\":{\"width\":200,\"height\":200}}],\"viewerOrigin\":{\"position\":[0,0,0],\"orientation\":[0,0,0,1]},\"supportedFeatures\":[\"viewer\",\"local\",\"local-floor\",\"bounded-floor\",\"unbounded\",\"hit-test\",\"dom-overlay\",\"light-estimation\",\"anchors\"]} with error: OperationError: Unable to allocate XRWebGLLayer GPU resources."

PASS 'floor-level' XRStationaryReferenceSpace updates properly when the transform changes for non-immersive sessions

LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_scale.https-expected.txt

FAIL Ensure framebuffer scaling works as expected. undefined is not an object (evaluating 'fakeDeviceController.displayInfo_.webxrDefaultFramebufferScale')

LayoutTests/imported/w3c/web-platform-tests/webxr/xrWebGLLayer_opaque_framebuffer_stencil.https-expected.txt

FAIL Ensure that the framebuffer given by the WebGL layer works with stencil for immersive assert_equals: Should not initially have any errors expected 0 but got 1282