ChangeLog

2019-09-09  Sihui Liu  <sihui_liu@apple.com>

        Layout Test imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html is a Flaky Failure

        https://bugs.webkit.org/show_bug.cgi?id=201481

        <rdar://problem/55046055>

        Reviewed by NOBODY (OOPS!).

        We should not schedule timer if we know the timer function will be no-op.

        * Modules/indexeddb/IDBTransaction.cpp:

        (WebCore::IDBTransaction::removeRequest):

        (WebCore::IDBTransaction::scheduleOperation):

        (WebCore::IDBTransaction::trySchedulePendingOperationTimer):

        (WebCore::IDBTransaction::pendingOperationTimerFired):

        (WebCore::IDBTransaction::commit):

        (WebCore::IDBTransaction::didStart):

        (WebCore::IDBTransaction::operationCompletedOnClient):

        (WebCore::IDBTransaction::deactivate):

        (WebCore::IDBTransaction::schedulePendingOperationTimer): Deleted.

        * Modules/indexeddb/IDBTransaction.h:

2019-09-05  Keith Rollin  <krollin@apple.com>

        Fix implicit conversion that loses precision

Source/WebCore/Modules/indexeddb/IDBTransaction.cpp

@@void IDBTransaction::removeRequest(IDBRequest& request)

{

    ASSERT(&m_database->originThread() == &Thread::current());

    m_openRequests.remove(&request);

386

387 trySchedulePendingOperationTimer();

}

void IDBTransaction::scheduleOperation(Ref<IDBClient::TransactionOperation>&& operation)

@@void IDBTransaction::scheduleOperation(Ref<IDBClient::TransactionOperation>&& op

    m_pendingTransactionOperationQueue.append(operation.copyRef());

    m_transactionOperationMap.set(identifier, WTFMove(operation));

397 schedulePendingOperationTimer();

399 trySchedulePendingOperationTimer();

398400}

399401

400 void IDBTransaction::schedulePendingOperationTimer()

402void IDBTransaction::trySchedulePendingOperationTimer()

{

    ASSERT(&m_database->originThread() == &Thread::current());

    if (!m_startedOnServer)

        return;

    // If the last in-progress operation we've sent to the server is not an IDBRequest operation,

    // then we have to wait until it completes before sending any more.

    if (!m_transactionOperationsInProgressQueue.isEmpty() && !m_transactionOperationsInProgressQueue.last()->nextRequestCanGoToServer())

        return;

    if (m_pendingTransactionOperationQueue.isEmpty() && (!m_transactionOperationMap.isEmpty() || !m_openRequests.isEmpty() || isFinishedOrFinishing()))

        return;

    if (!m_pendingOperationTimer.isActive())

        m_pendingOperationTimer.startOneShot(0_s);

}

@@void IDBTransaction::pendingOperationTimerFired()

    LOG(IndexedDB, "IDBTransaction::pendingOperationTimerFired (%p)", this);

    ASSERT(&m_database->originThread() == &Thread::current());

    if (!m_startedOnServer)

        return;

    // If the last in-progress operation we've sent to the server is not an IDBRequest operation,

    // then we have to wait until it completes before sending any more.

    if (!m_transactionOperationsInProgressQueue.isEmpty() && !m_transactionOperationsInProgressQueue.last()->nextRequestCanGoToServer())

        return;

    // We want to batch operations together without spinning the runloop for performance,

    // but don't want to affect responsiveness of the main thread.

    // This number is a good compromise in ad-hoc testing.

@@void IDBTransaction::finishedDispatchEventForRequest(IDBRequest& request)

void IDBTransaction::commit()

{

513 WTFLogAlways("sihuil: [%p]IDBTransaction::commit()", this);

    LOG(IndexedDB, "IDBTransaction::commit");

    ASSERT(&m_database->originThread() == &Thread::current());

    ASSERT(!isFinishedOrFinishing());

@@void IDBTransaction::didStart(const IDBError& error)

        return;

    }

560 schedulePendingOperationTimer();

566 trySchedulePendingOperationTimer();

}

void IDBTransaction::notifyDidAbort(const IDBError& error)

@@void IDBTransaction::operationCompletedOnClient(IDBClient::TransactionOperation&

    m_transactionOperationMap.remove(operation.identifier());

    m_transactionOperationsInProgressQueue.removeFirst();

1413 schedulePendingOperationTimer();

1419 trySchedulePendingOperationTimer();

}

void IDBTransaction::establishOnServer()

@@void IDBTransaction::deactivate()

    if (m_state == IndexedDB::TransactionState::Active)

        m_state = IndexedDB::TransactionState::Inactive;

1441 schedulePendingOperationTimer();

1447 trySchedulePendingOperationTimer();

}

void IDBTransaction::connectionClosedFromServer(const IDBError& error)

Source/WebCore/ChangeLog

Source/WebCore/Modules/indexeddb/IDBTransaction.cpp

Source/WebCore/Modules/indexeddb/IDBTransaction.h