ChangeLog

2019-05-08  Daniel Bates  <dabates@apple.com>

        [Legacy WebKit] REGRESSION (r238078): Crash in hardwareKeyboardAvailabilityChangedCallback()

        https://bugs.webkit.org/show_bug.cgi?id=197724

        <rdar://problem/49725959>

        Reviewed by NOBODY (OOPS!).

        Speculative fix for race condition. Between the time we receive a kGSEventHardwareKeyboardAvailabilityChangedNotification

        notification and when we schedule execution to run on the WebThread the WebView that notification

        was for may no longer exist. Take out a weak ptr on the WebView when we receive the notification

        and check that we still have it once we are running on the WebThread.

        * WebView/WebHTMLView.mm:

        (hardwareKeyboardAvailabilityChangedCallback):

2019-04-26  Keith Rollin  <krollin@apple.com>

        Enable new build rule for post-processing headers when using XCBuild

Source/WebKitLegacy/mac/WebView/WebHTMLView.mm

#import <wtf/ObjCRuntimeExtras.h>

#import <wtf/RunLoop.h>

#import <wtf/SystemTracing.h>

149#import <wtf/WeakObjCPtr.h>

#if PLATFORM(MAC)

#import "WebNSEventExtras.h"

@@static NSString * const WebMarkedTextUpdatedNotification = @"WebMarkedTextUpdate

static void hardwareKeyboardAvailabilityChangedCallback(CFNotificationCenterRef, void* observer, CFStringRef, const void*, CFDictionaryRef)

{

    ASSERT(observer);

824 auto weakWebView = WeakObjCPtr<WebHTMLView>((__bridge WebHTMLView *)observer);

823825 WebThreadRun(^{

        WebHTMLView *webView = (__bridge WebHTMLView *)observer;

        if (Frame* coreFrame = core([webView _frame]))

            coreFrame->eventHandler().capsLockStateMayHaveChanged();

        if (auto webView = weakWebView.get()) {

            if (auto* coreFrame = core([webView _frame]))

                coreFrame->eventHandler().capsLockStateMayHaveChanged();

        }

    });

}

#endif