ChangeLog

2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>

        Throw TypeError when custom element constructor returns a wrong element or tries to create itself

        https://bugs.webkit.org/show_bug.cgi?id=196892

        Reviewed by NOBODY (OOPS!).

        Throw TypeError instead of InvalidStateError for consistency. This updates WebKit's custom elements

        implementation for https://github.com/whatwg/html/pull/4525.

        Tests: imported/w3c/web-platform-tests/custom-elements/upgrading/Node-cloneNode.html

               imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html

        * bindings/js/JSCustomElementInterface.cpp:

        (WebCore::JSCustomElementInterface::upgradeElement):

        * bindings/js/JSHTMLElementCustom.cpp:

        (WebCore::constructJSHTMLElement):

2019-04-11  Ryosuke Niwa  <rniwa@webkit.org>

        WebThread should run at a higher priority than user initiated

244229

Source/WebCore/bindings/js/JSCustomElementInterface.cpp

@@void JSCustomElementInterface::upgradeEl

    Element* wrappedElement = JSElement::toWrapped(vm, returnedElement);

    if (!wrappedElement || wrappedElement != &element) {

        element.setIsFailedCustomElement(*this);

217 reportException(state, createDOMException(state, ~~InvalidStat~~eError, "Custom element constructor ~~fail~~ed t~~o upgrade an~~ element"));

217 reportException(state, createDOMException(state, TypeError, "Custom element constructor returned a wrong element"));

        return;

    }

    element.setIsDefinedCustomElement(*this);

244228

Source/WebCore/bindings/js/JSHTMLElementCustom.cpp

@@EncodedJSValue JSC_HOST_CALL constructJS

    Element* elementToUpgrade = elementInterface->lastElementInConstructionStack();

    if (!elementToUpgrade) {

92 throw~~InvalidStat~~eError(exec, scope, "Cannot instantiate a custom element inside its own constructor during upgrades"_s);

92 throwTypeError(&exec, scope, "Cannot instantiate a custom element inside its own constructor during upgrades"_s);

        return JSValue::encode(jsUndefined());

    }

244228

LayoutTests/imported/w3c/ChangeLog

2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>

        Throw TypeError when custom element constructor returns a wrong element or tries to create itself

        https://bugs.webkit.org/show_bug.cgi?id=196892

        Reviewed by NOBODY (OOPS!).

        Update the tests according to https://github.com/whatwg/html/pull/4525.

        * web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt:

        * web-platform-tests/custom-elements/upgrading/Node-cloneNode.html:

        * web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element-expected.txt:

        * web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html:

2019-04-12  Rob Buis  <rbuis@igalia.com>

        Import WPT preload tests

244237

LayoutTests/imported/w3c/web-platform-tests/custom-elements/upgrading/Node-cloneNode-expected.txt

@@FAIL Node.prototype.cloneNode(false) mus

PASS Node.prototype.cloneNode(false) must be able to clone a custom element inside an iframe 

PASS Node.prototype.cloneNode(true) must be able to clone a descendent custom element 

PASS Node.prototype.cloneNode(true) must set parentNode, previousSibling, and nextSibling before upgrading custom elements 

PASS HTMLElement constructor must throw an InvalidStateError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself after super() call 

PASS HTMLElement constructor must throw an InvalidStateError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself before super() call 

PASS Upgrading a custom element must throw InvalidStateError when the custom element's constructor returns another element 

PASS HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself after super() call 

PASS HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself before super() call 

PASS Upgrading a custom element must throw TypeError when the custom element's constructor returns another element 

1111PASS Inserting an element must not try to upgrade a custom element when it had already failed to upgrade once

1212

244228

LayoutTests/imported/w3c/web-platform-tests/custom-elements/upgrading/Node-cloneNode.html

@@test(function () {

    var uncaughtError;

    window.onerror = function (message, url, lineNumber, columnNumber, error) { uncaughtError = error; return true; }

    instance.cloneNode(false);

168 assert_equals(uncaughtError.name, '~~InvalidStat~~eError');

169 }, 'HTMLElement constructor must throw an ~~InvalidStat~~eError when the top of the construction stack is marked AlreadyConstructed'

168 assert_equals(uncaughtError.name, 'TypeError');

169}, 'HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed'

    + ' due to a custom element constructor constructing itself after super() call');

test(function () {

@@test(function () {

    var uncaughtError;

    window.onerror = function (message, url, lineNumber, columnNumber, error) { uncaughtError = error; return true; }

    instance.cloneNode(false);

186 assert_equals(uncaughtError.name, '~~InvalidStat~~eError');

187 }, 'HTMLElement constructor must throw an ~~InvalidStat~~eError when the top of the construction stack is marked AlreadyConstructed'

186 assert_equals(uncaughtError.name, 'TypeError');

187}, 'HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed'

    + ' due to a custom element constructor constructing itself before super() call');

test(function () {

@@test(function () {

    var uncaughtError;

    window.onerror = function (message, url, lineNumber, columnNumber, error) { uncaughtError = error; return true; }

    instance.cloneNode(false);

206 assert_equals(uncaughtError.name, '~~InvalidStat~~eError');

207 }, 'Upgrading a custom element must throw ~~InvalidStat~~eError when the custom element\'s constructor returns another element');

206 assert_equals(uncaughtError.name, 'TypeError');

207}, 'Upgrading a custom element must throw TypeError when the custom element\'s constructor returns another element');

test(function () {

    var instance = document.createElement('my-custom-element-throw-exception');

244228

LayoutTests/imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element-expected.txt

11

22PASS Element.prototype.createElement must add an unresolved custom element to the upgrade candidates map

PASS HTMLElement constructor must throw an InvalidStateError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself after super() call 

PASS HTMLElement constructor must throw an InvalidStateError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself before super() call 

PASS Upgrading a custom element must throw an InvalidStateError when the returned element is not SameValue as the upgraded element 

PASS HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself after super() call 

PASS HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed due to a custom element constructor constructing itself before super() call 

PASS Upgrading a custom element must throw an TypeError when the returned element is not SameValue as the upgraded element 

PASS Upgrading a custom element whose constructor returns a Text node must throw 

PASS Upgrading a custom element whose constructor returns an Element must throw

68

244228

LayoutTests/imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html

<instantiates-itself-before-super></instantiates-itself-before-super>

<my-other-element id="instance"></my-other-element>

<my-other-element id="otherInstance"></my-other-element>

18<not-an-element></not-an-element>

19<not-an-html-element></not-an-html-element>

<script>

setup({allow_uncaught_exception:true});

@@test(function () {

    var uncaughtError;

    window.onerror = function (message, url, lineNumber, columnNumber, error) { uncaughtError = error; return true; }

    customElements.define('instantiates-itself-after-super', InstantiatesItselfAfterSuper);

51 assert_equals(uncaughtError.name, '~~InvalidStat~~eError');

52 }, 'HTMLElement constructor must throw an ~~InvalidStat~~eError when the top of the construction stack is marked AlreadyConstructed'

53 assert_equals(uncaughtError.name, 'TypeError');

54}, 'HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed'

    + ' due to a custom element constructor constructing itself after super() call');

test(function () {

@@test(function () {

    var uncaughtError;

    window.onerror = function (message, url, lineNumber, columnNumber, error) { uncaughtError = error; return true; }

    customElements.define('instantiates-itself-before-super', InstantiatesItselfBeforeSuper);

67 assert_equals(uncaughtError.name, '~~InvalidStat~~eError');

68 }, 'HTMLElement constructor must throw an ~~InvalidStat~~eError when the top of the construction stack is marked AlreadyConstructed'

69 assert_equals(uncaughtError.name, 'TypeError');

70}, 'HTMLElement constructor must throw an TypeError when the top of the construction stack is marked AlreadyConstructed'

    + ' due to a custom element constructor constructing itself before super() call');

test(function () {

@@test(function () {

    var uncaughtError;

    window.onerror = function (message, url, lineNumber, columnNumber, error) { uncaughtError = error; return true; }

    customElements.define('my-other-element', MyOtherElement);

88 assert_equals(uncaughtError.name, '~~InvalidStat~~eError');

90 assert_equals(uncaughtError.name, 'TypeError');

    assert_true(document.createElement('my-other-element') instanceof MyOtherElement,

        'Upgrading of custom elements must happen after the definition was added to the registry.');

93 }, 'Upgrading a custom element must throw an InvalidStateError when the returned element is not SameValue as the upgraded element');

}, 'Upgrading a custom element must throw an TypeError when the returned element is not SameValue as the upgraded element');

test(() => {

  class NotAnElement extends HTMLElement {

    constructor() {

      return new Text();

    }

  }

  let uncaughtError;

  window.onerror = function (message, url, lineNumber, columnNumber, error) { uncaughtError = error; return true; }

  customElements.define("not-an-element", NotAnElement);

  assert_equals(uncaughtError.name, "TypeError");

}, "Upgrading a custom element whose constructor returns a Text node must throw");

test(() => {

  class NotAnHTMLElement extends HTMLElement {

    constructor() {

      return document.createElementNS("", "test");

    }

  }

  let uncaughtError;

  window.onerror = function (message, url, lineNumber, columnNumber, error) { uncaughtError = error; return true; }

  customElements.define("not-an-html-element", NotAnHTMLElement);

  assert_equals(uncaughtError.name, "TypeError");

}, "Upgrading a custom element whose constructor returns an Element must throw");

</script>

</body>

244228