ChangeLog

2017-11-16  Antoine Quint  <graouts@apple.com>

        Clean up KeyframeEffect

        https://bugs.webkit.org/show_bug.cgi?id=179777

        Reviewed by NOBODY (OOPS!).

        A few review comments came in after https://bugs.webkit.org/show_bug.cgi?id=179707 landed,

        addressing them with this follow-up patch.

        * animation/KeyframeEffect.cpp:

        (WebCore::KeyframeEffect::create): Use "keyframeEffect" instead of "result" for clarity.

        (WebCore::KeyframeEffect::processKeyframes): Use consistent index and length types while iterating

        over properties in PropertyNameArray and explicitly size the properties array since we already

        know its final size.

        * dom/Element.cpp:

        (WebCore::Element::getAnimations):

2017-11-15  Zalan Bujtas  <zalan@apple.com>

        AX triggers sync layout while building the render tree on www.macrumors.com.

Source/WebCore/animation/KeyframeEffect.cpp

@@using namespace JSC;

ExceptionOr<Ref<KeyframeEffect>> KeyframeEffect::create(ExecState& state, Element* target, Strong<JSObject>&& keyframes)

{

40 auto r~~esul~~t = adoptRef(*new KeyframeEffect(target));

40 auto keyframeEffect = adoptRef(*new KeyframeEffect(target));

4141

42 auto setKeyframesResult = r~~esul~~t->setKeyframes(state, WTFMove(keyframes));

42 auto setKeyframesResult = keyframeEffect->setKeyframes(state, WTFMove(keyframes));

    if (setKeyframesResult.hasException())

        return setKeyframesResult.releaseException();

46 return WTFMove(r~~esul~~t);

46 return WTFMove(keyframeEffect);

}

KeyframeEffect::KeyframeEffect(Element* target)

@@ExceptionOr<void> KeyframeEffect::processKeyframes(ExecState& state, Strong<JSOb

    StyleResolver& styleResolver = m_target->styleResolver();

    auto parserContext = CSSParserContext(HTMLStandardMode);

82 ~~const~~ auto* array = jsCast<const JSArray*>(keyframes.get());

82 auto* array = jsCast<const JSArray*>(keyframes.get());

    auto length = array->length();

    if (length != 2)

        return Exception { TypeError };

@@ExceptionOr<void> KeyframeEffect::processKeyframes(ExecState& state, Strong<JSOb

        size_t numberOfProperties = ownPropertyNames.size();

        StringBuilder cssText;

97 for (un~~sign~~ed j = 0; j < numberOfProperties; ++j) {

97 for (size_t j = 0; j < numberOfProperties; ++j) {

            cssText.append(ownPropertyNames[j].string());

            cssText.appendLiteral(": ");

            cssText.append(keyframe->get(&state, ownPropertyNames[j]).toWTFString(&state));

@@ExceptionOr<void> KeyframeEffect::processKeyframes(ExecState& state, Strong<JSOb

        styleProperties->parseDeclaration(cssText.toString(), parserContext);

        unsigned numberOfCSSProperties = styleProperties->propertyCount();

109 Vector<CSSPropertyID> properties;

109 Vector<CSSPropertyID> properties(numberOfCSSProperties);

110110 for (unsigned k = 0; k < numberOfCSSProperties; ++k) {

111 properties.append(styleProperties->propertyAt(k).id());

111 properties.uncheckedAppend(styleProperties->propertyAt(k).id());

            styleResolver.applyPropertyToStyle(styleProperties->propertyAt(k).id(), styleProperties->propertyAt(k).value(), WTFMove(renderStyle));

            renderStyle = styleResolver.state().takeStyle();

        }

Source/WebCore/ChangeLog

Source/WebCore/animation/KeyframeEffect.cpp

Source/WebCore/dom/Element.cpp