Tools/ChangeLog

 12017-09-04 Aakash Jain <aakash_jain@apple.com>
 2
 3 EWS should report when a step succeeds
 4 https://bugs.webkit.org/show_bug.cgi?id=176332
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 9 (AbstractEarlyWarningSystem.command_passed): Update the EWS status server when a command pass. This is
 10 similar to what is done in Commit Queue and Style Queue.
 11 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 12 (EarlyWarningSystemTest._default_expected_logs): Updated unit-tests appropriately.
 13
1142017-09-03 Filip Pizlo <fpizlo@apple.com>
215
316 WSL IntLiteral should have variable type so that it can unify with things like uint
221594

Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

@@class AbstractEarlyWarningSystem(Abstrac
127127 self.run_webkit_patch(command + [self._deprecated_port.flag()] + (['--architecture=%s' % self._port.architecture()] if self._port.architecture() and self._port.did_override_architecture else []))
128128
129129 def command_passed(self, message, patch):
130  pass
 130 self._update_status(message, patch=patch)
131131
132132 def command_failed(self, message, script_error, patch):
133133 failure_log = self._log_from_script_error_for_upload(script_error)
221594

Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

@@class EarlyWarningSystemTest(QueuesTest)
119119 }
120120
121121 if ews.should_build:
122  build_line = "Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\n" % string_replacements
 122 build_line = "Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\nMOCK: update_status: %(name)s Built patch\n" % string_replacements
123123 else:
124124 build_line = ""
125125 string_replacements['build_line'] = build_line
126126
127127 if ews.run_tests:
128  run_tests_line = "Running: webkit-patch --status-host=example.com build-and-test --no-clean --no-update --test --non-interactive --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\n" % string_replacements
 128 run_tests_line = "Running: webkit-patch --status-host=example.com build-and-test --no-clean --no-update --test --non-interactive --build-style=%(build_style)s --group=%(group)s --port=%(port)s%(architecture)s\nMOCK: update_status: %(name)s Passed tests\n" % string_replacements
129129 else:
130130 run_tests_line = ""
131131 string_replacements['run_tests_line'] = run_tests_line

@@class EarlyWarningSystemTest(QueuesTest)
140140 "begin_work_queue": self._default_begin_work_queue_logs(ews.name),
141141 "process_work_item": """MOCK: update_status: %(name)s Started processing patch
142142Running: webkit-patch --status-host=example.com clean --port=%(port)s%(architecture)s
 143MOCK: update_status: %(name)s Cleaned working directory
143144Running: webkit-patch --status-host=example.com update --port=%(port)s%(architecture)s
 145MOCK: update_status: %(name)s Updated working directory
144146Running: webkit-patch --status-host=example.com apply-attachment --no-update --non-interactive 10000 --port=%(port)s%(architecture)s
 147MOCK: update_status: %(name)s Applied patch
145148Running: webkit-patch --status-host=example.com check-patch-relevance --quiet --group=%(group)s --port=%(port)s%(architecture)s
 149MOCK: update_status: %(name)s Checked relevance of patch
146150%(build_line)s%(run_tests_line)s%(result_lines)s""" % string_replacements,
147151 "handle_unexpected_error": "Mock error message\n",
148152 "handle_script_error": "ScriptError error message\n\nMOCK output\n",
221594