Source/WebInspectorUI/ChangeLog

 12017-08-24 Ross Kirsling <ross.kirsling@sony.com>
 2
 3 Web Inspector: Views should explicitly remove event listeners from managers/Frame
 4 https://bugs.webkit.org/show_bug.cgi?id=175951
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
 9 (WI.ApplicationCacheDetailsSidebarPanel.prototype.closed):
 10 * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
 11 (WI.DOMNodeDetailsSidebarPanel.prototype.closed):
 12 * UserInterface/Views/DebuggerDashboardView.js:
 13 (WI.DebuggerDashboardView.prototype.closed):
 14 * UserInterface/Views/LogContentView.js:
 15 (WI.LogContentView.prototype.closed):
 16 * UserInterface/Views/NetworkGridContentView.js:
 17 (WI.NetworkGridContentView.prototype.closed):
 18 * UserInterface/Views/ProbeDetailsSidebarPanel.js:
 19 (WI.ProbeDetailsSidebarPanel.prototype.closed):
 20 * UserInterface/Views/QuickConsole.js:
 21 (WI.QuickConsole.prototype.closed):
 22 * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
 23 (WI.ScopeChainDetailsSidebarPanel.prototype.closed):
 24 * UserInterface/Views/TimelineOverview.js:
 25 (WI.TimelineOverview.prototype.closed):
 26
1272017-08-23 Nikita Vasilyev <nvasilyev@apple.com>
228
329 Web Inspector: Make lock icon crispier

Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js

@@WI.ApplicationCacheDetailsSidebarPanel = class ApplicationCacheDetailsSidebarPan
7272 this.needsLayout();
7373 }
7474
 75 closed()
 76 {
 77 WI.applicationCacheManager.removeEventListener(null, null, this);
 78
 79 super.closed();
 80 }
 81
7582 // Protected
7683
7784 initialLayout()

Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js

@@WI.DOMNodeDetailsSidebarPanel = class DOMNodeDetailsSidebarPanel extends WI.DOMD
3636 this._nodeRemoteObject = null;
3737 }
3838
 39 // Public
 40
 41 closed()
 42 {
 43 WI.domTreeManager.removeEventListener(null, null, this);
 44
 45 super.closed();
 46 }
 47
3948 // Protected
4049
4150 initialLayout()

Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.js

@@WI.DebuggerDashboardView = class DebuggerDashboardView extends WI.DashboardView
5656 this._rebuildLocation();
5757 }
5858
 59 // Public
 60
 61 closed()
 62 {
 63 WI.debuggerManager.removeEventListener(null, null, this);
 64
 65 super.closed();
 66 }
 67
5968 // Private
6069
6170 _rebuildLocation()

Source/WebInspectorUI/UserInterface/Views/LogContentView.js

@@WI.LogContentView = class LogContentView extends WI.ContentView
139139 this._logViewController.renderPendingMessages();
140140 }
141141
 142 closed()
 143 {
 144 WI.logManager.removeEventListener(null, null, this);
 145 WI.Frame.removeEventListener(null, null, this);
 146
 147 super.closed();
 148 }
 149
142150 didAppendConsoleMessageView(messageView)
143151 {
144152 console.assert(messageView instanceof WI.ConsoleMessageView || messageView instanceof WI.ConsoleCommandView);

Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js

@@WI.NetworkGridContentView = class NetworkGridContentView extends WI.ContentView
208208 super.closed();
209209
210210 this._dataGrid.closed();
 211
 212 WI.Frame.removeEventListener(null, null, this);
211213 }
212214
213215 reset()

Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js

@@WI.ProbeDetailsSidebarPanel = class ProbeDetailsSidebarPanel extends WI.DetailsS
5656 }
5757 }
5858
 59 closed()
 60 {
 61 WI.probeManager.removeEventListener(null, null, this);
 62
 63 super.closed();
 64 }
 65
5966 inspect(objects)
6067 {
6168 if (!(objects instanceof Array))

Source/WebInspectorUI/UserInterface/Views/QuickConsole.js

@@WI.QuickConsole = class QuickConsole extends WI.View
9797 WI.runtimeManager.activeExecutionContext = executionContext;
9898 }
9999
 100 closed()
 101 {
 102 WI.Frame.removeEventListener(null, null, this);
 103 WI.debuggerManager.removeEventListener(null, null, this);
 104 WI.runtimeManager.removeEventListener(null, null, this);
 105 WI.targetManager.removeEventListener(null, null, this);
 106
 107 super.closed();
 108 }
 109
100110 // Protected
101111
102112 layout()

Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js

@@WI.ScopeChainDetailsSidebarPanel = class ScopeChainDetailsSidebarPanel extends W
111111 this.needsLayout();
112112 }
113113
 114 closed()
 115 {
 116 WI.runtimeManager.removeEventListener(null, null, this);
 117 WI.Frame.removeEventListener(null, null, this);
 118 WI.debuggerManager.removeEventListener(null, null, this);
 119
 120 super.closed();
 121 }
 122
114123 // Protected
115124
116125 layout()

Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

@@WI.TimelineOverview = class TimelineOverview extends WI.View
362362 overviewGraph.hidden();
363363 }
364364
 365 closed()
 366 {
 367 WI.timelineManager.removeEventListener(null, null, this);
 368
 369 super.closed();
 370 }
 371
365372 reset()
366373 {
367374 for (let overviewGraph of this._overviewGraphsByTypeMap.values())