ChangeLog

2015-07-21  Jer Noble  <jer.noble@apple.com>

        [iOS] Add an explicit API to allow media documents to (temporarily) play inline

        https://bugs.webkit.org/show_bug.cgi?id=147181

        Reviewed by NOBODY (OOPS!).

        Add listeners for the new allowsMediaDocumentInlinePlayback API. When this value becomes

        NO, force any playing MediaDocuments to enter fullscreen mode.

        * dom/Document.cpp:

        (WebCore::Document::registerForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added registration method.

        (WebCore::Document::unregisterForAllowsMediaDocumentInlinePlaybackChangedCallbacks): Added deregistration method.

        (WebCore::Document::allowsMediaDocumentInlinePlaybackChanged): Notify all listeners.

        * dom/Document.h:

        * html/HTMLMediaElement.cpp:

        (WebCore::HTMLMediaElement::registerWithDocument): Listen for allowsMediaDocumentInlinePlayback changes.

        (WebCore::HTMLMediaElement::unregisterWithDocument): Stop listening to same.

        (WebCore::HTMLMediaElement::allowsMediaDocumentInlinePlaybackChanged): Enter fullscreen mode if the value

            changes to false during playback.

        * html/HTMLMediaElement.h:

        * html/MediaElementSession.cpp:

        (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback): Early true if the override value is set.

        * page/Page.cpp:

        (WebCore::Page::setAllowsMediaDocumentInlinePlayback): Notify all documents of the changed value.

        * page/Page.h:

        (WebCore::Page::allowsMediaDocumentInlinePlayback): Simple getter.

2015-07-20  Mark Lam  <mark.lam@apple.com>

        Rollout r187020 and r187021: breaks JSC API tests on debug builds.

Source/WebKit2/ChangeLog

2015-07-21  Jer Noble  <jer.noble@apple.com>

        [iOS] Add an explicit API to allow media documents to (temporarily) play inline

        https://bugs.webkit.org/show_bug.cgi?id=147181

        Reviewed by NOBODY (OOPS!).

        Add a WKWebView(Private) API which allows MediaDocuments loaded by the view to play their contents inline, regardless

        of whether inline playback is restricted on the current device.

        * UIProcess/API/Cocoa/WKWebView.mm:

        (-[WKWebView _setRequiresUserActionForMediaPlayback:]): Added. Pass through to WebPageProxy.

        (-[WKWebView _allowsMediaDocumentInlinePlayback]): Ditto.

        * UIProcess/API/Cocoa/WKWebViewPrivate.h:

        * UIProcess/WebPageProxy.cpp:

        (WebKit::WebPageProxy::allowsMediaDocumentInlinePlayback): Simple getter.

        (WebKit::WebPageProxy::setAllowsMediaDocumentInlinePlayback): Set, and conditionally pass the new value to WebPage.

        * UIProcess/WebPageProxy.h:

        * WebProcess/WebPage/WebPage.cpp:

        (WebKit::WebPage::setAllowsMediaDocumentInlinePlayback): Set, and conditionally notify WebCore page of the change.

        * WebProcess/WebPage/WebPage.h:

        (WebKit::WebPage::allowsMediaDocumentInlinePlayback): Simple getter.

        * WebProcess/WebPage/WebPage.messages.in: Add new messages.

2015-07-20  Tomas Popela  <tpopela@redhat.com>

        [GTK] Add selection-changed signal to the WebKit2 API

Source/WebCore/dom/Document.cpp

@@bool Document::hidden() const

    return pageVisibilityState() != PageVisibilityStateVisible;

}

#if ENABLE(VIDEO)

void Document::registerForAllowsMediaDocumentInlinePlaybackChangedCallbacks(HTMLMediaElement& element)

{

    m_allowsMediaDocumentInlinePlaybackElements.add(&element);

}

void Document::unregisterForAllowsMediaDocumentInlinePlaybackChangedCallbacks(HTMLMediaElement& element)

{

    m_allowsMediaDocumentInlinePlaybackElements.remove(&element);

}

void Document::allowsMediaDocumentInlinePlaybackChanged()

{

    for (auto* element : m_allowsMediaDocumentInlinePlaybackElements)

        element->allowsMediaDocumentInlinePlaybackChanged();

}

#endif

#if ENABLE(CSP_NEXT)

DOMSecurityPolicy& Document::securityPolicy()

{

Source/WebCore/dom/Document.h

@@public:

    void registerForVisibilityStateChangedCallbacks(Element*);

    void unregisterForVisibilityStateChangedCallbacks(Element*);

#if ENABLE(VIDEO)

    void registerForAllowsMediaDocumentInlinePlaybackChangedCallbacks(HTMLMediaElement&);

    void unregisterForAllowsMediaDocumentInlinePlaybackChangedCallbacks(HTMLMediaElement&);

    void allowsMediaDocumentInlinePlaybackChanged();

#endif

    WEBCORE_EXPORT void setShouldCreateRenderers(bool);

    bool shouldCreateRenderers();

@@private:

#endif

    HashSet<Element*> m_visibilityStateCallbackElements;

#if ENABLE(VIDEO)

    HashSet<HTMLMediaElement*> m_allowsMediaDocumentInlinePlaybackElements;

#endif

    HashMap<StringImpl*, Element*, CaseFoldingHash> m_elementsByAccessKey;

    bool m_accessKeyMapValid;

Source/WebCore/html/HTMLMediaElement.cpp

@@void HTMLMediaElement::registerWithDocument(Document& document)

    document.registerForPageCacheSuspensionCallbacks(this);

#endif

521 document.registerForAllowsMediaDocumentInlinePlaybackChangedCallbacks(*this);

522

    document.addAudioProducer(this);

    addElementToDocumentMap(*this, document);

}

@@void HTMLMediaElement::unregisterWithDocument(Document& document)

    document.unregisterForPageCacheSuspensionCallbacks(this);

#endif

555 document.unregisterForAllowsMediaDocumentInlinePlaybackChangedCallbacks(*this);

556

    document.removeAudioProducer(this);

    removeElementFromDocumentMap(*this, document);

}

@@void HTMLMediaElement::layoutSizeChanged()

    m_resizeTaskQueue.enqueueTask(task);

#endif

}

3885

3889

void HTMLMediaElement::setSelectedTextTrack(TextTrack* trackToSelect)

{

    TextTrackList* trackList = textTracks();

@@void HTMLMediaElement::setSessionInternal(MediaSession& session)

#endif

void HTMLMediaElement::allowsMediaDocumentInlinePlaybackChanged()

{

    if (potentiallyPlaying() && m_mediaSession->requiresFullscreenForVideoPlayback(*this) && !isFullscreen())

        enterFullscreen();

}

}

#endif

Source/WebCore/html/HTMLMediaElement.h

@@public:

    void layoutSizeChanged();

451 void allowsMediaDocumentInlinePlaybackChanged();

452

protected:

    HTMLMediaElement(const QualifiedName&, Document&, bool);

    virtual ~HTMLMediaElement();

Source/WebCore/html/MediaElementSession.cpp

@@MediaPlayer::Preload MediaElementSession::effectivePreloadForElement(const HTMLM

bool MediaElementSession::requiresFullscreenForVideoPlayback(const HTMLMediaElement& element) const

{

    Page* page = element.document().page();

    if (element.document().isMediaDocument() && !element.document().ownerElement() && page && page->allowsMediaDocumentInlinePlayback())

        return false;

    if (!PlatformMediaSessionManager::sharedManager().sessionRestrictsInlineVideoPlayback(*this))

        return false;

Source/WebCore/page/Page.cpp

@@WheelEventTestTrigger& Page::ensureTestTrigger()

    return *m_testTrigger;

}

#if ENABLE(VIDEO)

void Page::setAllowsMediaDocumentInlinePlayback(bool flag)

{

    if (m_allowsMediaDocumentInlinePlayback == flag)

        return;

    m_allowsMediaDocumentInlinePlayback = flag;

    Vector<Ref<Document>> documents;

    for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext())

        documents.append(*frame->document());

    for (auto& document : documents)

        document->allowsMediaDocumentInlinePlaybackChanged();

}

#endif

17391755} // namespace WebCore

Source/WebCore/page/Page.h

@@public:

    void clearTrigger() { m_testTrigger = nullptr; }

    bool expectsWheelEventTriggers() const { return !!m_testTrigger; }

#if ENABLE(VIDEO)

    WEBCORE_EXPORT bool allowsMediaDocumentInlinePlayback() const { return m_allowsMediaDocumentInlinePlayback; }

    WEBCORE_EXPORT void setAllowsMediaDocumentInlinePlayback(bool);

#endif

private:

    WEBCORE_EXPORT void initGroup();

@@private:

    MediaProducer::MediaStateFlags m_mediaState { MediaProducer::IsNotPlaying };

    bool m_userContentExtensionsEnabled { true };

627 bool m_allowsMediaDocumentInlinePlayback { false };

};

inline PageGroup& Page::group()

Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm

@@static inline WebKit::FindOptions toFindOptions(_WKFindOptions wkFindOptions)

    return nil;

}

#pragma mark media playback restrictions

- (BOOL)_allowsMediaDocumentInlinePlayback

{

#if PLATFORM(IOS)

    return _page->allowsMediaDocumentInlinePlayback();

#else

    return NO;

#endif

}

- (void)_setAllowsMediaDocumentInlinePlayback:(BOOL)flag

{

#if PLATFORM(IOS)

    _page->setAllowsMediaDocumentInlinePlayback(flag);

#endif

}

#pragma mark iOS-specific methods

#if PLATFORM(IOS)

Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h

@@WK_EXTERN NSString * const _WKShouldOpenExternalURLsKey WK_AVAILABLE(WK_MAC_TBA,

@property (nonatomic, readonly) NSArray *_scrollPerformanceData WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);

- (void)_saveBackForwardSnapshotForItem:(WKBackForwardListItem *)item WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);

@property (nonatomic, getter=_allowsMediaDocumentInlinePlayback, setter=_setAllowsMediaDocumentInlinePlayback:) BOOL _allowsMediaDocumentInlinePlayback;

@end

#endif

Source/WebKit2/UIProcess/WebPageProxy.cpp

@@RefPtr<WebVideoFullscreenManagerProxy> WebPageProxy::videoFullscreenManager()

{

    return m_videoFullscreenManager;

}

bool WebPageProxy::allowsMediaDocumentInlinePlayback() const

{

    return m_allowsMediaDocumentInlinePlayback;

}

void WebPageProxy::setAllowsMediaDocumentInlinePlayback(bool flag)

{

    if (m_allowsMediaDocumentInlinePlayback == flag)

        return;

    m_allowsMediaDocumentInlinePlayback = flag;

    m_process->send(Messages::WebPage::SetAllowsMediaDocumentInlinePlayback(flag), m_pageID);

}

#endif

// BackForwardList

Source/WebKit2/UIProcess/WebPageProxy.h

@@public:

#endif

#if PLATFORM(IOS)

    RefPtr<WebVideoFullscreenManagerProxy> videoFullscreenManager();

    bool allowsMediaDocumentInlinePlayback() const;

    void setAllowsMediaDocumentInlinePlayback(bool);

#endif

#if ENABLE(CONTEXT_MENUS)

@@private:

    WebCore::ViewState::Flags m_viewState;

    bool m_viewWasEverInWindow;

#if PLATFORM(IOS)

1580 bool m_allowsMediaDocumentInlinePlayback { false };

    bool m_alwaysRunsAtForegroundPriority;

    ProcessThrottler::ForegroundActivityToken m_activityToken;

#endif

Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@WebVideoFullscreenManager* WebPage::videoFullscreenManager()

        m_videoFullscreenManager = WebVideoFullscreenManager::create(this);

    return m_videoFullscreenManager.get();

}

void WebPage::setAllowsMediaDocumentInlinePlayback(bool flag)

{

    m_page->setAllowsMediaDocumentInlinePlayback(flag);

}

#endif

#if ENABLE(FULLSCREEN_API)

Source/WebKit2/WebProcess/WebPage/WebPage.h

@@public:

#if PLATFORM(IOS)

    WebVideoFullscreenManager* videoFullscreenManager();

239 void setAllowsMediaDocumentInlinePlayback(bool);

240 bool allowsMediaDocumentInlinePlayback() const { return m_allowsMediaDocumentInlinePlayback; }

#endif

#if ENABLE(FULLSCREEN_API)

@@private:

    RefPtr<WebInspectorUI> m_inspectorUI;

#if PLATFORM(IOS)

    RefPtr<WebVideoFullscreenManager> m_videoFullscreenManager;

1263 bool m_allowsMediaDocumentInlinePlayback { false };

#endif

#if ENABLE(FULLSCREEN_API)

    RefPtr<WebFullScreenManager> m_fullScreenManager;

Source/WebKit2/WebProcess/WebPage/WebPage.messages.in

@@messages -> WebPage LegacyReceiver {

    ContentSizeCategoryDidChange(String contentSizeCategory)

    ExecuteEditCommandWithCallback(String name, uint64_t callbackID)

    GetLookupContextAtPoint(WebCore::IntPoint point, uint64_t callbackID)

98 SetAllowsMediaDocumentInlinePlayback(bool flag)

#endif

#if ENABLE(REMOTE_INSPECTOR)