ChangeLog

112015-03-11 Joseph Pecoraro <pecoraro@apple.com>

        Web Inspector: Console Errors during provisional document loads get lost with "Clear Log on Reload"

        https://bugs.webkit.org/show_bug.cgi?id=142603

        Reviewed by NOBODY (OOPS!).

        * UserInterface/Views/LogContentView.js:

        (WebInspector.LogContentView.prototype._messageAdded):

        (WebInspector.LogContentView.prototype._provisionalLoadStarted):

        Detect a provisional load has started to start save messages that come in at this time.

        (WebInspector.LogContentView.prototype._sessionStarted):

        Reappend provisional load messages if we auto-cleared.

        (WebInspector.LogContentView.prototype._reappendProvisionalMessages):

        (WebInspector.LogContentView.prototype._clearProvisionalState):

        Helpers for dealing with the provisional loading state.

2015-03-11  Joseph Pecoraro  <pecoraro@apple.com>

        Web Inspector: CSS parser errors in the console should include column numbers

        https://bugs.webkit.org/show_bug.cgi?id=114313

Source/WebInspectorUI/UserInterface/Views/LogContentView.js

@@WebInspector.LogContentView = function(representedObject)

    this._nestingLevel = 0;

    this._selectedMessages = [];

    // FIXME: Try to use a marker, instead of a list of messages that get re-added.

    this._provisionalMessages = [];

    this.element.classList.add(WebInspector.LogContentView.StyleClassName);

    this.messagesElement = document.createElement("div");

@@WebInspector.LogContentView = function(representedObject)

    WebInspector.logManager.addEventListener(WebInspector.LogManager.Event.MessageAdded, this._messageAdded, this);

    WebInspector.logManager.addEventListener(WebInspector.LogManager.Event.PreviousMessageRepeatCountUpdated, this._previousMessageRepeatCountUpdated, this);

    WebInspector.logManager.addEventListener(WebInspector.LogManager.Event.ActiveLogCleared, this._activeLogCleared, this);

95 WebInspector.Frame.addEventListener(WebInspector.Frame.Event.ProvisionalLoadStarted, this._provisionalLoadStarted, this);

};

WebInspector.LogContentView.Scopes = {

@@WebInspector.LogContentView.prototype = {

    {

        if (this._clearLogOnReloadSetting.value)  {

            this._clearLog();

318 this._reappendProvisionalMessages();

            return;

        }

        this._logViewController.startNewSession();

323

324 this._clearProvisionalState();

    },

    _messageAdded: function(event)

    {

        if (this._startedProvisionalLoad)

            this._provisionalMessages.push(event.data.message);

        var message = this._logViewController.appendConsoleMessage(event.data.message);

        if (message.type !== WebInspector.ConsoleMessage.MessageType.EndGroup)

            this._filterMessages([message.toMessageElement()]);

@@WebInspector.LogContentView.prototype = {

        this._selectedSearchMatch.highlight.classList.add(WebInspector.LogContentView.SelectedStyleClassName);

        this._ensureMessageIsVisible(this._selectedSearchMatch.message);

    },

    _provisionalLoadStarted: function()

    {

        this._startedProvisionalLoad = true;

    },

    _reappendProvisionalMessages: function()

    {

        if (!this._startedProvisionalLoad)

            return;

        this._startedProvisionalLoad = false;

        for (var provisionalMessage of this._provisionalMessages) {

            var message = this._logViewController.appendConsoleMessage(provisionalMessage);

            if (message.type !== WebInspector.ConsoleMessage.MessageType.EndGroup)

                this._filterMessages([message.toMessageElement()]);

        }

        this._provisionalMessages = [];

    },

    _clearProvisionalState: function()

    {

        this._startedProvisionalLoad = false;

        this._provisionalMessages = [];

    }

};