ChangeLog

2014-12-08  Shivakumar JM  <shiva.jm@samsung.com>

        DOMError should be constructible as per the DOM4 specification.

        https://bugs.webkit.org/show_bug.cgi?id=139173

        Reviewed by NOBODY (OOPS!).

        DOMError should be constructible as per the DOM4 specification.

        I have confirmed this indeed matches the behavior of Chrome and Firefox. 

        The patch is inspired by the following Blink revision by

        <ch.dumez@samsung.com>:

        <https://src.chromium.org/viewvc/blink?view=revision&revision=172718>

        Test: fast/dom/DOMError-constructor.html

        * dom/DOMError.cpp:

        (WebCore::DOMError::DOMError):

        * dom/DOMError.h:

        (WebCore::DOMError::create):

        (WebCore::DOMError::message):

        * dom/DOMError.idl:

2014-12-08  Benjamin Poulain  <bpoulain@apple.com>

        Fix the iOS build after r177002

177006

Source/WebCore/dom/DOMError.cpp

namespace WebCore {

32 DOMError::DOMError(const String& name)

32DOMError::DOMError(const String& name, const String& message)

3333 : m_name(name)

34 , m_message(message)

{

}

176943

Source/WebCore/dom/DOMError.h

@@namespace WebCore {

class DOMError : public RefCounted<DOMError> {

public:

37 static PassRefPtr<DOMError> create(const String& name)

37 static PassRefPtr<DOMError> create(const String& name, const String& message = String())

3838 {

39 return adoptRef(new DOMError(name));

39 return adoptRef(new DOMError(name, message));

4040 }

41

    virtual ~DOMError() { }

    const String& name() const { return m_name; }

45 const String& message() const { return m_message; }

4446

4547protected:

46 explicit DOMError(const String& name);

48 explicit DOMError(const String& name, const String& message = String());

private:

    const String m_name;

52 const String m_message;

};

} // namespace WebCore

176943

Source/WebCore/dom/DOMError.idl

 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

 */

[

29 NoInter~~faceObject~~,

29 Constructor(DOMString name, [Default=NullString] optional DOMString message),

    SkipVTableValidation

] interface  DOMError {

    readonly attribute DOMString name;

33 readonly attribute DOMString message;

3334};

3435

176943

LayoutTests/ChangeLog

2014-12-08  Shivakumar JM  <shiva.jm@samsung.com>

        DOMError should be constructible as per the DOM4 specification.

        https://bugs.webkit.org/show_bug.cgi?id=139173

        Reviewed by NOBODY (OOPS!).

        The patch is inspired by the following Blink revision by

        <ch.dumez@samsung.com>:

        <https://src.chromium.org/viewvc/blink?view=revision&revision=172718>

        * fast/dom/DOMError-constructor-expected.txt: Added.

        * fast/dom/DOMError-constructor.html: Added.

        * js/dom/global-constructors-attributes-expected.txt:

        * platform/efl/js/dom/global-constructors-attributes-expected.txt:

        * platform/gtk/js/dom/global-constructors-attributes-expected.txt:

        * platform/mac/js/dom/global-constructors-attributes-expected.txt:

        * platform/win/js/dom/global-constructors-attributes-expected.txt:

2014-12-08  Myles C. Maxfield  <mmaxfield@apple.com>

        Rebaseline Mavericks test results after r176978.

177006

LayoutTests/fast/dom/DOMError-constructor-expected.txt

Tests for DOMError constructor.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS error = new DOMError('NotFoundError', 'This item was not found.') did not throw exception.

PASS error.name is "NotFoundError"

PASS error.message is "This item was not found."

PASS error = new DOMError('IndexSizeError') did not throw exception.

PASS error.name is "IndexSizeError"

PASS error.message is ""

PASS new DOMError() threw exception TypeError: Not enough arguments.

PASS successfullyParsed is true

TEST COMPLETE

0

LayoutTests/fast/dom/DOMError-constructor.html

<!DOCTYPE html>

<html>

<head>

<script src="../../resources/js-test.js"></script>

</head>

<body>

<script>

    description("Tests for DOMError constructor.");

    var error;

    shouldNotThrow("error = new DOMError('NotFoundError', 'This item was not found.')");

    shouldBeEqualToString("error.name", "NotFoundError");

    shouldBeEqualToString("error.message", "This item was not found.");

    shouldNotThrow("error = new DOMError('IndexSizeError')");

    shouldBeEqualToString("error.name", "IndexSizeError");

    shouldBeEqualToString("error.message", "");

    shouldThrow("new DOMError()", '"TypeError: Not enough arguments"');	

</script>

</body>

</html>

0

LayoutTests/js/dom/global-constructors-attributes-expected.txt