COMMIT_MESSAGE

1patch

2

Source/WebCore/ChangeLog

2013-10-15  Philippe Normand  <pnormand@igalia.com>

        [GStreamer] use a smart pointer for ::setStreamVolumeElement()

        https://bugs.webkit.org/show_bug.cgi?id=122832

        Reviewed by NOBODY (OOPS!).

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

        (WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):

        Use a smart pointer all the way from call site to member variable storage.

2013-10-15  Andreas Kling  <akling@apple.com>

        FileIconLoader should not be ref-counted.

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp

@@GstElement* MediaPlayerPrivateGStreamerBase::createVideoSink(GstElement* pipelin

#endif

}

618 void MediaPlayerPrivateGStreamerBase::setStreamVolumeElement(GstStreamVolume* volume)

618void MediaPlayerPrivateGStreamerBase::setStreamVolumeElement(GRefPtr<GstStreamVolume> volume)

{

    ASSERT(!m_volumeElement);

    m_volumeElement = volume;

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h

@@public:

protected:

    MediaPlayerPrivateGStreamerBase(MediaPlayer*);

    GstElement* createVideoSink(GstElement* pipeline);

115 void setStreamVolumeElement(GstStreamVolume*);

115 void setStreamVolumeElement(GRefPtr<GstStreamVolume>);

    virtual GstElement* audioSink() const { return 0; }

    GRefPtr<GstCaps> currentVideoSinkCaps() const;