ChangeLog

2013-10-04  Darin Adler  <darin@apple.com>

        text-transform: lowercase is not lang-dependent (Turkish languages : tr,az)

        https://bugs.webkit.org/show_bug.cgi?id=21312

        Reviewed by NOBODY (OOPS!).

        * wtf/text/StringImpl.cpp:

        (WTF::StringImpl::upper): Removed an extra call that would unnecessarily reallocate

        a StringImpl in the general non-ASCII case. Added an overload that takes a locale identifier.

        (WTF::StringImpl::lower): Ditto.

        * wtf/text/StringImpl.h: Ditto.

        * wtf/text/WTFString.cpp:

        (WTF::String::lower): Ditto.

        (WTF::String::upper): Ditto.

        * wtf/text/WTFString.h: Ditto. Also deleted the makeLower and makeUpper functions since they

        offer no advantages over the lower and upper functions.

2013-10-02  Brent Fulgham  <bfulgham@apple.com>

        [Win] Update solutions and projects to support 64-bit build.

Source/WebCore/ChangeLog

2013-10-04  Darin Adler  <darin@apple.com>

        text-transform: lowercase is not lang-dependent (Turkish languages : tr,az)

        https://bugs.webkit.org/show_bug.cgi?id=21312

        Reviewed by NOBODY (OOPS!).

        Test: fast/text/text-transform-turkish-and-azeri.html

        * inspector/DOMPatchSupport.cpp:

        (WebCore::DOMPatchSupport::patchNode): Use String::upper instead of String::makeUpper.

        * page/EventHandler.cpp:

        (WebCore::findDropZone): Use String::lower instead of String::makeLower.

        * rendering/RenderText.cpp:

        (WebCore::applyTextTransform): Use String::upper and String::lower instead of

        String::makeUpper and String::makeLower, and also pass in the locale to each.

        * xml/XMLHttpRequest.cpp:

        (WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod): Changed this so it doesn't call

        upper just to return an already known string constant.

2013-10-04  Krzysztof Wolanski  <k.wolanski@samsung.com>

        [EFL] Enable correct behaviour for deleting regional indicator symbols

Source/WTF/wtf/text/StringImpl.cpp

@@upconvert:

    // Do a slower implementation for cases that include non-ASCII characters.

    bool error;

555 newImpl = createUninitialized(m_length, data16);

    int32_t realLength = Unicode::toUpper(data16, length, source16, m_length, &error);

    if (!error && realLength == length)

        return newImpl;

@@upconvert:

    return newImpl.release();

}

566 ~~Pass~~RefPtr<StringImpl> StringImpl::~~fill(UChar charact~~er)

565RefPtr<StringImpl> StringImpl::lower(const AtomicString& localeIdentifier)

567566{

568 if (!m_length)

#if !USE(ICU_UNICODE)

    UNUSED_PARAM(localeIdentifier);

    return lower();

#else

    // Use the more-optimized code path most of the time.

    if (!(localeIdentifier == "tr" || localeIdentifier == "az"))

        return lower();

    if (m_length > static_cast<unsigned>(numeric_limits<int32_t>::max()))

        CRASH();

    int length = m_length;

    const UChar* source16 = characters();

    UChar* data16;

    RefPtr<StringImpl> newString = createUninitialized(length, data16);

    UErrorCode status = U_ZERO_ERROR;

    int realLength = u_strToLower(data16, length, source16, length, "tr", &status);

    if (U_SUCCESS(status) && realLength == length)

        return newString;

    newString = createUninitialized(realLength, data16);

    u_strToLower(data16, realLength, source16, length, "tr", &status);

    if (U_FAILURE(status))

569589 return this;

    return newString.release();

#endif

}

570593

RefPtr<StringImpl> StringImpl::upper(const AtomicString& localeIdentifier)

{

#if !USE(ICU_UNICODE)

    UNUSED_PARAM(localeIdentifier);

    return upper();

#else

    // Use the more-optimized code path most of the time.

    if (!(localeIdentifier == "tr" || localeIdentifier == "az") || find('i') == notFound)

        return upper();

    if (m_length > static_cast<unsigned>(numeric_limits<int32_t>::max()))

        CRASH();

    int length = m_length;

    const UChar* source16 = characters();

    UChar* data16;

    RefPtr<StringImpl> newString = createUninitialized(length, data16);

    UErrorCode status = U_ZERO_ERROR;

    int realLength = u_strToUpper(data16, length, source16, length, "tr", &status);

    if (U_SUCCESS(status) && realLength == length)

        return newString;

    newString = createUninitialized(realLength, data16);

    u_strToUpper(data16, realLength, source16, length, "tr", &status);

    if (U_FAILURE(status))

        return this;

    return newString.release();

#endif

}

PassRefPtr<StringImpl> StringImpl::fill(UChar character)

{

    if (!(character & ~0x7F)) {

        LChar* data;

        RefPtr<StringImpl> newImpl = createUninitialized(m_length, data);

Source/WTF/wtf/text/StringImpl.h

@@public:

    WTF_EXPORT_STRING_API PassRefPtr<StringImpl> lower();

    WTF_EXPORT_STRING_API PassRefPtr<StringImpl> upper();

690 WTF_EXPORT_STRING_API RefPtr<StringImpl> lower(const AtomicString& localeIdentifier);

691 WTF_EXPORT_STRING_API RefPtr<StringImpl> upper(const AtomicString& localeIdentifier);

    WTF_EXPORT_STRING_API PassRefPtr<StringImpl> fill(UChar);

    // FIXME: Do we need fill(char) or can we just do the right thing if UChar is ASCII?

Source/WTF/wtf/text/WTFString.cpp

@@String String::upper() const

    return m_impl->upper();

}

String String::lower(const AtomicString& localeIdentifier) const

{

    if (!m_impl)

        return String();

    return m_impl->lower(localeIdentifier);

}

String String::upper(const AtomicString& localeIdentifier) const

{

    if (!m_impl)

        return String();

    return m_impl->upper(localeIdentifier);

}

String String::stripWhiteSpace() const

{

    if (!m_impl)

Source/WTF/wtf/text/WTFString.h

@@public:

    // Construct a string referencing an existing StringImpl.

    String(StringImpl* impl) : m_impl(impl) { }

    String(PassRefPtr<StringImpl> impl) : m_impl(impl) { }

125 String(RefPtr<StringImpl>&& impl) : m_impl(impl) { }

    // Construct a string from a constant string literal.

    WTF_EXPORT_STRING_API String(ASCIILiteral characters);

@@public:

        return *this;

    }

321 void makeLower() { if (m_impl) m_impl = m_impl->lower(); }

322 void makeUpper() { if (m_impl) m_impl = m_impl->upper(); }

    void fill(UChar c) { if (m_impl) m_impl = m_impl->fill(c); }

    WTF_EXPORT_STRING_API void truncate(unsigned len);

@@public:

    WTF_EXPORT_STRING_API String lower() const;

    WTF_EXPORT_STRING_API String upper() const;

    WTF_EXPORT_STRING_API String lower(const AtomicString& localeIdentifier) const;

    WTF_EXPORT_STRING_API String upper(const AtomicString& localeIdentifier) const;

    WTF_EXPORT_STRING_API String stripWhiteSpace() const;

    WTF_EXPORT_STRING_API String stripWhiteSpace(IsWhiteSpaceFunctionPtr) const;

    WTF_EXPORT_STRING_API String simplifyWhiteSpace() const;

Source/WebCore/inspector/DOMPatchSupport.cpp

@@Node* DOMPatchSupport::patchNode(Node* node, const String& markup, ExceptionCode

        oldList.append(createDigest(child, 0));

    // Compose the new list.

145 String markupCopy = markup;

146 markupCopy.makeLower();

145 String markupCopy = markup.lower();

    Vector<OwnPtr<Digest> > newList;

    for (Node* child = parentNode->firstChild(); child != node; child = child->nextSibling())

        newList.append(createDigest(child, 0));

Source/WebCore/page/EventHandler.cpp

@@static bool findDropZone(Node* target, Clipboard* clipboard)

        if (dropZoneStr.isEmpty())

            continue;

2064 dropZoneStr~~.makeL~~ower();

2064 dropZoneStr = dropZoneStr.lower();

        
        SpaceSplitString keywords(dropZoneStr, false);

        if (keywords.isEmpty())

Source/WebCore/rendering/RenderText.cpp

@@void applyTextTransform(const RenderStyle* style, String& text, UChar previousCh

        makeCapitalized(&text, previousCharacter);

        break;

    case UPPERCASE:

1334 text~~.makeU~~pper();

1334 text = text.upper(style->locale());

13351335 break;

13361336 case LOWERCASE:

1337 text~~.makeL~~ower();

1337 text = text.lower(style->locale());

        break;

    }

}

Source/WebCore/xml/XMLHttpRequest.cpp

@@bool XMLHttpRequest::isAllowedHTTPMethod(const String& method)

String XMLHttpRequest::uppercaseKnownHTTPMethod(const String& method)

{

    if (equalIgnoringCase(method, "COPY") || equalIgnoringCase(method, "DELETE") || equalIgnoringCase(method, "GET")

        || equalIgnoringCase(method, "HEAD") || equalIgnoringCase(method, "INDEX") || equalIgnoringCase(method, "LOCK")

        || equalIgnoringCase(method, "M-POST") || equalIgnoringCase(method, "MKCOL") || equalIgnoringCase(method, "MOVE")

        || equalIgnoringCase(method, "OPTIONS") || equalIgnoringCase(method, "POST") || equalIgnoringCase(method, "PROPFIND")

        || equalIgnoringCase(method, "PROPPATCH") || equalIgnoringCase(method, "PUT") || equalIgnoringCase(method, "UNLOCK")) {

        return method.upper();

    const char* const methods[] = { "COPY", "DELETE", "GET", "HEAD", "INDEX", "LOCK", "M-POST", "MKCOL", "MOVE", "OPTIONS", "POST", "PROPFIND", "PROPPATCH", "PUT", "UNLOCK" };

    for (unsigned i = 0; i < WTF_ARRAY_LENGTH(methods); ++i) {

        if (equalIgnoringCase(method, methods[i])) {

            // Don't bother allocating a new string if it's already all uppercase.

            if (method == methods[i])

                break;

            return ASCIILiteral(methods[i]);

        }

    }

    return method;

}

LayoutTests/ChangeLog

2013-10-04  Darin Adler  <darin@apple.com>

        text-transform: lowercase is not lang-dependent (Turkish languages : tr,az)

        https://bugs.webkit.org/show_bug.cgi?id=21312

        Reviewed by NOBODY (OOPS!).

        * fast/text/text-transform-turkish-and-azeri-expected.html: Added.

        * fast/text/text-transform-turkish-and-azeri.html: Added.

2013-10-04  Krzysztof Wolanski  <k.wolanski@samsung.com>

        [EFL] Enable correct behaviour for deleting regional indicator symbols

LayoutTests/fast/text/text-transform-turkish-and-azeri-expected.html

<!DOCTYPE html>

<html>

<head><meta charset="utf-8"></head>

<body>

<p>Turkish uppercasing (each pair should match): İ İ, I I.</p>

<p>Turkish lowercasing (each pair should match): i i, i i, ı ı.</p>

<p>Azeri uppercasing (each pair should match): İ İ, I I.</p>

<p>Azeri lowercasing (each pair should match): i i, i i, ı ı.</p>

</body>

</html>

LayoutTests/fast/text/text-transform-turkish-and-azeri.html

<!DOCTYPE html>

<html>

<head><meta charset="utf-8"></head>

<body>

<p>Turkish uppercasing (each pair should match): <span lang="tr" style="text-transform: uppercase">i İ, ı I</span>.</p>

<p>Turkish lowercasing (each pair should match): <span lang="tr" style="text-transform: lowercase">İ i, İ i, I ı</span>.</p>

<p>Azeri uppercasing (each pair should match): <span lang="az" style="text-transform: uppercase">i İ, ı I</span>.</p>

<p>Azeri lowercasing (each pair should match): <span lang="az" style="text-transform: lowercase">İ i, İ i, I ı</span>.</p>

</body>

</html>