ChangeLog

2013-08-02  Arpita Bahuguna  <a.bah@samsung.com>

        createAttribute/setAttributeNode does not properly normalize case

        https://bugs.webkit.org/show_bug.cgi?id=90341

        Reviewed by NOBODY (OOPS!).

        setAttributeNode() verifies for existing attributes in a case sensitive

        manner. Thus, it would add another attribute if specified in a case

        different from the existing one. Instead, like setAttribute(), it too

        should modify the existing attribute's value.

        Test: fast/dom/Element/setAttributeNode-case-insensitivity.html

        * dom/Element.cpp:

        (WebCore::Element::setAttributeNode):

        Passing the second param (shouldIgnoreAttributeCase) to

        getAttributeItemIndexForAttributeNode() method. We are now letting

        getAttributeItemIndexForAttributeNode() handle the case-sensitive/insensitive

        checking.

        (WebCore::ElementData::getAttributeItemIndexForAttributeNode):

        * dom/Element.h:

        Added shouldIgnoreAttributeCase boolean param to the method. It passes

        this on to QualifiedName::matches() method.

        * dom/QualifiedName.h:

        (WebCore::QualifiedName::matches):

        Added shouldIgnoreCase param. In turn it calls equalPossiblyIgnoringCase()

        with this param to perform a case-insenstive comparison.

2013-08-02  Patrick Gansterer  <paroga@webkit.org>

        [WIN] Fix build without precompiled header.

153645

Source/WebCore/dom/Element.cpp

@@PassRefPtr<Attr> Element::setAttributeNo

    synchronizeAllAttributes();

    UniqueElementData* elementData = ensureUniqueElementData();

1925 unsigned index = elementData->getAttributeItemIndexForAttributeNode(attrNode);

1925 unsigned index = elementData->getAttributeItemIndexForAttributeNode(attrNode, shouldIgnoreAttributeCase(this));

    if (index != ElementData::attributeNotFound) {

        if (oldAttrNode)

            detachAttrNodeFromElementWithValue(oldAttrNode.get(), elementData->attributeItem(index)->value());

@@unsigned ElementData::getAttributeItemIn

    return attributeNotFound;

}

3416 unsigned ElementData::getAttributeItemIndexForAttributeNode(const Attr* attr) const

3416unsigned ElementData::getAttributeItemIndexForAttributeNode(const Attr* attr, bool shouldIgnoreAttributeCase) const

{

    ASSERT(attr);

    const Attribute* attributes = attributeBase();

    unsigned count = length();

    for (unsigned i = 0; i < count; ++i) {

3422 if (attributes[i].name() == attr->qualifiedName())

3422 if (attributes[i].name().matches(attr->qualifiedName(), shouldIgnoreAttributeCase))

            return i;

    }

    return attributeNotFound;

153645

Source/WebCore/dom/Element.h

@@public:

    const Attribute* getAttributeItem(const QualifiedName&) const;

    unsigned getAttributeItemIndex(const QualifiedName&) const;

    unsigned getAttributeItemIndex(const AtomicString& name, bool shouldIgnoreAttributeCase) const;

83 unsigned getAttributeItemIndexForAttributeNode(const Attr*) const;

83 unsigned getAttributeItemIndexForAttributeNode(const Attr*, bool shouldIgnoreAttributeCase = false) const;

    bool hasID() const { return !m_idForStyleResolution.isNull(); }

    bool hasClass() const { return !m_classNames.isNull(); }

153645

Source/WebCore/dom/QualifiedName.h

@@public:

    bool operator==(const QualifiedName& other) const { return m_impl == other.m_impl; }

    bool operator!=(const QualifiedName& other) const { return !(*this == other); }

82 bool matches(const QualifiedName& other) const { return m_impl == other.m_impl || (localName() == other.localName() && namespaceURI() == other.namespaceURI()); }

82 bool matches(const QualifiedName& other, bool shouldIgnoreCase = false) const { return m_impl == other.m_impl || (equalPossiblyIgnoringCase(localName(), other.localName(), shouldIgnoreCase) && namespaceURI() == other.namespaceURI()); }

    bool hasPrefix() const { return m_impl->m_prefix != nullAtom; }

    void setPrefix(const AtomicString& prefix) { *this = QualifiedName(prefix, localName(), namespaceURI()); }

153645

LayoutTests/ChangeLog

2013-08-02  Arpita Bahuguna  <a.bah@samsung.com>

        createAttribute/setAttributeNode does not properly normalize case

        https://bugs.webkit.org/show_bug.cgi?id=90341

        * fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt: Added.

        * fast/dom/Element/setAttributeNode-case-insensitivity.html: Added.

        Testcase for verifying that setAttributeNode() checks against existing

        attributes in a case insensitive manner. It updates the value of an

        existing attribute (in lower case) with that of the one set using

        setAttributeNode() (in upper case).

        The test also verifies the behavior of attributes when specified with

        namespace and prefix.

2013-08-02  Zalan Bujtas  <zalan@apple.com>

        Frame flattening: Change the logic on whether resize event needs to be dispatched.

153645

LayoutTests/fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt

Test for Bugzilla bug: 90341: createAttribute/setAttributeNode does not properly normalize case.

This test verifies that the setAttributeNode() API checks for existing attributes case-insensitively. Thus the value of an existing attribute with the same name but in a different case should get replaced by the new value specified via the setAttributeNode() method. The issue can be manually verified if a green colored block is displayed instead of a red one.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS test.getAttribute('style') is test.getAttribute('STYLE')

PASS test.getAttributeNode('style').value is test.getAttributeNode('STYLE').value

Verifying that attributes with the same name but different namespaces are treated as unique entities. For the following test two different attribute values should be returned.

PASS test.getAttributeNodeNS('ns1', 'newattr').value is 'newattr1'

PASS test.getAttributeNodeNS('ns2', 'newattr').value is 'newattr2'

Verifying that attributes with same name but different case and having same namespaces are treated as same. In the following test the new attribute should overwrite the value of the existing one.

PASS test.getAttributeNodeNS('ns1', 'newattr').value is 'newattr3'

PASS successfullyParsed is true

TEST COMPLETE

0

LayoutTests/fast/dom/Element/setAttributeNode-case-insensitivity.html

<html>

<head>

<style>

#test {

    font-family: ahem;

    width: 50;

    height: 50;

}

</style>

<script src="../../js/resources/js-test-pre.js"></script>

<script>

function runTest()

{

    description("This test verifies that the setAttributeNode() API checks for existing attributes case-insensitively. Thus the value of an existing attribute with the same name but in a different case should get replaced by the new value specified via the setAttributeNode() method.\nThe issue can be manually verified if a green colored block is displayed instead of a red one.");

    var test = document.getElementById("test");

    var newStyleAttr = document.createAttribute("STYLE");

    newStyleAttr.value = "background-color: green";

    test.setAttributeNode(newStyleAttr);

    if (window.testRunner) {

        shouldBe("test.getAttribute('style')", "test.getAttribute('STYLE')");

        shouldBe("test.getAttributeNode('style').value", "test.getAttributeNode('STYLE').value");

    }

    debug("Verifying that attributes with the same name but different namespaces are treated as unique entities. For the following test two different attribute values should be returned.");

    var newAttr1 = document.createAttributeNS("ns1", "newattr");

    newAttr1.prefix = "prefix1";

    newAttr1.value = "newattr1";

    test.setAttributeNode(newAttr1);

    var newAttr2 = document.createAttributeNS("ns2", "newattr");

    newAttr2.prefix = "prefix2";

    newAttr2.value = "newattr2";

    test.setAttributeNode(newAttr2);

    if (window.testRunner) {

        shouldBe("test.getAttributeNodeNS('ns1', 'newattr').value", "'newattr1'");

        shouldBe("test.getAttributeNodeNS('ns2', 'newattr').value", "'newattr2'");

    }

    debug("Verifying that attributes with same name but different case and having same namespaces are treated as same. In the following test the new attribute should overwrite the value of the existing one.");

    var newAttr3 = document.createAttributeNS("ns1", "NEWATTR");

    newAttr3.prefix = "prefix2";

    newAttr3.value = "newattr3";

    test.setAttributeNode(newAttr3);

    if (window.testRunner) {

        shouldBe("test.getAttributeNodeNS('ns1', 'newattr').value", "'newattr3'");

        isSuccessfullyParsed();    

        test.style.display = 'none';

    }

}

</script>

</head>

<body onload="runTest()">

<div>Test for Bugzilla bug:<a href="https://bugs.webkit.org/show_bug.cgi?id=90341"> 90341:</a>  createAttribute/setAttributeNode does not properly normalize case.</div>

<div id="test" style="background-color: red">&nbsp;</div>

<div id="description"></div>

<div id="console"></div>

</body>

</html>

0