ChangeLog

2012-08-29  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: display the number of dirty render objects in Layout timeline event

        https://bugs.webkit.org/show_bug.cgi?id=95331

        Reviewed by NOBODY (OOPS!).

        Count the render objects that need layout in InspectorTimelineAgent::willLayout()

            and display the number in popover over Layout record in Timeline panel.

        * inspector/InspectorTimelineAgent.cpp:

        (WebCore::InspectorTimelineAgent::willLayout):

        * inspector/TimelineRecordFactory.cpp:

        (WebCore):

        (WebCore::TimelineRecordFactory::createLayoutData):

        * inspector/TimelineRecordFactory.h:

        (TimelineRecordFactory):

        * inspector/front-end/TimelinePresentationModel.js:

        (WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):

2013-03-22  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: timeline paint rectangles are off for transformed layers

Source/WebCore/inspector/InspectorTimelineAgent.cpp

@@void InspectorTimelineAgent::didInvalidateLayout(Frame* frame)

void InspectorTimelineAgent::willLayout(Frame* frame)

{

266 pushCurrentRecord(InspectorObject::create(), TimelineRecordType::Layout, true, frame);

    RenderObject* root = frame->view()->layoutRoot();

    if (!root)

        root = frame->document()->renderer();

    int needLayoutCount = 0;

    for (RenderObject* o = root; o;) {

        if (!root->needsLayout()) {

            o = o->nextInPreOrderAfterChildren();

            continue;

        }

        ++needLayoutCount;

        o = o->nextInPreOrder();

    }

    pushCurrentRecord(TimelineRecordFactory::createLayoutData(needLayoutCount), TimelineRecordType::Layout, true, frame);

}

void InspectorTimelineAgent::didLayout(RenderObject* root)

@@void InspectorTimelineAgent::didLayout(RenderObject* root)

    Vector<FloatQuad> quads;

    root->absoluteQuads(quads);

    if (quads.size() >= 1)

278 ~~entry.data =~~ TimelineRecordFactory::cr~~eate~~LayoutData(quads[0]);

290 TimelineRecordFactory::appendLayoutRoot(entry.data.get(), quads[0]);

    else

        ASSERT_NOT_REACHED();

    didCompleteCurrentRecord(TimelineRecordType::Layout);

Source/WebCore/inspector/TimelineRecordFactory.cpp

@@PassRefPtr<InspectorObject> TimelineRecordFactory::createReceiveResourceData(con

    data->setNumber("encodedDataLength", length);

    return data.release();

}

PassRefPtr<InspectorObject> TimelineRecordFactory::createLayoutData(int nodeCount)

{

    RefPtr<InspectorObject> data = InspectorObject::create();

    data->setNumber("nodeCount", nodeCount);

    return data.release();

}

    
PassRefPtr<InspectorObject> TimelineRecordFactory::createDecodeImageData(const String& imageType)

{

@@PassRefPtr<InspectorObject> TimelineRecordFactory::createPaintData(const FloatQu

    return data.release();

}

238 ~~PassRefPtr<InspectorObject>~~ TimelineRecordFactory::cr~~eate~~LayoutData(const FloatQuad& quad)

245void TimelineRecordFactory::appendLayoutRoot(InspectorObject* data, const FloatQuad& quad)

239246{

240 RefPtr<InspectorObject> data = InspectorObject::create();

241247 data->setArray("root", createQuad(quad));

242 return data.release();

}

} // namespace WebCore

Source/WebCore/inspector/TimelineRecordFactory.h

@@namespace WebCore {

        static PassRefPtr<InspectorObject> createResourceFinishData(const String& requestId, bool didFail, double finishTime);

83 static void addRectData(InspectorObject*, const LayoutRect&);

        static PassRefPtr<InspectorObject> createLayoutData(int nodeCount);

        static PassRefPtr<InspectorObject> createPaintData(const LayoutRect&);

        static PassRefPtr<InspectorObject> createDecodeImageData(const String& imageType);

@@namespace WebCore {

        static PassRefPtr<InspectorObject> createPaintData(const FloatQuad&);

97 static P~~assRefPtr<~~InspectorObject> ~~createLayoutD~~ata(const FloatQuad&);

99 static void appendLayoutRoot(InspectorObject* data, const FloatQuad&);

#if ENABLE(WEB_SOCKETS)

        static inline PassRefPtr<InspectorObject> createWebSocketCreateData(unsigned long identifier, const KURL& url, const String& protocol)

Source/WebCore/inspector/front-end/TimelinePresentationModel.js

@@WebInspector.TimelinePresentationModel.Record.prototype = {

                callStackLabel = WebInspector.UIString("Styles recalculation forced");

                break;

            case recordTypes.Layout:

1048 if (this.data["nodeCount"])

1049 contentHelper.appendTextRow(WebInspector.UIString("Nodes to layout"), this.data["nodeCount"]);

                callSiteStackTraceLabel = WebInspector.UIString("Layout invalidated");

                if (this.stackTrace) {

                    callStackLabel = WebInspector.UIString("Layout forced");

LayoutTests/ChangeLog

2012-08-29  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: display the number of dirty render objects in Layout timeline event

        https://bugs.webkit.org/show_bug.cgi?id=95331

        Reviewed by NOBODY (OOPS!).

        * inspector/timeline/timeline-layout-expected.txt: rebaselined to include nodeCount;

        * inspector/timeline/timeline-test.js: added nodeCount to custom formatted timeline record fields;

2013-03-22  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: timeline paint rectangles are off for transformed layers

LayoutTests/http/tests/inspector/timeline-test.js

@@InspectorTest.timelinePropertyFormatters = {

    identifier: "formatAsTypeName",

    clip: "formatAsTypeName",

    root: "formatAsTypeName",

25 nodeCount: "formatAsTypeName",

};

InspectorTest.startTimeline = function(callback)

LayoutTests/inspector/timeline/timeline-layout-expected.txt

@@Layout Properties:

    children : <object>

    counters : <object>

    data : {

9 nodeCount : <number>

        root : <object>

    }

    endTime : <number>