ChangeLog

2012-10-02  Oli Lan  <olilan@chromium.org>

        [chromium] Allow long press to select word on Android.

        https://bugs.webkit.org/show_bug.cgi?id=98173

        Reviewed by NOBODY (OOPS!).

        This patch implements the long press selection behaviour required for Android. This means

        that a long press gesture performed on an unselected word (that is not part of a link)

        selects the word, without generating a context menu event).

        A new test, WebViewTest.LongPressSelection has been added to test this.        

        * src/WebViewImpl.cpp:

        (WebKit::WebViewImpl::handleGestureEvent):

        (WebKit::WebViewImpl::selectNonLinkWordAroundWindowPoint):

        (WebKit):

        * src/WebViewImpl.h:

        (WebViewImpl):

        * tests/WebViewTest.cpp:

        * tests/data/longpress_selection.html: Added.

2012-09-29  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: NMI make String* instrumentation non intrusive

Source/WebKit/chromium/src/WebViewImpl.cpp

@@bool WebViewImpl::handleGestureEvent(const WebGestureEvent& event)

            eventSwallowed = true;

            break;

        }

#if OS(ANDROID)

        if (selectNonLinkWordAroundWindowPoint(WebPoint(event.x, event.y))) {

            eventSwallowed = true;

            break;

        }

#endif

        m_page->contextMenuController()->clearContextMenu();

        m_contextMenuAllowed = true;

@@bool WebViewImpl::detectContentOnTouch(const WebPoint& position, WebInputEvent::

    return true;

}

bool WebViewImpl::selectNonLinkWordAroundWindowPoint(const WebPoint& windowPoint)

{

    Frame* focusedFrame = page()->focusController()->focusedOrMainFrame();

    IntPoint point = focusedFrame->view()->windowToContents(windowPoint);

    HitTestRequest request(HitTestRequest::Active);

    HitTestResult result(point);

    focusedFrame->document()->renderView()->layer()->hitTest(request, result);

    Node* node = result.innerNonSharedNode();

    if (!node)

        return false;

    FrameSelection* fs = focusedFrame->selection();

    if (node->renderer() && !fs->contains(point) && (node->isContentEditable() || node->isTextNode()) && !result.isLiveLink()

        && node->dispatchEvent(Event::create(eventNames().selectstartEvent, true, true))) {

        VisiblePosition pos(node->renderer()->positionForPoint(result.localPoint()));

        WebFrameImpl::selectWordAroundPosition(focusedFrame, pos);

        if (fs->isRange())

            return true;

    }

    return false;

}

void WebViewImpl::setVisibilityState(WebPageVisibilityState visibilityState,

                                     bool isInitialState) {

    if (!page())

Source/WebKit/chromium/src/WebViewImpl.h

@@public:

    void mouseDoubleClick(const WebMouseEvent&);

    bool detectContentOnTouch(const WebPoint&, WebInputEvent::Type);

396 bool selectNonLinkWordAroundWindowPoint(const WebPoint&);

    void startPageScaleAnimation(const WebCore::IntPoint& targetPosition, bool useAnchor, float newScale, double durationInSeconds);

    void numberOfWheelEventHandlersChanged(unsigned);

Source/WebKit/chromium/tests/WebViewTest.cpp

@@TEST_F(WebViewTest, ClientTapHandling)

    webView->close();

}

#if OS(ANDROID)

TEST_F(WebViewTest, LongPressSelection)

{

    URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(m_baseURL.c_str()), WebString::fromUTF8("longpress_selection.html"));

    WebView* webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "longpress_selection.html", true);

    webView->resize(WebSize(500, 300));

    webView->layout();

    webkit_support::RunAllPendingMessages();

    WebString target = WebString::fromUTF8("target");

    WebString onselectstartfalse = WebString::fromUTF8("onselectstartfalse");

    WebFrameImpl* frame = static_cast<WebFrameImpl*>(webView->mainFrame());

    EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureLongPress, onselectstartfalse));

    EXPECT_EQ("", std::string(frame->selectionAsText().utf8().data()));

    EXPECT_TRUE(tapElementById(webView, WebInputEvent::GestureLongPress, target));

    EXPECT_EQ("testword", std::string(frame->selectionAsText().utf8().data()));

    webView->close();

}

#endif

650672}

Source/WebKit/chromium/tests/data/longpress_selection.html

<!DOCTYPE html>

<html>

<head>

<style>

span {

    font-size: 300%;

}

</style>

</head>

<body>

Hello this is some text for testing. Here is a

<span id="target">

testword

</span>

that we should be able to select by longpressing.

To test onselectstart, here is

<span id="onselectstartfalse" onselectstart="return false;">

anotherbitoftext

</span>

that we should not be able to select.

</body>

</html>