ChangeLog

2012-06-26  Arpita Bahuguna  <arpitabahuguna@gmail.com>

        Change RenderTable sections' iterations for removing anti-patterns and using helper functions.

        https://bugs.webkit.org/show_bug.cgi?id=89751

        Reviewed by NOBODY (OOPS!).

        Removing anti-pattern wherever possible from RenderTable code. Also, modifying

        RenderTable sections' iterations to use helper functions.

        No new tests required for this change.

        * rendering/RenderTable.cpp:

        (WebCore::RenderTable::addOverflowFromChildren):

        (WebCore::RenderTable::setCellLogicalWidths):

        (WebCore::RenderTable::splitColumn):

        (WebCore::RenderTable::outerBorderStart):

        (WebCore::RenderTable::outerBorderEnd):

        Removed anti-patterns involving iterations over RenderObjects.

        (WebCore::RenderTable::outerBorderAfter):

        Modified RenderTable sections' iteration to use helper functions.

2012-06-26  Taiju Tsuiki  <tzik@chromium.org>

        Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem

121252

Source/WebCore/rendering/RenderTable.cpp

@@void RenderTable::addOverflowFromChildre

        addOverflowFromChild(m_captions[i]);

    // Add overflow from our sections.

    for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {

        if (child->isTableSection()) {

            RenderTableSection* section = toRenderTableSection(child);

            addOverflowFromChild(section);

        }

    }

520 for (RenderTableSection* section = topSection(); section; section = sectionBelow(section))

521 addOverflowFromChild(section);

}

void RenderTable::setCellLogicalWidths()

{

    for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {

        if (child->isTableSection())

            toRenderTableSection(child)->setCellLogicalWidths();

    }

526 for (RenderTableSection* section = topSection(); section; section = sectionBelow(section))

527 section->setCellLogicalWidths();

}

void RenderTable::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)

@@void RenderTable::splitColumn(unsigned p

    // Propagate the change in our columns representation to the sections that don't need

    // cell recalc. If they do, they will be synced up directly with m_columns later.

    for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {

        if (!child->isTableSection())

            continue;

        RenderTableSection* section = toRenderTableSection(child);

683 for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {

        if (section->needsCellRecalc())

            continue;

@@int RenderTable::outerBorderAfter() cons

    if (!collapseBorders())

        return 0;

    int borderWidth = 0;

    RenderTableSection* bottomSection;

    if (m_foot)

        bottomSection = m_foot;

    else {

        RenderObject* child;

        for (child = lastChild(); child && !child->isTableSection(); child = child->previousSibling()) { }

        bottomSection = child ? toRenderTableSection(child) : 0;

    }

    if (bottomSection) {

        borderWidth = bottomSection->outerBorderAfter();

    if (RenderTableSection* section = bottomSection()) {

        borderWidth = section->outerBorderAfter();

1009992 if (borderWidth < 0)

1010 return 0; // Overridden by hidden

993 return 0; // Overridden by hidden

    }

    const BorderValue& tb = style()->borderAfter();

    if (tb.style() == BHIDDEN)

@@int RenderTable::outerBorderStart() cons

        borderWidth = (tb.width() + (style()->isLeftToRightDirection() ? 0 : 1)) / 2;

    bool allHidden = true;

    for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {

        if (!child->isTableSection())

            continue;

        int sw = toRenderTableSection(child)->outerBorderStart();

1017 for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {

1018 int sw = section->outerBorderStart();

        if (sw < 0)

            continue;

        allHidden = false;

@@int RenderTable::outerBorderEnd() const

        borderWidth = (tb.width() + (style()->isLeftToRightDirection() ? 1 : 0)) / 2;

    bool allHidden = true;

    for (RenderObject* child = firstChild(); child; child = child->nextSibling()) {

        if (!child->isTableSection())

            continue;

        int sw = toRenderTableSection(child)->outerBorderEnd();

1044 for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {

1045 int sw = section->outerBorderEnd();

        if (sw < 0)

            continue;

        allHidden = false;

121252