ChangeLog

2012-06-13  Christopher Cameron  <ccameron@chromium.org>

        [chromium] webkit-backface-visibility doesn't work with video

        https://bugs.webkit.org/show_bug.cgi?id=88908

        When determining a contents layer's backface culling, use the parent

        layer's transform and backface-visibility properties. Track which

        layers need this special treatment with useParentBackfaceVisibility

        and setUseParentBackfaceVisibility functions in WebCore::LayerChromium,

        WebKit::WebLayer, and WebCore::CCLayerImpl.

        Reviewed by NOBODY (OOPS!).

        * chromium/public/WebLayer.h:

            (WebLayer):

                Add an accessor to specify that a layer should use its parent's

                backface culling behavior.

2012-06-11  James Robinson  <jamesr@chromium.org>

        [chromium] Port DrawingBufferChromium from TextureLayerChromium over to WebExternalTextureLayer

Source/WebCore/ChangeLog

2012-06-13  Christopher Cameron  <ccameron@chromium.org>

        [chromium] webkit-backface-visibility doesn't work with video

        https://bugs.webkit.org/show_bug.cgi?id=88908

        When determining a contents layer's backface culling, use the parent

        layer's transform and backface-visibility properties. Track which

        layers need this special treatment with useParentBackfaceVisibility

        and setUseParentBackfaceVisibility functions in WebCore::LayerChromium,

        WebKit::WebLayer, and WebCore::CCLayerImpl.

        Reviewed by NOBODY (OOPS!).

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:

        (WebCore::GraphicsLayerChromium::setupContentsLayer):

            When a contents layer is added, tag it as inheriting its backface

            culling from its parent.

        * platform/graphics/chromium/LayerChromium.cpp:

            (WebCore::LayerChromium::LayerChromium):

                Initialize new m_useParentBackfaceVisibility member variable.

            (WebCore::LayerChromium::pushPropertiesTo):

                Propagate m_useParentBackfaceVisibility to CCLayerImpl.

        * platform/graphics/chromium/LayerChromium.h:

            (WebCore::LayerChromium::setUseParentBackfaceVisibility):

            (WebCore::LayerChromium::useParentBackfaceVisibility):

            (LayerChromium):

                Add m_useParentBackfaceVisibility member variable and modify

                and query accessors.

        * platform/graphics/chromium/cc/CCLayerImpl.cpp:

            (WebCore::CCLayerImpl::CCLayerImpl):

                Initialize new m_useParentBackfaceVisibility member variable.

        * platform/graphics/chromium/cc/CCLayerImpl.h:

            (WebCore::CCLayerImpl::setUseParentBackfaceVisibility):

            (WebCore::CCLayerImpl::useParentBackfaceVisibility):

            (CCLayerImpl):

                Add m_useParentBackfaceVisibility member variable and modify

                and query accessors.

        * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

            (WebCore::layerShouldBeSkipped):

                When examining a layer, if the layer has 

                useParentBackfaceVisibility set then use the layer's parent

                layer to determine backface culling.

2012-06-12  Sami Kyostila  <skyostil@chromium.org>

        [chromium] Don't crash in CCLayerIterator if the root layer doesn't have a render surface

Source/WebKit/chromium/ChangeLog

2012-06-13  Christopher Cameron  <ccameron@chromium.org>

        [chromium] webkit-backface-visibility doesn't work with video

        https://bugs.webkit.org/show_bug.cgi?id=88908

        When determining a contents layer's backface culling, use the parent

        layer's transform and backface-visibility properties. Track which

        layers need this special treatment with useParentBackfaceVisibility

        and setUseParentBackfaceVisibility functions in WebCore::LayerChromium,

        WebKit::WebLayer, and WebCore::CCLayerImpl.

        Reviewed by NOBODY (OOPS!).

        * src/WebLayer.cpp:

            (WebKit::WebLayer::setUseParentBackfaceVisibility):

                Add an accessor to specify that a layer should use its parent's

                backface culling behavior.

2012-06-12  Adrienne Walker  <enne@google.com>

        [chromium] Fix incorrect LayerChromium scroll position for RTL overflow pages

Source/Platform/chromium/public/WebLayer.h

@@public:

    WEBKIT_EXPORT bool drawsContent() const;

    WEBKIT_EXPORT void setPreserves3D(bool);

    // Set whether this layer is a content layer (e.g, canvas, plugin, WebGL, or video)

    WEBKIT_EXPORT void setUseParentBackfaceVisibility(bool);

    WEBKIT_EXPORT void setBackgroundColor(WebColor);

    // Clear the filters in use by passing in a newly instantiated

Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp

@@void GraphicsLayerChromium::setupContentsLayer(LayerChromium* contentsLayer)

        return;

    if (!m_contentsLayer.isNull()) {

835 m_contentsLayer.setUseParentBackfaceVisibility(false);

        m_contentsLayer.removeFromParent();

        m_contentsLayer.reset();

    }

@@void GraphicsLayerChromium::setupContentsLayer(LayerChromium* contentsLayer)

        m_contentsLayer = WebLayer(contentsLayer);

        m_contentsLayer.setAnchorPoint(FloatPoint(0, 0));

844 m_contentsLayer.setUseParentBackfaceVisibility(true);

        // It is necessary to call setDrawsContent as soon as we receive the new contentsLayer, for

        // the correctness of early exit conditions in setDrawsContent() and setContentsVisible().

Source/WebCore/platform/graphics/chromium/LayerChromium.cpp

@@LayerChromium::LayerChromium()

    , m_usesLayerClipping(false)

    , m_isNonCompositedContent(false)

    , m_preserves3D(false)

85 , m_useParentBackfaceVisibility(false)

    , m_alwaysReserveTextures(false)

    , m_drawCheckerboardForMissingTiles(false)

    , m_forceRenderSurface(false)

@@void LayerChromium::pushPropertiesTo(CCLayerImpl* layer)

    layer->setIsContainerForFixedPositionLayers(m_isContainerForFixedPositionLayers);

    layer->setFixedToContainerLayerVisibleRect(m_fixedToContainerLayerVisibleRect);

    layer->setPreserves3D(preserves3D());

516 layer->setUseParentBackfaceVisibility(m_useParentBackfaceVisibility);

    layer->setScrollPosition(m_scrollPosition);

    layer->setSublayerTransform(m_sublayerTransform);

    if (!transformIsAnimating())

Source/WebCore/platform/graphics/chromium/LayerChromium.h

@@public:

    void setPreserves3D(bool preserve3D) { m_preserves3D = preserve3D; }

    bool preserves3D() const { return m_preserves3D; }

    void setUseParentBackfaceVisibility(bool useParentBackfaceVisibility) { m_useParentBackfaceVisibility = useParentBackfaceVisibility; }

    bool useParentBackfaceVisibility() const { return m_useParentBackfaceVisibility; }

    void setUsesLayerClipping(bool usesLayerClipping) { m_usesLayerClipping = usesLayerClipping; }

    bool usesLayerClipping() const { return m_usesLayerClipping; }

@@private:

    bool m_usesLayerClipping;

    bool m_isNonCompositedContent;

    bool m_preserves3D;

355 bool m_useParentBackfaceVisibility;

    bool m_alwaysReserveTextures;

    bool m_drawCheckerboardForMissingTiles;

    bool m_forceRenderSurface;

Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp

@@CCLayerImpl::CCLayerImpl(int id)

    , m_opaque(false)

    , m_opacity(1.0)

    , m_preserves3D(false)

61 , m_useParentBackfaceVisibility(false)

    , m_drawCheckerboardForMissingTiles(false)

    , m_usesLayerClipping(false)

    , m_isNonCompositedContent(false)

Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h

@@public:

    void setPreserves3D(bool);

    bool preserves3D() const { return m_preserves3D; }

    void setUseParentBackfaceVisibility(bool useParentBackfaceVisibility) { m_useParentBackfaceVisibility = useParentBackfaceVisibility; }

    bool useParentBackfaceVisibility() const { return m_useParentBackfaceVisibility; }

    void setUsesLayerClipping(bool usesLayerClipping) { m_usesLayerClipping = usesLayerClipping; }

    bool usesLayerClipping() const { return m_usesLayerClipping; }

@@private:

    float m_opacity;

    FloatPoint m_position;

    bool m_preserves3D;

326 bool m_useParentBackfaceVisibility;

    bool m_drawCheckerboardForMissingTiles;

    WebKit::WebTransformationMatrix m_sublayerTransform;

    WebKit::WebTransformationMatrix m_transform;

Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp

@@static bool layerShouldBeSkipped(LayerType* layer)

    if (!layer->drawsContent() || layer->bounds().isEmpty())

        return true;

    // If this is a contents layer, then we should evaluate double-sidedness based

    // on its parent's properties.

    if (layer->useParentBackfaceVisibility()) {

        ASSERT(layer->parent());

        layer = layer->parent();

    }

    // The layer should not be drawn if (1) it is not double-sided and (2) the back of the layer is known to be facing the screen.

    if (!layer->doubleSided() && transformToScreenIsKnown(layer) && isLayerBackFaceVisible(layer))

        return true;

Source/WebKit/chromium/src/WebLayer.cpp

@@void WebLayer::setPreserves3D(bool preserve3D)

    m_private->setPreserves3D(preserve3D);

}

void WebLayer::setUseParentBackfaceVisibility(bool useParentBackfaceVisibility)

{

    m_private->setUseParentBackfaceVisibility(useParentBackfaceVisibility);

}

void WebLayer::setBackgroundColor(WebColor color)

{

    m_private->setBackgroundColor(color);