ChangeLog

2012-03-21  Rafael Weinstein  <rafaelw@chromium.org>

        [MutationObservers] attributeFilter should be case sensitive at all times

        https://bugs.webkit.org/show_bug.cgi?id=81822

        Reviewed by NOBODY (OOPS!).

        This removes the behavior in MutationObserverRegistration which treats

        attributeFilter as case insensitive for HTML elements in HTML documents.

        Relevant tests have been updated.

        * dom/MutationObserverRegistration.cpp:

        (WebCore::MutationObserverRegistration::resetObservation):

        (WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):

        * dom/MutationObserverRegistration.h:

        (MutationObserverRegistration):

2012-03-21  Zeno Albisser  <zeno@webkit.org>

        [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.

Source/WebCore/dom/MutationObserverRegistration.cpp

@@void MutationObserverRegistration::resetObservation(MutationObserverOptions opti

    clearTransientRegistrations();

    m_options = options;

    m_attributeFilter = attributeFilter;

66 m_caseInsensitiveAttributeFilter.clear();

}

void MutationObserverRegistration::observedSubtreeNodeWillDetach(PassRefPtr<Node> node)

@@bool MutationObserverRegistration::shouldReceiveMutationFrom(Node* node, WebKitM

    if (type != WebKitMutationObserver::Attributes || !(m_options & WebKitMutationObserver::AttributeFilter))

        return true;

    if (m_attributeFilter.contains(attributeName))

        return true;

    if (node->document()->isHTMLDocument() && node->isHTMLElement())

        return caseInsensitiveAttributeFilter().contains(attributeName);

    return false;

}

const HashSet<AtomicString>& MutationObserverRegistration::caseInsensitiveAttributeFilter()

{

    if (m_caseInsensitiveAttributeFilter)

        return *m_caseInsensitiveAttributeFilter;

    m_caseInsensitiveAttributeFilter = adoptPtr(new HashSet<AtomicString>());

    for (HashSet<AtomicString>::const_iterator iter = m_attributeFilter.begin(); iter != m_attributeFilter.end(); ++iter) {

        AtomicString attributeNameLower = iter->lower();

        if ((*iter) != attributeNameLower)

             m_caseInsensitiveAttributeFilter->add(attributeNameLower);

    }

    return *m_caseInsensitiveAttributeFilter;

117 return (m_attributeFilter.contains(attributeName));

}

} // namespace WebCore

Source/WebCore/dom/MutationObserverRegistration.h

@@private:

    MutationObserverOptions m_options;

    HashSet<AtomicString> m_attributeFilter;

75 OwnPtr<HashSet<AtomicString> > m_caseInsensitiveAttributeFilter;

};

} // namespace WebCore

LayoutTests/ChangeLog

2012-03-21  Rafael Weinstein  <rafaelw@chromium.org>

        [MutationObservers] attributeFilter should be case sensitive at all times

        https://bugs.webkit.org/show_bug.cgi?id=81822

        Reviewed by NOBODY (OOPS!).

        * fast/mutation/observe-attributes-expected.txt:

        * fast/mutation/observe-attributes.html:

2012-03-21  Mark Hahnenberg  <mhahnenberg@apple.com>

        Checking in updated test expectations

LayoutTests/fast/mutation/observe-attributes-expected.txt

@@PASS mutations[2].type is "attributes"

PASS mutations[2].attributeName is "id"

PASS mutations[2].oldValue is "bar"

Testing that attributeFilter works as expected and ignores case with HTML elements.

...only foo, bar & boom should be received.

PASS mutations.length is 3

Testing that attributeFilter works as expected and observes case with HTML elements.

...only foo and bar should be received.

PASS mutations.length is 2

PASS mutations[0].type is "attributes"

PASS mutations[0].attributeName is "foo"

PASS mutations[0].attributeNamespace is null

PASS mutations[1].type is "attributes"

PASS mutations[1].attributeName is "bar"

PASS mutations[1].attributeNamespace is null

PASS mutations[2].type is "attributes"

PASS mutations[2].attributeName is "boom"

PASS mutations[2].attributeNamespace is null

Testing the behavior of attributeFilter when the same observer observes at multiple nodes in a subtree with different filter options.

...only foo, bar & bat should be received.

LayoutTests/fast/mutation/observe-attributes.html

@@function testAttributeFilter() {

    var observer;

    function start() {

454 debug('Testing that attributeFilter works as expected and ~~ign~~ores case with HTML elements.');

454 debug('Testing that attributeFilter works as expected and observes case with HTML elements.');

        mutations = null;

        observer = new WebKitMutationObserver(function(m) {

@@function testAttributeFilter() {

    }

    function finish() {

472 debug('...only foo, bar ~~& boom~~ should be received.');

472 debug('...only foo and bar should be received.');

473473

474 shouldBe('mutations.length', '3');

474 shouldBe('mutations.length', '2');

        shouldBe('mutations[0].type', '"attributes"');

        shouldBe('mutations[0].attributeName', '"foo"');

        shouldBe('mutations[0].attributeNamespace', 'null');

        shouldBe('mutations[1].type', '"attributes"');

        shouldBe('mutations[1].attributeName', '"bar"');

        shouldBe('mutations[1].attributeNamespace', 'null');

        shouldBe('mutations[2].type', '"attributes"');

        shouldBe('mutations[2].attributeName', '"boom"');

        shouldBe('mutations[2].attributeNamespace', 'null');

        observer.disconnect();

        debug('');

        runNextTest();