ChangeLog

2011-11-14  Rakesh KN  <rakesh.kn@motorola.com>

        Need support for dirname attribute

        https://bugs.webkit.org/show_bug.cgi?id=65542

        Reviewed by NOBODY (OOPS!).

        Implemented 'dirname' form attribute.

        Tests: fast/forms/form-dirname-attribute.html

               fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html

               fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html

               fast/forms/submit-form-with-dirname-attribute.html

        * html/HTMLAttributeNames.in:

        Added "dirname" attribute.

        * html/HTMLInputElement.idl:

        Add "dirName" property to HTMLInputElement interface.

        * html/HTMLTextAreaElement.cpp:

        (WebCore::HTMLTextAreaElement::appendFormData):

        Append dirname form data.

        * html/HTMLTextAreaElement.idl:

        Add "dirName" property to HTMLTextAreaElement interface.

        * html/HTMLTextFormControlElement.cpp:

        (WebCore::parentHTMLElement):

        Helper function which returns only HTML parent element.

        (WebCore::HTMLTextFormControlElement::directionForFormData):

        Helper function for finding directionality of the Element.

        * html/HTMLTextFormControlElement.h:

        Helper function for finding directionality of the Element.

        * html/TextFieldInputType.cpp:

        (WebCore::TextFieldInputType::appendFormData):

        Append dirname form data.

        * html/TextFieldInputType.h:

        Append dirname form data.

2011-11-14  Rakesh KN  <rakesh.kn@motorola.com>

        Cannot select multiple options by mouse dragging in <select multiple="multiple" size="7"> list

100112

Source/WebCore/html/HTMLAttributeNames.in

@@default

defer

dir

direction

93dirname

disabled

download

draggable

99824

Source/WebCore/html/HTMLInputElement.idl

@@module html {

    interface HTMLInputElement : HTMLElement {

        attribute [ConvertNullToNullString] DOMString defaultValue;

        attribute [Reflect=checked] boolean defaultChecked;

26 attribute [Reflect] DOMString dirName;

        readonly attribute HTMLFormElement form;

        attribute [Reflect, URL] DOMString formAction;

        attribute [ConvertNullToNullString] DOMString formEnctype;

99824

Source/WebCore/html/HTMLTextAreaElement.cpp

@@bool HTMLTextAreaElement::appendFormData

    const String& text = (m_wrap == HardWrap) ? valueWithHardLineBreaks() : value();

    encoding.appendData(name(), text);

176 return true;

    const AtomicString& dirnameAttrValue = fastGetAttribute(dirnameAttr);

    if (!dirnameAttrValue.isNull())

        encoding.appendData(dirnameAttrValue, directionForFormData());

    return true;

}

void HTMLTextAreaElement::reset()

99824

Source/WebCore/html/HTMLTextAreaElement.idl

@@module html {

        readonly attribute ValidityState validity;

        attribute [Reflect] DOMString accessKey;

        attribute long cols;

30 attribute [Reflect] DOMString dirName;

        attribute [Reflect] boolean disabled;

        attribute [Reflect] boolean autofocus;

        attribute long maxLength setter raises(DOMException);

99824

Source/WebCore/html/HTMLTextFormControlElement.cpp

@@HTMLTextFormControlElement* enclosingTex

    return ancestor != container ? toTextFormControl(ancestor) : 0;

}

static const Element* parentHTMLElement(const Element* element)

{

    while (element) {

        element = element->parentElement();

        if (element && element->isHTMLElement())

            return element;

    }

    return 0;

}

String HTMLTextFormControlElement::directionForFormData() const

{

    for (const Element* element = this; element; element = parentHTMLElement(element)) {

        const AtomicString& dirAttributeValue = element->fastGetAttribute(dirAttr);

        if (dirAttributeValue.isNull())

            continue;

        if (equalIgnoringCase(dirAttributeValue, "rtl") || equalIgnoringCase(dirAttributeValue, "ltr"))

            return dirAttributeValue;

        if (equalIgnoringCase(dirAttributeValue, "auto")) {

            bool isAuto;

            TextDirection textDirection = static_cast<const HTMLElement*>(element)->directionalityIfhasDirAutoAttribute(isAuto);

            return textDirection == RTL ? "rtl" : "ltr";

        }

    }

    return "ltr";

}

573603} // namespace Webcore

99824

Source/WebCore/html/HTMLTextFormControlElement.h

@@public:

    void setInnerTextValue(const String&);

    String innerTextValue() const;

82 String directionForFormData() const;

83

protected:

    HTMLTextFormControlElement(const QualifiedName&, Document*, HTMLFormElement*);

    virtual void updatePlaceholderText() = 0;

99824

Source/WebCore/html/TextFieldInputType.cpp

#include "TextFieldInputType.h"

#include "BeforeTextInsertedEvent.h"

36#include "FormDataList.h"

3637#include "Frame.h"

3738#include "HTMLInputElement.h"

39#include "HTMLNames.h"

#include "KeyboardEvent.h"

#include "Page.h"

#include "RenderLayer.h"

namespace WebCore {

54using namespace HTMLNames;

55

TextFieldInputType::TextFieldInputType(HTMLInputElement* element)

    : InputType(element)

{

@@void TextFieldInputType::updatePlacehold

    ASSERT(!ec);

}

bool TextFieldInputType::appendFormData(FormDataList& list, bool multipart) const

{

    InputType::appendFormData(list, multipart);

    const AtomicString& dirnameAttrValue = element()->fastGetAttribute(dirnameAttr);

    if (!dirnameAttrValue.isNull())

        list.appendData(dirnameAttrValue, element()->directionForFormData());

    return true;

}

367380} // namespace WebCore

99824

Source/WebCore/html/TextFieldInputType.h

namespace WebCore {

38class FormDataList;

class SpinButtonElement;

// The class represents types of which UI contain text fields.

@@private:

    virtual bool shouldRespectListAttribute();

    virtual HTMLElement* placeholderElement() const;

    virtual void updatePlaceholderText();

81 virtual bool appendFormData(FormDataList&, bool multipart) const;

    RefPtr<HTMLElement> m_container;

    RefPtr<HTMLElement> m_innerBlock;

99824

LayoutTests/ChangeLog

2011-11-14  Rakesh KN  <rakesh.kn@motorola.com>

        Need support for dirname attribute

        https://bugs.webkit.org/show_bug.cgi?id=65542

        Reviewed by NOBODY (OOPS!).

        Implemented 'dirname' form attribute.

        * fast/forms/form-dirname-attribute-expected.txt: Added.

        * fast/forms/form-dirname-attribute.html: Added.

        * fast/forms/submit-form-with-dirname-attribute-expected.txt: Added.

        * fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt: Added.

        * fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html: Added.

        * fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt: Added.

        * fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html: Added.

        * fast/forms/submit-form-with-dirname-attribute.html: Added.

2011-11-14  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>

        [Qt] Unreviewed gardening after r100050

100112

LayoutTests/fast/forms/form-dirname-attribute-expected.txt

"dirname" attribute

PASS input.dirName is "Hello"

PASS textArea.dirName is "Hello"

PASS successfullyParsed is true

TEST COMPLETE

0

LayoutTests/fast/forms/form-dirname-attribute.html

<!DOCTYPE html>

<html>

<head>

<meta charset="utf-8">

<link rel="stylesheet" href="../js/resources/js-test-style.css">

<script src="../js/resources/js-test-pre.js"> </script>

</head>

<body>

<p>"dirname" attribute</p>

<pre id="console"></pre>

<script>

var input = document.createElement('input');

input.setAttribute('dirName', "Hello");

shouldBeEqualToString('input.dirName', "Hello");

var textArea = document.createElement('textarea');

textArea.setAttribute('dirName', "Hello");

shouldBeEqualToString('textArea.dirName', "Hello");

successfullyParsed = true;

</script>

<script src="../js/resources/js-test-post.js"></script>

</body>

</html>

0

LayoutTests/fast/forms/submit-form-with-dirname-attribute-expected.txt

Test that when dirname attribute is specified then it is added in submission body.

Comment: 

WithRTLDir: 

WithLTRDir: 

WithInvalidDir: 

WithRTLValue: 

Post Comment

PASS document.location.search.indexOf("comment.dir=ltr") != -1 is true

PASS document.location.search.indexOf("txtareaRTL.dir=rtl") != -1 is true

PASS document.location.search.indexOf("txtareaLTR.dir=ltr") != -1 is true

PASS document.location.search.indexOf("txtareaInvalid.dir=ltr") != -1 is true

PASS document.location.search.indexOf("inputRTLvalue.dir=ltr") != -1 is true

PASS successfullyParsed is true

TEST COMPLETE

0

LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute-expected.txt

Test that when dirname attribute is specified then it is added in submission body.

Post Comment

Hello

PASS document.location.search.indexOf("rtlAncestor.dir=rtl") != -1 is true

PASS document.location.search.indexOf("autoAncestor.dir=ltr") != -1 is true

PASS successfullyParsed is true

TEST COMPLETE

0

LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html

<html>

<head>

<meta http-equiv="content-type" content="text/html; charset=UTF-8">

</head>

<script src="../js/resources/js-test-pre.js"> </script>

<script>

window.jsTestIsAsync = true;

function test() {

    document.forms.f.submit();

}

</script>

<body onload="test()">

<p>Test that when dirname attribute is specified then it is added in submission body.</p>

<div dir="auto">

    <form action="#action" method="GET" name="f">

        <div dir="rtl"> 

            <input type=text name="comment" dirname="rtlAncestor.dir" required>

        </div>

        <input type=text name="autoAncestor" dirname="autoAncestor.dir" value="שלום">

        <p><button name="mode" type=submit value="add">Post Comment</button></p>

    </form>

Hello

</div>

<div id="console"></div>

<div id="action">

<script>

if (document.location.href.match('\\?')) {

    shouldBeTrue('document.location.search.indexOf("rtlAncestor.dir=rtl") != -1');

    shouldBeTrue('document.location.search.indexOf("autoAncestor.dir=ltr") != -1');

    finishJSTest();

}

successfullyParsed = true;

</script>

</div>

<script src="../js/resources/js-test-post.js"></script>

</body>

</html>

0

LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor-expected.txt

Test that when dir attribute is specified for non html element, it is not considered for dirname attribute value in submission body.

Post Comment

PASS document.location.search.indexOf("nonHtmlAncestor.dir=ltr") != -1 is true

PASS successfullyParsed is true

TEST COMPLETE

0

LayoutTests/fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html

<html>

<head>

<meta http-equiv="content-type" content="text/html; charset=UTF-8">

</head>

<script src="../js/resources/js-test-pre.js"> </script>

<script>

window.jsTestIsAsync = true;

function test() {

    document.forms.f.submit();

}

</script>

<body onload="test()">

<p>Test that when dir attribute is specified for non html element, it is not considered for dirname attribute value in submission body.</p>

<svg xmlns="http://www.w3.org/2000/svg" width="100%" height="100%" viewBox="0 0 400 400" dir="rtl">

    <div>

    <form action="#action" method="GET" name="f">

        <input type=text name="nonHtmlAncestor" dirname="nonHtmlAncestor.dir"> 

        <p><button name="mode" type=submit value="add">Post Comment</button></p>

    </form>

    </div>

</svg>

<div id="console"></div>

<div id="action">

<script>

if (document.location.href.match('\\?')) {

    shouldBeTrue('document.location.search.indexOf("nonHtmlAncestor.dir=ltr") != -1');

    finishJSTest();

}

successfullyParsed = true;

</script>

</div>

<script src="../js/resources/js-test-post.js"></script>

</body>

</html>

0

LayoutTests/fast/forms/submit-form-with-dirname-attribute.html

<html>

<head>

<meta http-equiv="content-type" content="text/html; charset=UTF-8">

</head>

<script src="../js/resources/js-test-pre.js"> </script>

<script>

window.jsTestIsAsync = true;

function test() {

    document.forms.f.submit();

}

</script>

<body onload="test()">

<p>Test that when dirname attribute is specified then it is added in submission body.</p>

<form action="#action" name="f">

    <p><label>Comment: <input type=text name="comment" dirname="comment.dir" required></label></p>

    <p><label>WithRTLDir: <textarea name="txtarea" dir="rtl" dirname="txtareaRTL.dir"></textarea></label></p>

    <p><label>WithLTRDir: <textarea name="txtarea1" dir="ltr" dirname="txtareaLTR.dir"></textarea></label></p>

    <p><label>WithInvalidDir: <textarea name="txtarea2" dir="invalid" dirname="txtareaInvalid.dir"></textarea></label></p>

    <p><label>WithRTLValue: <input name="input" dirname="inputRTLvalue.dir" value="مرحبًا"></label></p>

    <p><button name="mode" type=submit value="add">Post Comment</button></p>

</form>

<div id="console"></div>

<div id="action">

<script>

if (document.location.href.match('\\?')) {

    shouldBeTrue('document.location.search.indexOf("comment.dir=ltr") != -1');

    shouldBeTrue('document.location.search.indexOf("txtareaRTL.dir=rtl") != -1');

    shouldBeTrue('document.location.search.indexOf("txtareaLTR.dir=ltr") != -1');

    shouldBeTrue('document.location.search.indexOf("txtareaInvalid.dir=ltr") != -1');

    shouldBeTrue('document.location.search.indexOf("inputRTLvalue.dir=ltr") != -1');

    finishJSTest();

}

successfullyParsed = true;

</script>

</div>

<script src="../js/resources/js-test-post.js"></script>

</body>

</html>

0