Source/WebCore/ChangeLog

 12011-10-10 Anna Cavender <annacc@chromium.org>
 2
 3 Making the extra arguments (i.e. ScriptExecutionContext and ExceptionCode)
 4 come first in custom JavaScript Constructors.
 5 https://bugs.webkit.org/show_bug.cgi?id=69799
 6
 7 Reviewed by NOBODY (OOPS!).
 8
 9 Tests:
 10 - fast/css/matrix-as-function-crash.html (for WebKitCSSMatrix)
 11 - http/tests/eventsource/* (for EventSource)
 12 - fast/filesystem/* (for Worker)
 13
 14
 15 * bindings/scripts/CodeGeneratorV8.pm:
 16 (GenerateConstructorCallback): changes order of the argument list
 17 * css/WebKitCSSMatrix.h:
 18 (WebCore::WebKitCSSMatrix::create): changing order of constructor params
 19 * page/EventSource.cpp:
 20 (WebCore::EventSource::create): changing order of constructor params
 21 * page/EventSource.h:
 22 * workers/Worker.cpp:
 23 (WebCore::Worker::create): changing order of constructor params
 24 * workers/Worker.h:
 25
1262011-10-10 Andreas Kling <kling@webkit.org>
227
328 Shrink RenderLayer and ScrollableArea.

Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@END
15601560 $index++;
15611561 }
15621562
1563  my $argumentString = join(", ", @argumentList, @extraArgumentList);
 1563 my $argumentString = join(", ", @extraArgumentList, @argumentList);
15641564 push(@implContent, "\n");
15651565 push(@implContent, " RefPtr<${implClassName}> obj = ${implClassName}::create(${argumentString});\n");
15661566

Source/WebCore/css/WebKitCSSMatrix.h

@@public:
3939 {
4040 return adoptRef(new WebKitCSSMatrix(m));
4141 }
42  static PassRefPtr<WebKitCSSMatrix> create(const String& s, ExceptionCode& ec)
 42 static PassRefPtr<WebKitCSSMatrix> create(ExceptionCode& ec, const String& s)
4343 {
4444 return adoptRef(new WebKitCSSMatrix(s, ec));
4545 }

Source/WebCore/page/EventSource.cpp

@@inline EventSource::EventSource(const KURL& url, ScriptExecutionContext* context
6969{
7070}
7171
72 PassRefPtr<EventSource> EventSource::create(const String& url, ScriptExecutionContext* context, ExceptionCode& ec)
 72PassRefPtr<EventSource> EventSource::create(ScriptExecutionContext* context, ExceptionCode& ec, const String& url)
7373{
7474 if (url.isEmpty()) {
7575 ec = SYNTAX_ERR;

Source/WebCore/page/EventSource.h

@@namespace WebCore {
5151 class EventSource : public RefCounted<EventSource>, public EventTarget, private ThreadableLoaderClient, public ActiveDOMObject {
5252 WTF_MAKE_FAST_ALLOCATED;
5353 public:
54  static PassRefPtr<EventSource> create(const String& url, ScriptExecutionContext*, ExceptionCode&);
 54 static PassRefPtr<EventSource> create(ScriptExecutionContext*, ExceptionCode&, const String& url);
5555 virtual ~EventSource();
5656
5757 static const unsigned long long defaultReconnectDelay;

Source/WebCore/workers/Worker.cpp

@@inline Worker::Worker(ScriptExecutionContext* context)
5656{
5757}
5858
59 PassRefPtr<Worker> Worker::create(const String& url, ScriptExecutionContext* context, ExceptionCode& ec)
 59PassRefPtr<Worker> Worker::create(ScriptExecutionContext* context, ExceptionCode& ec, const String& url)
6060{
6161 RefPtr<Worker> worker = adoptRef(new Worker(context));
6262

Source/WebCore/workers/Worker.h

@@namespace WebCore {
5151
5252 class Worker : public AbstractWorker, private WorkerScriptLoaderClient {
5353 public:
54  static PassRefPtr<Worker> create(const String& url, ScriptExecutionContext*, ExceptionCode&);
 54 static PassRefPtr<Worker> create(ScriptExecutionContext*, ExceptionCode&, const String& url);
5555 virtual ~Worker();
5656
5757 virtual Worker* toWorker() { return this; }