WebKitTools/ChangeLog

 12010-01-07 Eric Seidel <eric@webkit.org>
 2
 3 Reviewed by NOBODY (OOPS!).
 4
 5 Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
 6 https://bugs.webkit.org/show_bug.cgi?id=33290
 7
 8 Add the Chromium builders to our list of core builders and test that our regexps work.
 9 I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
 10
 11 * Scripts/webkitpy/buildbot.py:
 12 * Scripts/webkitpy/buildbot_unittest.py:
 13
1142010-01-06 Kinuko Yasuda <kinuko@chromium.org>
215
316 Reviewed by Eric Seidel.

WebKitTools/Scripts/webkitpy/buildbot.py

@@class BuildBot:
4444 self.buildbot_host = host
4545 self.buildbot_server_url = "http://%s/" % self.buildbot_host
4646
47  # If any of the Leopard build/test bots or the Windows builders are red we should not be landing patches.
48  # Other builders should be added to this list once they're known to be stable.
49  self.core_builder_names_regexps = [ 'Leopard', "Windows.*Build" ]
 47 # If any Leopard bot or the Windows or Chromium builder is red we should not be landing patches.
 48 # Other bots should be added to this list once they're known to be stable.
 49 # See https://bugs.webkit.org/show_bug.cgi?id=33296 and related bugs.
 50 self.core_builder_names_regexps = [ "Leopard", "Windows.*Build", "Chromium" ]
5051
5152 # If WebKit's buildbot has an XMLRPC interface we could use, we could do something more sophisticated here.
5253 # For now we just parse out the basics, enough to support basic questions like "is the tree green?"

WebKitTools/Scripts/webkitpy/buildbot_unittest.py

@@class BuildBotTest(unittest.TestCase):
110110 def test_builder_name_regexps(self):
111111 buildbot = BuildBot()
112112
 113 # For complete testing, this list should match the list of builders at build.webkit.org:
113114 example_builders = [
114  { 'name': u'Leopard Debug (Build)', },
115  { 'name': u'Leopard Debug (Tests)', },
 115 { 'name': u'Tiger Intel Release', },
 116 { 'name': u'Leopard Intel Release (Build)', },
 117 { 'name': u'Leopard Intel Release (Tests)', },
 118 { 'name': u'Leopard Intel Debug (Build)', },
 119 { 'name': u'Leopard Intel Debug (Tests)', },
 120 { 'name': u'SnowLeopard Intel Release (Build)', },
 121 { 'name': u'SnowLeopard Intel Release (Tests)', },
 122 { 'name': u'SnowLeopard Intel Leaks', },
116123 { 'name': u'Windows Release (Build)', },
 124 { 'name': u'Windows Release (Tests)', },
 125 { 'name': u'Windows Debug (Build)', },
117126 { 'name': u'Windows Debug (Tests)', },
118127 { 'name': u'Qt Linux Release', },
 128 { 'name': u'Gtk Linux Release', },
 129 { 'name': u'Gtk Linux 32-bit Debug', },
 130 { 'name': u'Gtk Linux 64-bit Debug', },
 131 { 'name': u'Chromium Linux Release', },
 132 { 'name': u'Chromium Mac Release', },
 133 { 'name': u'Chromium Win Release', },
119134 ]
120  name_regexps = [ 'Leopard', "Windows.*Build" ]
 135 name_regexps = [ "Leopard", "Windows.*Build", "Chromium" ]
121136 expected_builders = [
122  { 'name': u'Leopard Debug (Build)', },
123  { 'name': u'Leopard Debug (Tests)', },
 137 { 'name': u'Leopard Intel Release (Build)', },
 138 { 'name': u'Leopard Intel Release (Tests)', },
 139 { 'name': u'Leopard Intel Debug (Build)', },
 140 { 'name': u'Leopard Intel Debug (Tests)', },
124141 { 'name': u'Windows Release (Build)', },
 142 { 'name': u'Windows Debug (Build)', },
 143 { 'name': u'Chromium Linux Release', },
 144 { 'name': u'Chromium Mac Release', },
 145 { 'name': u'Chromium Win Release', },
125146 ]
126147
127148 # This test should probably be updated if the default regexp list changes