ChangeLog

2021-04-14  Carlos Garcia Campos  <cgarcia@igalia.com>

        [SOUP] Stop using ResourceResponse::setDeprecatedNetworkLoadMetrics

        https://bugs.webkit.org/show_bug.cgi?id=224541

        Reviewed by NOBODY (OOPS!).

        We are already providing the metrics via didCompleteWithError(). Also make sure we set fetchStart and use it

        instead of a member.

        * NetworkProcess/soup/NetworkDataTaskSoup.cpp:

        (WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup):

        (WebKit::NetworkDataTaskSoup::didSendRequest):

        (WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):

        (WebKit::NetworkDataTaskSoup::dispatchDidCompleteWithError):

        (WebKit::NetworkDataTaskSoup::continueHTTPRedirection):

        (WebKit::NetworkDataTaskSoup::networkEvent):

        (WebKit::NetworkDataTaskSoup::didStartRequest):

        (WebKit::NetworkDataTaskSoup::didRestart):

        * NetworkProcess/soup/NetworkDataTaskSoup.h:

2021-04-12  Adrian Perez de Castro  <aperez@igalia.com>

        [WPE][GTK] Use g_object_notify_by_pspec() whenever possible

Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp

@@NetworkDataTaskSoup::NetworkDataTaskSoup(NetworkSession& session, NetworkDataTas

    auto request = requestWithCredentials;

    if (request.url().protocolIsInHTTPFamily()) {

67 m_start~~Time~~ = MonotonicTime::now();

67 m_networkLoadMetrics.fetchStart = MonotonicTime::now().secondsSinceEpoch();

        auto url = request.url();

        if (m_storedCredentialsPolicy == StoredCredentialsPolicy::Use) {

            m_user = url.user();

@@void NetworkDataTaskSoup::didSendRequest(GRefPtr<GInputStream>&& inputStream)

    else

        m_inputStream = WTFMove(inputStream);

406 m_networkLoadMetrics.responseStart = MonotonicTime::now() - m_start~~Time~~;

406 m_networkLoadMetrics.responseStart = MonotonicTime::now().secondsSinceEpoch() - m_networkLoadMetrics.fetchStart;

    dispatchDidReceiveResponse();

}

@@void NetworkDataTaskSoup::dispatchDidReceiveResponse()

    timing->connectEnd = m_networkLoadMetrics.connectEnd;

    timing->requestStart = m_networkLoadMetrics.requestStart;

    timing->responseStart = m_networkLoadMetrics.responseStart;

423 // FIXME: Remove this once nobody depends on deprecatedNetworkLoadMetrics.

424 m_response.setDeprecatedNetworkLoadMetrics(WTFMove(timing));

    didReceiveResponse(ResourceResponse(m_response), NegotiatedLegacyTLS::No, [this, protectedThis = makeRef(*this)](PolicyAction policyAction) {

        if (m_state == State::Canceling || m_state == State::Completed) {

@@void NetworkDataTaskSoup::dispatchDidReceiveResponse()

void NetworkDataTaskSoup::dispatchDidCompleteWithError(const ResourceError& error)

{

457 m_networkLoadMetrics.responseEnd = MonotonicTime::now() - m_start~~Time~~;

455 m_networkLoadMetrics.responseEnd = MonotonicTime::now().secondsSinceEpoch() - m_networkLoadMetrics.fetchStart;

    m_networkLoadMetrics.markComplete();

    m_client->didCompleteWithError(error, m_networkLoadMetrics);

@@void NetworkDataTaskSoup::continueHTTPRedirection()

        auto request = newRequest;

        if (request.url().protocolIsInHTTPFamily()) {

            if (isCrossOrigin) {

826 m_startTime = MonotonicTime::now();

827824 m_networkLoadMetrics = { };

825 m_networkLoadMetrics.fetchStart = MonotonicTime::now().secondsSinceEpoch();

            }

            applyAuthenticationToRequest(request);

@@void NetworkDataTaskSoup::networkEventCallback(SoupMessage* soupMessage, GSocket

void NetworkDataTaskSoup::networkEvent(GSocketClientEvent event, GIOStream* stream)

{

1189 Seconds deltaTime = MonotonicTime::now() - m_start~~Time~~;

1187 Seconds deltaTime = MonotonicTime::now().secondsSinceEpoch() - m_networkLoadMetrics.fetchStart;

    switch (event) {

    case G_SOCKET_CLIENT_RESOLVING:

        m_networkLoadMetrics.domainLookupStart = deltaTime;

@@void NetworkDataTaskSoup::hstsEnforced(SoupMessage* soupMessage, NetworkDataTask

void NetworkDataTaskSoup::didStartRequest()

{

1280 m_networkLoadMetrics.requestStart = MonotonicTime::now() - m_start~~Time~~;

1278 m_networkLoadMetrics.requestStart = MonotonicTime::now().secondsSinceEpoch() - m_networkLoadMetrics.fetchStart;

}

void NetworkDataTaskSoup::restartedCallback(SoupMessage* soupMessage, NetworkDataTaskSoup* task)

@@void NetworkDataTaskSoup::restartedCallback(SoupMessage* soupMessage, NetworkDat

void NetworkDataTaskSoup::didRestart()

{

1296 m_startTime = MonotonicTime::now();

12971294 m_networkLoadMetrics = { };

1295 m_networkLoadMetrics.fetchStart = MonotonicTime::now().secondsSinceEpoch();

#if !USE(SOUP2)

    m_currentRequest.updateSoupMessageBody(m_soupMessage.get(), m_session->blobRegistry());

#endif

Source/WebKit/ChangeLog

Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp

Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.h