ChangeLog

2020-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK4] Add printing support

        https://bugs.webkit.org/show_bug.cgi?id=212320

        Reviewed by NOBODY (OOPS!).

        Add gtk_dialog_run() to GTK4.

        * platform/gtk/GtkVersioning.h:

        (gtk_dialog_run):

2020-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK4] Make inspector work

Source/WebCore/platform/gtk/GtkVersioning.h

@@gtk_native_dialog_run(GtkNativeDialog* dialog)

    return context.response;

}

static inline int

gtk_dialog_run(GtkDialog* dialog)

{

    struct RunDialogContext {

        GMainLoop *loop;

        int response;

    } context = { g_main_loop_new(nullptr, FALSE), 0 };

    gtk_widget_show(GTK_WIDGET(dialog));

    g_signal_connect(dialog, "response", G_CALLBACK(+[](GtkDialog*, int response, RunDialogContext* context) {

        context->response = response;

        g_main_loop_quit(context->loop);

    }), &context);

    g_main_loop_run(context.loop);

    g_main_loop_unref(context.loop);

    return context.response;

}

#else // USE(GTK4)

static inline void

Source/WebKit/ChangeLog

2020-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK4] Add printing support

        https://bugs.webkit.org/show_bug.cgi?id=212320

        Reviewed by NOBODY (OOPS!).

        Printing API hasn't changed, the only problem was that we were using gtk_dialog_run() and gdk threads deprecated API.

        * UIProcess/API/gtk/WebKitPrintOperation.cpp:

        (webkitPrintOperationRunDialog): Remove GTK4 ifdefs.

        * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

        (WebKit::WebPrintOperationGtk::print): Use g_idle_add_full() instead of gdk threads deprecated API.

2020-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK4] Wheel events are always handled by the main frame view

Source/WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp

@@static void notifySelectedPrinterCallback(GtkPrintUnixDialog* dialog, GParamSpec

static WebKitPrintOperationResponse webkitPrintOperationRunDialog(WebKitPrintOperation* printOperation, GtkWindow* parent)

{

#if USE(GTK4)

    return WEBKIT_PRINT_OPERATION_RESPONSE_CANCEL;

#else

    GtkPrintUnixDialog* printDialog = GTK_PRINT_UNIX_DIALOG(gtk_print_unix_dialog_new(0, parent));

    gtk_print_unix_dialog_set_manual_capabilities(printDialog, static_cast<GtkPrintCapabilities>(GTK_PRINT_CAPABILITY_NUMBER_UP

                                                                                                 | GTK_PRINT_CAPABILITY_NUMBER_UP_LAYOUT

@@static WebKitPrintOperationResponse webkitPrintOperationRunDialog(WebKitPrintOpe

    gtk_widget_destroy(GTK_WIDGET(printDialog));

    return returnValue;

302 #endif

}

#else

// TODO: We need to add an implementation for Windows.

Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp

@@void WebPrintOperationGtk::print(cairo_surface_t* surface, double xDPI, double y

    m_xDPI = xDPI;

    m_yDPI = yDPI;

    m_cairoContext = adoptRef(cairo_create(surface));

740 ~~#if !USE(GTK4)~~

740

    // Make sure the print pages idle has more priority than IPC messages comming from

    // the IO thread, so that the EndPrinting message is always handled once the print

    // operation has finished. See https://bugs.webkit.org/show_bug.cgi?id=122801.

    unsigned idlePriority = m_printMode == PrintInfo::PrintModeSync ? G_PRIORITY_DEFAULT - 10 : G_PRIORITY_DEFAULT_IDLE + 10;

    GMainLoop* mainLoop = data->mainLoop.get();

746 m_printPagesIdleId = g~~dk_threads_add~~_idle_full(idlePriority, printPagesIdle, data.release(), printPagesIdleDone);

746 m_printPagesIdleId = g_idle_add_full(idlePriority, printPagesIdle, data.release(), printPagesIdleDone);

    if (m_printMode == PrintInfo::PrintModeSync) {

        ASSERT(mainLoop);

        g_main_loop_run(mainLoop);

    }

751 #endif

}

}