Tools/ChangeLog

2019-01-31  Youenn Fablet  <youenn@apple.com>

        Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr

        https://bugs.webkit.org/show_bug.cgi?id=194106

        <rdar://problem/47676333>

        Reviewed by NOBODY (OOPS!).

        * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:

        (TestWebKitAPI::didFinishNavigation):

        (TestWebKitAPI::TEST):

        * TestWebKitAPI/Tests/WebKit/getUserMedia.html:

2019-01-31  Zalan Bujtas  <zalan@apple.com>

        [LFC] Margin before/after/start/end initial value is 0 and not auto.

Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp

@@TEST(WebKit, OnDeviceChangeCrash)

    EXPECT_TRUE(!didCrash);

}

static bool didReceiveMessage;

static void didFinishNavigation(WKPageRef, WKNavigationRef, WKTypeRef, const void*)

{

    didReceiveMessage = true;

}

TEST(WebKit, EnumerateDevicesCrash)

{

    auto context = adoptWK(WKContextCreateWithConfiguration(nullptr));

    WKRetainPtr<WKPageGroupRef> pageGroup(AdoptWK, WKPageGroupCreateWithIdentifier(Util::toWK("GetUserMedia").get()));

    WKPreferencesRef preferences = WKPageGroupGetPreferences(pageGroup.get());

    WKPreferencesSetMediaDevicesEnabled(preferences, true);

    WKPreferencesSetFileAccessFromFileURLsAllowed(preferences, true);

    WKPreferencesSetMediaCaptureRequiresSecureConnection(preferences, false);

    WKPreferencesSetMockCaptureDevicesEnabled(preferences, true);

    WKPageUIClientV6 uiClient;

    // We want uiClient.checkUserMediaPermissionForOrigin to be null.

    memset(&uiClient, 0, sizeof(uiClient));

    uiClient.base.version = 6;

    WKPageNavigationClientV3 loaderClient;

    memset(&loaderClient, 0, sizeof(loaderClient));

    loaderClient.base.version = 3;

    loaderClient.didFinishNavigation = didFinishNavigation;

    PlatformWebView webView(context.get(), pageGroup.get());

    WKPageSetPageUIClient(webView.page(), &uiClient.base);

    WKPageSetPageNavigationClient(webView.page(), &loaderClient.base);

    // Load a page doing enumerateDevices.

    didReceiveMessage = false;

    auto url = adoptWK(Util::createURLForResource("getUserMedia", "html"));

    WKPageLoadURL(webView.page(), url.get());

    Util::run(&didReceiveMessage);

}

} // namespace TestWebKitAPI

#endif // ENABLE(MEDIA_STREAM)

Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html

            let stream = null;

8 function promptForCapture()

8 async function promptForCapture()

99 {

                navigator.mediaDevices.getUserMedia({ audio: false, video: true })

                .then((s) => {

                      stream = s;

                      video.srcObject = stream;

                      console.log("Got user media");

                })

                .catch((error) => console.log(`Failed with error: ${error}`));

                try {

                    await navigator.mediaDevices.enumerateDevices();

                    const stream = await navigator.mediaDevices.getUserMedia({ audio: false, video: true })

                    video.srcObject = stream;

                    console.log("Got user media");

                } catch(error) {

                    console.log(`Failed with error: ${error}`);

                }

            }

            function stop(kind)