WebCore/ChangeLog

2009-06-01  Xiaomei Ji  <xji@chromium.org>

        Reviewed by NOBODY (OOPS!).

        Not auto-testable since it involves sending a keyboard event to

        the popup, which is not possible (eventSender sends the key

        events through webview, we want to go through the webwidget).

        This patch is one part of the fix for issue "keyboard selection in

        Hebrew select element does not work in Windows". The other part of the

        fix is in chromium's webkit/glue layer.

        https://bugs.webkit.org/show_bug.cgi?id=25899

        * manual-tests/keyboard_select_non_english.html: Added.

        * platform/chromium/PopupMenuChromium.cpp:

        (WebCore::isCharacterTypeEvent): Added. Check whether the event is a 

        character type event. "Char" in Windows or "KeyDown" in Mac is character

        type event.

        (WebCore::PopupListBox::typeAheadFind): Since m_lastCharTime is used to

        indicate whether user types multiple characters continuely as a search

        prefix or not, it should be only assigned when the event is character 

        type event.

2009-06-01  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric Seidel.

44338

WebCore/manual-tests/keyboard_select_non_english.html

<!DOCTYPE html>

<html>

<head>

<META HTTP-EQUIV="CONTENT-TYPE" CONTENT="text/html; charset=UTF-8">

<title>

Test select non English element

</title>

</head>

<body>

See bug:<a href="https://bugs.webkit.org/show_bug.cgi?id=25899">25899</a>.

<p>

Choose the correct input method. Open the select element then type the first 

letter of one of the elements. The search prefix should be the first non English

letter, not the value of the physical keyboard plus the native non English

letter. For example, set the input method as Hebrew, hit keyboard 'c', the

translated Hebrew character is 'ב'. The search prefix should be 'ב', not "cב".

And the right element should be selected.

<p>

Hebrew Select:

<select style="direction:rtl">

  <option>אאא</option>

  <option>בבב</option>

  <option>גגג</option>

  <option>דדדד מילה ערוכה מאוד, כדי שיהיה אפשר לראות יישור</option>

</select>

Russian Select: 

<select>

  <option>фисв</option>

  <option>уап</option>

  <option>ршол</option>

  <option>дьт</option>

</select>

</body>

</html>

0

WebCore/platform/chromium/PopupMenuChromium.cpp

@@static String stripLeadingWhiteSpace(con

    return string.substring(i, length - i);

}

bool isCharacterTypeEvent(const PlatformKeyboardEvent& event) {

    // Check whether the event is a character-typed event or not. 

    // In Windows, PlatformKeyboardEvent::Char (not RawKeyDown) type event

    // is considered as character type event. In Mac OS, KeyDown (not 

    // KeyUp) is considered as character type event.

#if PLATFORM(WIN_OS)

    if (event.type() == PlatformKeyboardEvent::Char)

        return true;

#else

    if (event.type() == PlatformKeyboardEvent::KeyDown)

        return true;

#endif

    return false;

}

// From HTMLSelectElement.cpp, with modifications

void PopupListBox::typeAheadFind(const PlatformKeyboardEvent& event)

{

    TimeStamp now = static_cast<TimeStamp>(currentTime() * 1000.0f);

    TimeStamp delta = now - m_lastCharTime;

695 m_lastCharTime = now;

    // Reset the time when user types in a character. The time gap between

    // last character and the current character is used to indicate whether

    // user typed in a string or just a character as the search prefix.

    if (isCharacterTypeEvent(event))

        m_lastCharTime = now;

    UChar c = event.windowsVirtualKeyCode();

43971