ChangeLog

2016-12-12  Ryosuke Niwa  <rniwa@webkit.org>

        :hover rule causes a single tap to not activate a slotted anchor element

        https://bugs.webkit.org/show_bug.cgi?id=165551

        Reviewed by NOBODY (OOPS!).

        Fixed a bug in ancestorRespondingToClickEvents that we were traversing the ancestor nodes without taking

        shadow roots and slots into account. This prevented tapping on a text node assigned to a slot inside

        an anchor element to activate the hyperlink on iOS.

        This bug was supposed to be fixed in r206605, and it was still broken on iOS due to the bug in

        ancestorRespondingToClickEvents. It is now tested by click-text-inside-linked-slot.html.

        Tests: fast/shadow-dom/click-on-slotted-anchor-with-hover.html

               fast/shadow-dom/click-text-inside-linked-slot.html

        * page/ios/FrameIOS.mm:

        (WebCore::ancestorRespondingToClickEvents):

        (WebCore::Frame::qualifyingNodeAtViewportLocation):

2016-12-12  Darin Adler  <darin@apple.com>

        Remove bindings generation support for legacy WebCore::Dictionary

209752

Source/WebCore/page/ios/FrameIOS.mm

#import "RenderTextControl.h"

#import "RenderView.h"

#import "RenderedDocumentMarker.h"

62#import "ShadowRoot.h"

#import "TextBoundaries.h"

#import "TextIterator.h"

#import "VisiblePosition.h"

@@static Node* ancestorRespondingToClickEv

        *nodeBounds = IntRect();

    Node* pointerCursorNode = nullptr;

261 for (Node* node = hitTestResult.innerNode(); node && node != terminationNode; node = node->parentNode()) {

262 ASSERT(!node->isInShadowTree());

262 for (Node* node = hitTestResult.innerNode(); node && node != terminationNode; node = node->parentInComposedTree()) {

263 ASSERT(!node->isInShadowTree() || node->containingShadowRoot()->mode() != ShadowRootMode::UserAgent);

        // We only accept pointer nodes before reaching the body tag.

        if (node->hasTagName(HTMLNames::bodyTag)) {

@@Node* Frame::qualifyingNodeAtViewportLoc

        Node* failedNode = candidate;

        while (candidate && !candidate->isElementNode())

408 candidate = candidate->parentNode();

409 candidate = candidate->parentInComposedTree();

        if (candidate)

            failedNode = candidate;

209064

LayoutTests/ChangeLog

2016-12-12  Ryosuke Niwa  <rniwa@webkit.org>

        :hover rule causes a single tap to not activate a slotted anchor element

        https://bugs.webkit.org/show_bug.cgi?id=165551

        Reviewed by NOBODY (OOPS!).

        Added a test for tapping on an anchor element assigned to a slot, which has been fixed in r209065.

        Also added a new helper JS wrapepr, UIHelper, defined inside LayoutTests/resources/js-helper.js

        to provide an abstraction around EventSender and UIScriptController.

        Fixed click-text-inside-linked-slot.html on iOS using UIHelper.

        * fast/shadow-dom/click-on-slotted-anchor-with-hover-expected.txt: Added.

        * fast/shadow-dom/click-on-slotted-anchor-with-hover.html: Added.

        * fast/shadow-dom/click-text-inside-linked-slot.html:

        * platform/ios-simulator/fast/shadow-dom/click-text-inside-linked-slot-expected.txt: Added.

        * resources/ui-helper.js: Added.

        (window.UIHelper.isIOS):

        (window.UIHelper.activateAt.return.new.Promise):

        (window.UIHelper.activateAt):

        (window.UIHelper.wait):

        (window.UIHelper):

2016-12-12  Chris Dumez  <cdumez@apple.com>

        Add Document.onvisibilitychange event handler attribute

209750

LayoutTests/fast/shadow-dom/click-on-slotted-anchor-with-hover-expected.txt

Tests for tapping or clicking on an anchor element assigned to a slot with :hover rule.

Tapping on "Tap me" below exactly once should activate the hyperlink.

Tap me

PASS

nonexistent

LayoutTests/fast/shadow-dom/click-on-slotted-anchor-with-hover.html

<!DOCTYPE html>

<html>

<body>

<p>Tests for tapping or clicking on an anchor element assigned to a slot with :hover rule.<br>

Tapping on "Tap me" below exactly once should activate the hyperlink.</p>

<div id="host"><a href="#" onclick="activated();">Tap me</a></div>

<div id="result">FAIL</div>

<script src="../../resources/ui-helper.js"></script>

<script>

let shadowHost = document.getElementById('host');

shadowHost.attachShadow({mode: 'closed'}).innerHTML = '<slot></slot>';

function activated() {

    document.getElementById('result').textContent = 'PASS';

}

document.onclick = function () {

    document.getElementById('result').style.display = null;

}

if (window.testRunner) {

    testRunner.dumpAsText();

    UIHelper.wait(UIHelper.activateAt(shadowHost.offsetLeft + 5, shadowHost.offsetTop + 5));

} else

    document.getElementById('result').style.display = 'none';

</script>

</body>

</html>

nonexistent

LayoutTests/fast/shadow-dom/click-text-inside-linked-slot.html

<body>

<p>This tests clicking on a Text node assigned to a slot inside an anchor element. The link should be activated.<br>

To manually test, click "here" below and you should see "PASS" and the mouse cursor should indicate it's a hyperlink, not text:</p>

6<script src="../../resources/ui-helper.js"></script>

<script>

var shadowHost = document.createElement('div');

@@if (window.internals) {

    testRunner.dumpAsText();

    document.getElementById('activation').textContent = 'FAIL';

    document.write('<div>Cursor: <span id="cursor">FAIL<span></div>');

    eventSender.mouseMoveTo(shadowHost.offsetLeft + 5, shadowHost.offsetTop + 5);

    eventSender.mouseDown();

    eventSender.mouseUp();

28 UIHelper.wait(UIHelper.activateAt(shadowHost.offsetLeft + 5, shadowHost.offsetTop + 5));

}

</script>

209064

LayoutTests/platform/ios-simulator/fast/shadow-dom/click-text-inside-linked-slot-expected.txt

This tests clicking on a Text node assigned to a slot inside an anchor element. The link should be activated.

To manually test, click "here" below and you should see "PASS" and the mouse cursor should indicate it's a hyperlink, not text:

click here

Activation: PASS

Cursor: FAIL: Cursor details not available on this platform.

nonexistent

LayoutTests/resources/ui-helper.js

window.UIHelper = class UIHelper {

    static isIOS()

    {

        return navigator.userAgent.includes('iPhone');

    }

    static activateAt(x, y)

    {

        if (!testRunner.runUIScript || !this.isIOS()) {

            eventSender.mouseMoveTo(x, y);

            eventSender.mouseDown();

            eventSender.mouseUp();

            return Promise.resolve();

        }

        return new Promise((resolve) => {

            testRunner.runUIScript(`

                uiController.singleTapAtPoint(${x}, ${y}, function() {

                    uiController.uiScriptComplete('Done');

                });`, resolve);

        });

    }

    static wait(promise)

    {

        testRunner.waitUntilDone();

        return promise.then(

            function () { testRunner.notifyDone(); },

            function (error) { testRunner.notifyDone(); return Promise.reject(error); });

    }

}

nonexistent