LayoutTests/ChangeLog

2016-06-28  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        WebRTC: Misc MediaStreamEvent fixes: Update build flag and remove PassRefPtr usage

        https://bugs.webkit.org/show_bug.cgi?id=159132

        Reviewed by NOBODY (OOPS!).

        Update skip lists and expected results to not expect the MediaStreamEvent constructor in

        the global scope (it's under the WEB_RTC build flag).

        * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:

        * platform/mac/js/dom/global-constructors-attributes-expected.txt:

        (all above) Remove expected results associated with MediaStreamEvent constructor.

        * platform/mac/TestExpectations:

        Skip MediaStreamEvent constructor test since the mac port doesn't build with WEB_RTC yet.

2016-06-23  Benjamin Poulain  <bpoulain@apple.com>

        OOM Assertion failure in Array.prototype.toString

LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt

@@PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').hasOw

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').hasOwnProperty('set') is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').enumerable is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').configurable is true

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').value is MediaStreamEvent

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').hasOwnProperty('get') is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').hasOwnProperty('set') is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').enumerable is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').configurable is true

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamTrack').value is MediaStreamTrack

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamTrack').hasOwnProperty('get') is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamTrack').hasOwnProperty('set') is false

LayoutTests/platform/mac/TestExpectations

@@fast/mediastream/MediaStreamTrack-onended.html

fast/mediastream/MediaStreamTrack.html

# WebRTC is not supported yet.

167fast/events/constructors/media-stream-event-constructor.html

fast/mediastream/RTCIceCandidate.html

fast/mediastream/RTCPeerConnection-AddRemoveStream.html

fast/mediastream/RTCPeerConnection-createAnswer.html

LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt

@@PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').hasOw

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').hasOwnProperty('set') is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').enumerable is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamAudioSourceNode').configurable is true

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').value is MediaStreamEvent

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').hasOwnProperty('get') is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').hasOwnProperty('set') is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').enumerable is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamEvent').configurable is true

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamTrack').value is MediaStreamTrack

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamTrack').hasOwnProperty('get') is false

PASS Object.getOwnPropertyDescriptor(global, 'MediaStreamTrack').hasOwnProperty('set') is false

Source/WebCore/ChangeLog

2016-06-28  Adam Bergkvist  <adam.bergkvist@ericsson.com>

        WebRTC: Misc MediaStreamEvent fixes: Update build flag and remove PassRefPtr usage

        https://bugs.webkit.org/show_bug.cgi?id=159132

        Reviewed by NOBODY (OOPS!).

        Use the WEB_RTC build flag instead of MEDIA_STREAM since this event is related to

        RTCPeerConnection. Also remove PassRefPtr usage.

        Updated existing expected results.

        * Modules/mediastream/MediaStreamEvent.cpp:

        (WebCore::MediaStreamEvent::create):

        (WebCore::MediaStreamEvent::MediaStreamEvent):

        * Modules/mediastream/MediaStreamEvent.h:

        * Modules/mediastream/MediaStreamEvent.idl:

        * dom/EventNames.in:

2016-06-23  Brady Eidson  <beidson@apple.com>

        Retrieving Blobs from IndexedDB using cursors fails in WK2 (Sandboxing)

Source/WebCore/Modules/mediastream/MediaStreamEvent.cpp

#include "config.h"

#include "MediaStreamEvent.h"

28 #if ENABLE(M~~EDIA~~_S~~TREAM~~)

28#if ENABLE(WEB_RTC)

#include "EventNames.h"

#include "MediaStream.h"

namespace WebCore {

35 Ref<MediaStreamEvent> MediaStreamEvent::create(const AtomicString& type, bool canBubble, bool cancelable, ~~Pass~~RefPtr<MediaStream> stream)

35Ref<MediaStreamEvent> MediaStreamEvent::create(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStream>&& stream)

3636{

37 return adoptRef(*new MediaStreamEvent(type, canBubble, cancelable, stream));

37 return adoptRef(*new MediaStreamEvent(type, canBubble, cancelable, WTFMove(stream)));

}

Ref<MediaStreamEvent> MediaStreamEvent::createForBindings(const AtomicString& type, const MediaStreamEventInit& initializer)

@@Ref<MediaStreamEvent> MediaStreamEvent::createForBindings(const AtomicString& ty

    return adoptRef(*new MediaStreamEvent(type, initializer));

}

45 MediaStreamEvent::MediaStreamEvent(const AtomicString& type, bool canBubble, bool cancelable, ~~Pass~~RefPtr<MediaStream> stream)

45MediaStreamEvent::MediaStreamEvent(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStream>&& stream)

4646 : Event(type, canBubble, cancelable)

47 , m_stream(stream)

47 , m_stream(WTFMove(stream))

{

}

@@EventInterface MediaStreamEvent::eventInterface() const

} // namespace WebCore

73 #endif // ENABLE(M~~EDIA~~_S~~TREAM~~)

73#endif // ENABLE(WEB_RTC)

7474

Source/WebCore/Modules/mediastream/MediaStreamEvent.h

#ifndef MediaStreamEvent_h

#define MediaStreamEvent_h

28 #if ENABLE(M~~EDIA~~_S~~TREAM~~)

28#if ENABLE(WEB_RTC)

#include "Event.h"

#include "MediaStream.h"

@@class MediaStreamEvent : public Event {

public:

    virtual ~MediaStreamEvent();

44 static Ref<MediaStreamEvent> create(const AtomicString& type, bool canBubble, bool cancelable, ~~Pass~~RefPtr<MediaStream>);

44 static Ref<MediaStreamEvent> create(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStream>&&);

    static Ref<MediaStreamEvent> createForBindings(const AtomicString& type, const MediaStreamEventInit& initializer);

    MediaStream* stream() const;

@@public:

    virtual EventInterface eventInterface() const;

private:

52 MediaStreamEvent(const AtomicString& type, bool canBubble, bool cancelable, ~~Pass~~RefPtr<MediaStream>);

52 MediaStreamEvent(const AtomicString& type, bool canBubble, bool cancelable, RefPtr<MediaStream>&&);

    MediaStreamEvent(const AtomicString& type, const MediaStreamEventInit&);

    RefPtr<MediaStream> m_stream;

@@private:

} // namespace WebCore

60 #endif // ENABLE(M~~EDIA~~_S~~TREAM~~)

60#endif // ENABLE(WEB_RTC)

6161

6262#endif // MediaStreamEvent_h

Source/WebCore/Modules/mediastream/MediaStreamEvent.idl

 */

[

26 Conditional=M~~EDIA~~_S~~TREAM~~,

26 Conditional=WEB_RTC,

    ConstructorTemplate=Event

] interface MediaStreamEvent : Event {

   [InitializedByEventConstructor] readonly attribute MediaStream stream;

Source/WebCore/dom/EventNames.in

@@ApplePayShippingMethodSelectedEvent conditional=APPLE_PAY

ApplePayValidateMerchantEvent conditional=APPLE_PAY

AudioProcessingEvent conditional=WEB_AUDIO

OfflineAudioCompletionEvent conditional=WEB_AUDIO

41 MediaStreamEvent conditional=M~~EDIA~~_S~~TREAM~~

41MediaStreamEvent conditional=WEB_RTC

MediaStreamTrackEvent conditional=MEDIA_STREAM

RTCIceCandidateEvent conditional=WEB_RTC

RTCDataChannelEvent conditional=WEB_RTC