Source/WebCore/ChangeLog

112015-12-10 Joseph Pecoraro <pecoraro@apple.com>
22
 3 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
 4 https://bugs.webkit.org/show_bug.cgi?id=152156
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
 9 * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
 10 (WebCore::CDMSessionAVContentKeySession::CDMSessionAVContentKeySession):
 11 * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
 12 * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
 13 (WebCore::CDMSessionAVStreamSession::CDMSessionAVStreamSession):
 14 Rename classes with a "Web" prefix.
 15
 162015-12-10 Joseph Pecoraro <pecoraro@apple.com>
 17
318 Remote Inspector: Verify the identity of the other side of XPC connections
419 https://bugs.webkit.org/show_bug.cgi?id=152153
520

Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h

3434
3535OBJC_CLASS AVContentKeyRequest;
3636OBJC_CLASS AVContentKeySession;
37 OBJC_CLASS CDMSessionAVContentKeySessionDelegate;
 37OBJC_CLASS WebCDMSessionAVContentKeySessionDelegate;
3838
3939namespace WebCore {
4040

@@protected:
6666 AVContentKeySession* contentKeySession();
6767
6868 RetainPtr<AVContentKeySession> m_contentKeySession;
69  RetainPtr<CDMSessionAVContentKeySessionDelegate> m_contentKeySessionDelegate;
 69 RetainPtr<WebCDMSessionAVContentKeySessionDelegate> m_contentKeySessionDelegate;
7070 RetainPtr<AVContentKeyRequest> m_keyRequest;
7171 RefPtr<Uint8Array> m_initData;
7272 RetainPtr<NSData> m_expiredSession;

Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm

@@- (void)processContentKeyResponseError:(NSError *)error;
8080- (void)renewExpiringContentKeyResponseData;
8181@end
8282
83 @interface CDMSessionAVContentKeySessionDelegate : NSObject {
 83@interface WebCDMSessionAVContentKeySessionDelegate : NSObject {
8484 WebCore::CDMSessionAVContentKeySession *m_parent;
8585}
8686- (void)invalidate;
8787@end
8888
89 @implementation CDMSessionAVContentKeySessionDelegate
 89@implementation WebCDMSessionAVContentKeySessionDelegate
9090- (id)initWithParent:(WebCore::CDMSessionAVContentKeySession *)parent
9191{
9292 if ((self = [super init]))

@@namespace WebCore {
125125
126126CDMSessionAVContentKeySession::CDMSessionAVContentKeySession(const Vector<int>& protocolVersions, CDMPrivateMediaSourceAVFObjC& cdm, CDMSessionClient* client)
127127 : CDMSessionMediaSourceAVFObjC(cdm, client)
128  , m_contentKeySessionDelegate(adoptNS([[CDMSessionAVContentKeySessionDelegate alloc] initWithParent:this]))
 128 , m_contentKeySessionDelegate(adoptNS([[WebCDMSessionAVContentKeySessionDelegate alloc] initWithParent:this]))
129129 , m_protocolVersions(protocolVersions)
130130 , m_mode(Normal)
131131{

Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h

3434#if ENABLE(ENCRYPTED_MEDIA_V2) && ENABLE(MEDIA_SOURCE)
3535
3636OBJC_CLASS AVStreamSession;
37 OBJC_CLASS CDMSessionAVStreamSessionObserver;
 37OBJC_CLASS WebCDMSessionAVStreamSessionObserver;
3838
3939namespace WebCore {
4040

@@protected:
6565 RefPtr<Uint8Array> m_initData;
6666 RefPtr<Uint8Array> m_certificate;
6767 RetainPtr<NSData> m_expiredSession;
68  RetainPtr<CDMSessionAVStreamSessionObserver> m_dataParserObserver;
 68 RetainPtr<WebCDMSessionAVStreamSessionObserver> m_dataParserObserver;
6969 Vector<int> m_protocolVersions;
7070 enum { Normal, KeyRelease } m_mode;
7171};

Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm

@@+ (NSArray *)pendingExpiredSessionReportsWithAppIdentifier:(NSData *)appIdentifi
6666+ (void)removePendingExpiredSessionReports:(NSArray *)expiredSessionReports withAppIdentifier:(NSData *)appIdentifier storageDirectoryAtURL:(NSURL *)storageURL;
6767@end
6868
69 @interface CDMSessionAVStreamSessionObserver : NSObject {
 69@interface WebCDMSessionAVStreamSessionObserver : NSObject {
7070 WebCore::CDMSessionAVStreamSession *m_parent;
7171}
7272@end
7373
74 @implementation CDMSessionAVStreamSessionObserver
 74@implementation WebCDMSessionAVStreamSessionObserver
7575- (id)initWithParent:(WebCore::CDMSessionAVStreamSession *)parent
7676{
7777 if ((self = [super init]))

@@namespace WebCore {
9898CDMSessionAVStreamSession::CDMSessionAVStreamSession(const Vector<int>& protocolVersions, CDMPrivateMediaSourceAVFObjC& cdm, CDMSessionClient* client)
9999 : CDMSessionMediaSourceAVFObjC(cdm, client)
100100 , m_weakPtrFactory(this)
101  , m_dataParserObserver(adoptNS([[CDMSessionAVStreamSessionObserver alloc] initWithParent:this]))
 101 , m_dataParserObserver(adoptNS([[WebCDMSessionAVStreamSessionObserver alloc] initWithParent:this]))
102102 , m_protocolVersions(protocolVersions)
103103 , m_mode(Normal)
104104{

Tools/ChangeLog

 12015-12-10 Joseph Pecoraro <pecoraro@apple.com>
 2
 3 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
 4 https://bugs.webkit.org/show_bug.cgi?id=152156
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 Our frameworks should appropriately prefix all ObjC classes,
 9 not just external symbols.
 10
 11 * Scripts/check-for-inappropriate-objc-class-names:
 12 Remove the -g switch to check all ObjC class names.
 13
1142015-12-09 Aakash Jain <aakash_jain@apple.com>
215
316 Run atleast one simulator even if max process limit is low

Tools/Scripts/check-for-inappropriate-objc-class-names

@@my $pattern = "^(" . join('|', @allowedPrefixes) . ")";
6060my $sawError = 0;
6161
6262if (!defined $executablePathAge || !defined $buildTimestampAge || $executablePathAge < $buildTimestampAge || $scriptAge < $buildTimestampAge) {
63  if (!open NM, "(nm -Ugjp '$executablePath' | sed 's/^/STDOUT:/') 2>&1 |") {
 63 if (!open NM, "(nm -Ujp '$executablePath' | sed 's/^/STDOUT:/') 2>&1 |") {
6464 print "ERROR: Could not open $executablePath\n";
6565 $sawError = 1;
6666 next;