ChangeLog

2015-03-01  Joonghun Park  <jh718.park@samsung.com>

        Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ScrollAnimator

        https://bugs.webkit.org/show_bug.cgi?id=142143

        Reviewed by NOBODY (OOPS!).

        No new tests, no behavior changes.

        * platform/ScrollAnimator.cpp:

        (WebCore::ScrollAnimator::create):

        * platform/ScrollAnimator.h:

        * platform/ScrollAnimatorNone.cpp:

        (WebCore::ScrollAnimator::create):

        * platform/ScrollableArea.h:

        * platform/ios/ScrollAnimatorIOS.mm:

        (WebCore::ScrollAnimator::create):

        * platform/mac/ScrollAnimatorMac.mm:

        (WebCore::ScrollAnimator::create):

2015-02-28  Simon Fraser  <simon.fraser@apple.com>

        Viewport units should not dirty style just before we do layout

Source/WebCore/platform/ScrollAnimator.cpp

namespace WebCore {

#if !ENABLE(SMOOTH_SCROLLING) && !PLATFORM(IOS)

44 Pa~~ssOw~~nPtr<ScrollAnimator> ScrollAnimator::create(ScrollableArea& scrollableArea)

44std::unique_ptr<ScrollAnimator> ScrollAnimator::create(ScrollableArea& scrollableArea)

4545{

46 return ~~adoptPtr(~~new ScrollAnimator(scrollableArea));

46 return std::make_unique<ScrollAnimator>(scrollableArea);

}

#endif

Source/WebCore/platform/ScrollAnimator.h

@@class ScrollAnimator {

#endif

    WTF_MAKE_FAST_ALLOCATED;

public:

60 static Pa~~ssOw~~nPtr<ScrollAnimator> create(ScrollableArea&);

60 static std::unique_ptr<ScrollAnimator> create(ScrollableArea&);

6161

62 explicit ScrollAnimator(ScrollableArea&);

    virtual ~ScrollAnimator();

    // Computes a scroll destination for the given parameters.  Returns false if

@@public:

#endif

protected:

129 explicit ScrollAnimator(ScrollableArea&);

130

    virtual void notifyPositionChanged(const FloatSize& delta);

#if ENABLE(CSS_SCROLL_SNAP) && PLATFORM(MAC)

Source/WebCore/platform/ScrollAnimatorNone.cpp

@@const double kTickTime = 1 / kFrameRate;

const double kMinimumTimerInterval = .001;

const double kZoomTicks = 11;

55 Pa~~ssOw~~nPtr<ScrollAnimator> ScrollAnimator::create(ScrollableArea& scrollableArea)

55std::unique_ptr<ScrollAnimator> ScrollAnimator::create(ScrollableArea& scrollableArea)

5656{

5757 if (scrollableArea.scrollAnimatorEnabled())

58 return ~~adoptPtr(~~new ScrollAnimatorNone(scrollableArea));

59 return ~~adoptPtr(~~new ScrollAnimator(scrollableArea));

58 return std::make_unique<ScrollAnimatorNone>(scrollableArea);

59 return std::make_unique<ScrollAnimator>(scrollableArea);

}

ScrollAnimatorNone::Parameters::Parameters()

Source/WebCore/platform/ScrollableArea.h

@@private:

    // scroll of the content.

    virtual void setScrollOffset(const IntPoint&) = 0;

299 mutable OwnPtr<ScrollAnimator> m_scrollAnimator;

299 mutable std::unique_ptr<ScrollAnimator> m_scrollAnimator;

#if ENABLE(CSS_SCROLL_SNAP)

    std::unique_ptr<Vector<LayoutUnit>> m_horizontalSnapOffsets;

Source/WebCore/platform/ios/ScrollAnimatorIOS.mm

@@using namespace WebCore;

namespace WebCore {

43 Pa~~ssOw~~nPtr<ScrollAnimator> ScrollAnimator::create(ScrollableArea& scrollableArea)

43std::unique_ptr<ScrollAnimator> ScrollAnimator::create(ScrollableArea& scrollableArea)

4444{

45 return ~~adoptPtr(~~new ScrollAnimatorIOS(scrollableArea));

45 return std::make_unique<ScrollAnimatorIOS>(scrollableArea);

}

ScrollAnimatorIOS::ScrollAnimatorIOS(ScrollableArea& scrollableArea)

Source/WebCore/platform/mac/ScrollAnimatorMac.mm

@@enum FeatureToAnimate {

namespace WebCore {

637 Pa~~ssOw~~nPtr<ScrollAnimator> ScrollAnimator::create(ScrollableArea& scrollableArea)

637std::unique_ptr<ScrollAnimator> ScrollAnimator::create(ScrollableArea& scrollableArea)

638638{

639 return ~~adoptPtr(~~new ScrollAnimatorMac(scrollableArea));

639 return std::make_unique<ScrollAnimatorMac>(scrollableArea);

}

ScrollAnimatorMac::ScrollAnimatorMac(ScrollableArea& scrollableArea)