ChangeLog

2014-10-15  Brian Michel  <brian.michel@gmail.com>

        [Mac] Handle Open Panel Functions Are Unimplemented

        https://bugs.webkit.org/show_bug.cgi?id=137759

        Reviewed by NOBODY (OOPS!).

        The "handleRunOpenPanel" was unimplemented for the Mac implementation

        of PageClientImpl which resulted in nothing happening if an end user

        clicked an input field located in a WKWebView.

        I could not find any existing tests for PageClientImpl so I did not

        add any new tests for this class.

        * UIProcess/mac/PageClientImpl.h:

        * UIProcess/mac/PageClientImpl.mm:

        (WebKit::PageClientImpl::handleRunOpenPanel):

2014-10-15  Dan Bernstein  <mitz@apple.com>

        [Cocoa] "Plug-in will handle load" error isn't declared in the modern API

Source/WebKit2/UIProcess/mac/PageClientImpl.h

@@private:

    virtual void setCursorHiddenUntilMouseMoves(bool);

    virtual void didChangeViewportProperties(const WebCore::ViewportAttributes&);

91 virtual bool handleRunOpenPanel(WebPageProxy*, WebFrameProxy*, WebOpenPanelParameters*, WebOpenPanelResultListenerProxy*) override;

    virtual void registerEditCommand(PassRefPtr<WebEditCommandProxy>, WebPageProxy::UndoOrRedo);

    virtual void clearAllEditCommands();

    virtual bool canUndoRedo(WebPageProxy::UndoOrRedo);

Source/WebKit2/UIProcess/mac/PageClientImpl.mm

#import "WKAPICast.h"

#import "WKFullScreenWindowController.h"

#import "WKStringCF.h"

45#import "WKURLCF.h"

#import "WKViewInternal.h"

#import "WKWebViewInternal.h"

#import "WebColorPickerMac.h"

#import "WebContextMenuProxyMac.h"

#import "WebEditCommandProxy.h"

51#import "WebOpenPanelParameters.h"

52#import "WebOpenPanelResultListenerProxy.h"

#import "WebPopupMenuProxyMac.h"

#import "WindowServerConnection.h"

#import "_WKDownloadInternal.h"

@@void PageClientImpl::didCommitLoadForMainFrame(const String& mimeType, bool useC

void PageClientImpl::didFinishLoadingDataForCustomContentProvider(const String& suggestedFilename, const IPC::DataReference& dataReference)

{

}

    
bool PageClientImpl::handleRunOpenPanel(WebPageProxy*, WebFrameProxy*, WebOpenPanelParameters* parameters, WebOpenPanelResultListenerProxy* listener)

{

    if (!m_wkView) {

        listener->invalidate();

        return false;

    }

    NSWindow *window = [m_wkView window];

    if (!window) {

        listener->invalidate();

        return false;

    }

    NSOpenPanel *panel = [NSOpenPanel openPanel];

    [panel setAllowsMultipleSelection:parameters->allowMultipleFiles()];

    [panel beginSheetModalForWindow:window completionHandler:^(NSInteger result)

    {

        if (NSFileHandlingPanelCancelButton == result)

            listener->cancel();

        else {

            NSArray *fileURLs = [panel URLs];

            NSUInteger count = [fileURLs count];

            if (!count)

                listener->cancel();

            else {

                Vector<RefPtr<API::Object>> urls;

                urls.reserveInitialCapacity(count);

                for (NSURL *fileURL in fileURLs)

                    urls.uncheckedAppend(adoptRef(toImpl(WKURLCreateWithCFURL((CFURLRef)fileURL))));

                RefPtr<API::Array> fileURLsRef = API::Array::create(WTF::move(urls));

                listener->chooseFiles(fileURLsRef.get());

            }

        }

    }];

    return true;

}

void PageClientImpl::handleDownloadRequest(DownloadProxy* download)

{