ChangeLog

112014-07-08 Benjamin Poulain <benjamin@webkit.org>

22

        Use 16bits instructions for push/pop on ARMv7 when possible

        https://bugs.webkit.org/show_bug.cgi?id=134753

        Reviewed by NOBODY (OOPS!).

        The patch r170839 mixed the code for push/pop pair and single push/pop.

        That part was reverted in r170909.

        This patch puts the code back but specialized for single push/pop.

        * assembler/ARMv7Assembler.h:

        (JSC::ARMv7Assembler::pop):

        (JSC::ARMv7Assembler::push):

        * assembler/MacroAssemblerARMv7.h:

        (JSC::MacroAssemblerARMv7::pop):

        (JSC::MacroAssemblerARMv7::push):

2014-07-08  Benjamin Poulain  <benjamin@webkit.org>

        Restore the assertion changed with 170839

        * assembler/ARMv7Assembler.h:

Source/JavaScriptCore/assembler/ARMv7Assembler.h

@@public:

        m_formatter.twoWordOp12Reg4FourFours(OP_ROR_reg_T2, rn, FourFours(0xf, rd, 0, rm));

    }

    ALWAYS_INLINE void pop(RegisterID dest)

    {

        if (dest < ARMRegisters::r8)

            m_formatter.oneWordOp7Imm9(OP_POP_T1, 1 << dest);

        else {

            // Load postindexed with writeback.

            ldr(dest, ARMRegisters::sp, sizeof(void*), false, true);

        }

    }

    ALWAYS_INLINE void pop(uint32_t registerList)

    {

        ASSERT(WTF::bitCount(registerList) > 1);

@@public:

        m_formatter.twoWordOp16Imm16(OP_POP_T2, registerList);

    }

    ALWAYS_INLINE void push(RegisterID src)

    {

        if (src < ARMRegisters::r8)

            m_formatter.oneWordOp7Imm9(OP_PUSH_T1, 1 << src);

        else if (src == ARMRegisters::lr)

            m_formatter.oneWordOp7Imm9(OP_PUSH_T1, 0x100);

        else {

            // Store preindexed with writeback.

            str(src, ARMRegisters::sp, -sizeof(void*), true, true);

        }

    }

    ALWAYS_INLINE void push(uint32_t registerList)

    {

        ASSERT(WTF::bitCount(registerList) > 1);

Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h

@@public:

    
    void pop(RegisterID dest)

    {

1184 // Load postindexed with writeback.

1185 m_assembler.ldr(dest, ARMRegisters::sp, sizeof(void*), false, true);

1184 m_assembler.pop(dest);

    }

    void push(RegisterID src)

    {

1190 // Store preindexed with writeback.

1191 m_assembler.str(src, ARMRegisters::sp, -sizeof(void*), true, true);

1189 m_assembler.push(src);

    }

    void push(Address address)