ChangeLog

2013-08-29  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        According to DOM4, all DocType nodes should have a document

        https://bugs.webkit.org/show_bug.cgi?id=99244

        Reviewed by NOBODY (OOPS!).

        Doctypes now always have a node document and can be moved across document boundaries as per

        the latest DOM4 specification:

        http://dom.spec.whatwg.org/#dom-domimplementation-createdocumenttype

        http://dom.spec.whatwg.org/#dom-node-ownerdocument

        This means that DOMImplementation.createDocumentType() now sets the ownerDocument of the

        new DocumentType Node to the associated document of the current "context" object. In

        DOM4, all nodes have a document at all times. DocumentType nodes can now be moved across

        document boundaries so that the node can be added to a Document after being created.

        This means we will no longer need to special case DocumentType nodes in the code and

        Node::document() can no longer return NULL, which means that we'll be able to remove

        NULL checks in call sites.

        Firefox stable and since recently Blink already follow DOM4 here while IE10 does not (yet).

        Test: fast/dom/createDocumentType-ownerDocument.html

        * dom/ContainerNode.cpp:

        (WebCore::checkAcceptChild):

        * dom/DOMImplementation.cpp:

        (WebCore::DOMImplementation::createDocumentType):

        (WebCore::DOMImplementation::createDocument):

        * dom/Node.h:

        (WebCore::Node::document):

2013-08-29  Pratik Solanki  <pratik.solanki@gmail.com>

        SharedBuffer m_segments and m_dataArray must be exclusive

Source/WebCore/dom/ContainerNode.cpp

@@static inline ExceptionCode checkAcceptChild(ContainerNode* newParent, Node* new

    if (newParent->isReadOnlyNode())

        return NO_MODIFICATION_ALLOWED_ERR;

216 if (newChild->inDocument() && newChild->isDocumentTypeNode())

217 return HIERARCHY_REQUEST_ERR;

    if (containsConsideringHostElements(newChild, newParent))

        return HIERARCHY_REQUEST_ERR;

Source/WebCore/dom/DOMImplementation.cpp

@@PassRefPtr<DocumentType> DOMImplementation::createDocumentType(const String& qua

    if (!Document::parseQualifiedName(qualifiedName, prefix, localName, ec))

        return 0;

222 return DocumentType::create(0, qualifiedName, publicId, systemId);

222 return DocumentType::create(m_document, qualifiedName, publicId, systemId);

}

DOMImplementation* DOMImplementation::getInterface(const String& /*feature*/)

@@PassRefPtr<Document> DOMImplementation::createDocument(const String& namespaceUR

            return 0;

    }

    // WRONG_DOCUMENT_ERR: Raised if doctype has already been used with a different document or was

    // created from a different implementation.

    // Hixie's interpretation of the DOM Core spec suggests we should prefer

    // other exceptions to WRONG_DOCUMENT_ERR (based on order mentioned in spec),

    // but this matches the new DOM Core spec (http://www.w3.org/TR/domcore/).

    if (doctype && doctype->document()) {

        ec = WRONG_DOCUMENT_ERR;

        return 0;

    }

    if (doctype)

        doc->appendChild(doctype);

    if (documentElement)

Source/WebCore/dom/Node.h

@@public:

    unsigned nodeIndex() const;

398 // Returns the DOM ownerDocument attribute. This method never returns ~~NULL~~, except in the case

399 // of ~~(1)~~ a Document node ~~or (2) a DocumentType node that is not used with any Document yet~~.

398 // Returns the DOM ownerDocument attribute. This method never returns 0, except in the case

399 // of a Document node.

400400 Document* ownerDocument() const;

401401

402 // Returns the document associated with this node. This method never returns ~~NULL, except in the case~~

403 // ~~of a DocumentType node that is not used with any Document yet.~~ A Document node returns itself.

402 // Returns the document associated with this node. This method never returns 0.

403 // A Document node returns itself.

    Document* document() const

    {

        ASSERT(this);

        // FIXME: below ASSERT is useful, but prevents the use of document() in the constructor or destructor

        // due to the virtual function call to nodeType().

        ASSERT(documentInternal() || (nodeType() == DOCUMENT_TYPE_NODE && !inDocument()));

407 ASSERT(documentInternal());

        return documentInternal();

    }

LayoutTests/ChangeLog

2013-08-29  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        According to DOM4, all DocType nodes should have a document

        https://bugs.webkit.org/show_bug.cgi?id=99244

        Reviewed by NOBODY (OOPS!).

        Add layout test to check that DocumentType Nodes have a document after being

        created. Also update a few existing test cases to reflect this change.

        * fast/dom/DOMImplementation/createDocument-with-used-doctype-expected.txt:

        * fast/dom/DOMImplementation/createDocument-with-used-doctype.html:

        * fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html:

        * fast/dom/XMLSerializer-doctype2-expected.txt:

        * fast/dom/XMLSerializer-doctype2.html:

        * fast/dom/createDocumentType-ownerDocument-expected.txt: Added.

        * fast/dom/createDocumentType-ownerDocument.html: Added.

        * fast/dom/move-nodes-across-documents.html:

        * fast/dom/node-iterator-with-doctype-root-expected.txt:

        * fast/dom/node-iterator-with-doctype-root.html:

        * fast/events/dispatch-event-no-document-expected.txt:

        * fast/events/dispatch-event-no-document.html:

2013-08-29  Joseph Pecoraro  <pecoraro@apple.com>

        Web Inspector: Consolidate inspector-protocol Debugger tests

LayoutTests/fast/dom/DOMImplementation/createDocument-with-used-doctype-expected.txt

1 PASS

document.implementation.createDocument with current document's DOCTYPE.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS doc = document.implementation.createDocument(null, null, document.doctype) did not throw exception.

PASS doc.doctype is doctype

PASS doc.firstChild is doctype

PASS document.doctype is null

PASS successfullyParsed is true

TEST COMPLETE

217

LayoutTests/fast/dom/DOMImplementation/createDocument-with-used-doctype.html

11<body>

2<script src="../../js/resources/js-test-pre.js"></script>

23<script>

if (window.testRunner) {

    testRunner.dumpAsText();

    testRunner.waitUntilDone();

}

function gc()

{

    if (window.GCController)

        return GCController.collect();

    for (var i = 0; i < 10000; i++)

        var s = new String("");

}

4window.jsTestIsAsync = true;

// Reload multiple times, to make crashing more likely.

var iterationsLeft = 50;

@@function test()

        frames[0].history.go(0);

    } else {

        gc();

        document.getElementById("result").innerText = frames[0].document.body.textContent;

        if (window.testRunner)

            testRunner.notifyDone();

14 debug(frames[0].document.body.outerHTML);

15 finishJSTest();

    }

}

</script>

31 <div id="result">FAIL</div>

3219<iframe src="resources/createDocument-with-used-doctype-frame.html" onload="test()"></iframe>

20<script src="../../js/resources/js-test-post.js"></script>

3321</body>

LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html

11<!doctype html>

2 <title>document.implementation.createDocument with current document's DOCTYPE</title>

<html>

<head>

<script src="../../../js/resources/js-test-pre.js"></script>

</head>

36<body>

4 FAIL (Script did not run);

57<script>

document.body.textContent = "FAIL";

try {

    document.implementation.createDocument(null, null, document.doctype);

    document.body.textContent = "FAIL (no exception)";

}

catch(e) {

    if (e.code === DOMException.WRONG_DOCUMENT_ERR || e.code === DOMException.NOT_SUPPORTED_ERR)

        document.body.textContent = "PASS";

    else

        document.body.textContent = "FAIL (wrong exception: " + e.code + ")";

}

description("document.implementation.createDocument with current document's DOCTYPE.");

var doctype = document.doctype;

var doc;

shouldNotThrow("doc = document.implementation.createDocument(null, null, document.doctype)");

shouldBe('doc.doctype', 'doctype');

shouldBe('doc.firstChild', 'doctype');

shouldBe('document.doctype', 'null');

1716</script>

17</body>

18</html>

LayoutTests/fast/dom/XMLSerializer-doctype2-expected.txt

1 This tests XMLSerializer.serializeToString() on a DocumentType node that does not have a document associated with it. It should throw an INVALID_ACCESS_ERR DOMException.

2 PASS: an Error: InvalidAccessError: DOM Exception 15 was thrown as expected.

This tests XMLSerializer.serializeToString() on a newly created DocumentType node does not throw since the node has an associated document.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS text = serializer.serializeToString(docType) did not throw exception.

PASS text is "<!DOCTYPE aDocTypeName PUBLIC \"aPublicID\" \"aSystemID\">"

LayoutTests/fast/dom/XMLSerializer-doctype2.html

11<html>

22<head>

    <script>

        function debug(str) {

            li = document.createElement('li');

            li.appendChild(document.createTextNode(str));

            document.getElementById('console').appendChild(li);

        }

        function runTests() {

            if (window.testRunner)

                testRunner.dumpAsText();

            var docType = window.document.implementation.createDocumentType("aDocTypeName", "aPublicID", "aSystemID");

<script src="../js/resources/js-test-pre.js"></script>

</head>

<body>

<script>

description("This tests XMLSerializer.serializeToString() on a newly created DocumentType node does not throw since the node has an associated document.");

158

16 var s~~erializer~~ = new ~~XMLSeri~~a~~lizer(~~);

9var docType = window.document.implementation.createDocumentType("aDocTypeName", "aPublicID", "aSystemID");

1710

            try {

                var text = serializer.serializeToString(docType);

                debug("FAIL: XMLSerializer.serializeToString() should throw an exception if it tries to serialize a documentless DocumentType node.");

            } catch (e) {

                if (e == "Error: InvalidAccessError: DOM Exception 15")

                    debug("PASS: an " + e + " was thrown as expected.")

                else

                    debug("FAIL: XMLSerializer.serializeToString() should throw an INVALID_ACCESS_ERR DOMExeption if it tries to serialize a documentless DocumentType node.");

            }

        }

    </script>

</head>

<body onload="runTests()">

This tests XMLSerializer.serializeToString() on a DocumentType node that does not have a document associated

with it.  It should throw an INVALID_ACCESS_ERR DOMException.

11var serializer = new XMLSerializer();

3312

34 <ul id="console">

35 </ul>

var text;

shouldNotThrow("text = serializer.serializeToString(docType)");

shouldBeEqualToString("text", "<!DOCTYPE aDocTypeName PUBLIC \"aPublicID\" \"aSystemID\">");

</script>

<script src="../js/resources/js-test-pre.js"></script>

3618</body>

3719</html>

LayoutTests/fast/dom/createDocumentType-ownerDocument-expected.txt

Tests that DOMImplementation.createDocumentType() properly sets the node's document to the associated document of the context object.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS docType.ownerDocument is document

PASS newDocument = document.implementation.createDocument('', null, docType) did not throw exception.

PASS newDocument.doctype is docType

PASS newDocument.doctype.ownerDocument is newDocument

PASS successfullyParsed is true

TEST COMPLETE

LayoutTests/fast/dom/createDocumentType-ownerDocument.html

<!DOCTYPE html>

<html>

<head>

<link rel="help" href="http://www.w3.org/TR/2012/WD-dom-20121206/#dom-domimplementation-createdocumenttype">

<script src="../js/resources/js-test-pre.js"></script>

</head>

<body>

<script>

description("Tests that DOMImplementation.createDocumentType() properly sets the node's document to the associated document of the context object.");

var docType = document.implementation.createDocumentType("html", null, null);

shouldBe("docType.ownerDocument", "document");

var newDocument;

shouldNotThrow("newDocument = document.implementation.createDocument('', null, docType)");

shouldBe("newDocument.doctype", "docType");

shouldBe("newDocument.doctype.ownerDocument", "newDocument");

</script>

<script src="../js/resources/js-test-post.js"></script>

</body>

</html>

LayoutTests/fast/dom/move-nodes-across-documents.html

@@function run()

    });

    runTest(function() {

        iframeDoc.implementation.createDocument('', 'html', document.doctype); 

171 }~~, 'WrongDocumentError'~~);

171 });

    runTest(function() {

        rangeInIframe().compareBoundaryPoints(Range.END_TO_END, rangeInCurrentDocument());

    }, 'WrongDocumentError');

@@function run()

    runTest(function() {

        iframeDoc.appendChild(document.doctype);

        console.log(document.doctype);

182 }, '~~HierarchyRequest~~Error');

182 }, 'NotFoundError');

    // When setting a boundary of the range in a different

    // document, the call should succeed and the range should be collapsed.

LayoutTests/fast/dom/node-iterator-with-doctype-root-expected.txt

11NodeIterator rooted at a DocumentType node not yet associated with a document:

2 PASS iter.referenceNode.ownerDocument is ~~null~~

2PASS iter.referenceNode.ownerDocument is document

PASS iter.nextNode() is dt

PASS iter.nextNode() is null

PASS iter.previousNode() is dt

LayoutTests/fast/dom/node-iterator-with-doctype-root.html

var dt = document.implementation.createDocumentType("foo", "", "");

var iter = document.createNodeIterator(dt, NodeFilter.SHOW_ALL, null, true);

debug("NodeIterator rooted at a DocumentType node not yet associated with a document:");

10 shouldBe('iter.referenceNode.ownerDocument', '~~null~~');

10shouldBe('iter.referenceNode.ownerDocument', 'document');

shouldBe('iter.nextNode()', 'dt');

shouldBe('iter.nextNode()', 'null');

shouldBe('iter.previousNode()', 'dt');

LayoutTests/fast/events/dispatch-event-no-document-expected.txt

1 The test verifies that EventTarget with an event listener ~~but without ScriptExecutionContext (~~not inserted into Document) does not crash during an attempt to dispatch an event. ~~It should just not call the handler. This is what FF 3.5 is also doing.~~

1The test verifies that EventTarget with an event listener not inserted into a Document does not crash during an attempt to dispatch an event.

22

3 Test passes if there is no crash, and event is not dispatched.

Test passes if there is no crash, and event is dispatched.

PASS: generic handled.

46

5 PASS

LayoutTests/fast/events/dispatch-event-no-document.html

11<script>

22function handleEvent(message) {

3 document.getElementById("log").innerHTML = "F~~AIL~~: " + message + " handled.<br>";

3 document.getElementById("log").innerHTML = "PASS: " + message + " handled.<br>";

}

function test() {

@@function test() {

}

</script>

<body onload="test()">

<p>The test verifies that EventTarget with an event listener but without ScriptExecutionContext (not inserted into Document) does not crash during an attempt to dispatch an event. It should just not call the handler. This is what FF 3.5 is also doing.</p>

<p>Test passes if there is no crash, and event is not dispatched.</p>

<div id="log">PASS</div>

<p>The test verifies that EventTarget with an event listener not inserted into a Document does not crash during an attempt to dispatch an event.</p>

<p>Test passes if there is no crash, and event is dispatched.</p>

<div id="log">FAIL</div>