ChangeLog

2013-08-05  Arpita Bahuguna  <a.bah@samsung.com>

        Moving down from start of a line doesn't place the caret at the start of the next.

        https://bugs.webkit.org/show_bug.cgi?id=119511

        Reviewed by NOBODY (OOPS!).

        When moving the caret from some position offset on a line to the start

        of that line (using the up arrow key) and then moving the caret to the

        following line (using the down arrow key), the caret is incorrectly

        positioned on the next line, displaced by an offset equivalent to that

        of the start caret position on the first line.

        This is because the 'X' position for vertical arrow navigation is

        retained even after the selection is modified. This is done for maintaining

        the 'X' value when moving between lines (vertical navigation).

        However, if the selection modification is userTriggered, for line or

        paragraph granularity, once the setSelection() call resets the maintained

        'x' position, we should not set it back. Otherwise, the previous

        selection modification's 'x' value is considered and a wrong position

        for the next line is computed.

        Test: editing/selection/move-caret-to-next-line.html

        * editing/FrameSelection.cpp:

        (WebCore::FrameSelection::modify):

        Added additional check for userTriggered when trying to set back

        the previous 'x' position for vertical arrow navigation.

2013-07-27  Mark Rowe  <mrowe@apple.com>

        Logging should be configurable using human-readable channel names rather than crazy bitmasks

153739

Source/WebCore/editing/FrameSelection.cpp

@@bool FrameSelection::modify(EAlteration

        break;

    }

1051 if (granularity == LineGranularity || granularity == ParagraphGranularity)

1051 if (userTriggered != UserTriggered && (granularity == LineGranularity || granularity == ParagraphGranularity))

        m_xPosForVerticalArrowNavigation = x;

    if (userTriggered == UserTriggered)

153739

LayoutTests/ChangeLog

2013-08-05  Arpita Bahuguna  <a.bah@samsung.com>

        Moving down from start of a line doesn't place the caret at the start of the next.

        https://bugs.webkit.org/show_bug.cgi?id=119511

        * editing/selection/move-caret-to-next-line-expected.txt: Added.

        * editing/selection/move-caret-to-next-line.html: Added.

        Added layout test case for verifying that the caret is placed

        at the start of the line when moving down from a previous line.

2013-08-05  Dean Jackson  <dino@apple.com>

        Update HTMLPreloadScanner to handle img srcset

153739

LayoutTests/editing/selection/move-caret-to-next-line-expected.txt

PASS caretRectAfterFirstDownArrow.left is caretRectAtStartOfLine.left

PASS caretRectAfterFirstDownArrow.top is caretRectAtStartOfLine.top

0

LayoutTests/editing/selection/move-caret-to-next-line.html

<!DOCTYPE html>

<html>

<head>

<script src="../../fast/js/resources/js-test-pre.js"></script>

</head>

<body>

<div contenteditable=true id="testDiv">

<p>

Test for <a href="http://bugs.webkit.org/show_bug.cgi?id=119511">119511</a>Caret should be placed somewhere in between this line and then moved to the start using up arrow key.

</p>

<p id="test">Down key should place caret at the start of this line.</p>

</div>

<script>

if (window.internals) {

    var testElement = document.getElementById('test');

    testElement.focus();

    var selection = window.getSelection();

    selection.collapse(testElement, 0);

    caretRectAtStartOfLine = internals.absoluteCaretBounds(document);

    selection.collapse(testElement, 1);

    eventSender.keyDown("upArrow");

    eventSender.keyDown("upArrow");

    eventSender.keyDown("downArrow");        

    caretRectAfterFirstDownArrow = internals.absoluteCaretBounds(document);

    shouldBe("caretRectAfterFirstDownArrow.left", "caretRectAtStartOfLine.left");

    shouldBe("caretRectAfterFirstDownArrow.top", "caretRectAtStartOfLine.top");

    document.getElementById('testDiv').style.display = 'none';

}

</script>

</div>

</body>

</html>

0