ChangeLog

112013-02-18 Ilya Tikhonovsky <loislo@chromium.org>

22

        Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node.

        https://bugs.webkit.org/show_bug.cgi?id=110124

        Reviewed by NOBODY (OOPS!).

        Publish userProvidedName into grid node.

        * inspector/front-end/HeapSnapshotGridNodes.js:

        (WebInspector.HeapSnapshotGenericObjectNode):

        (WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):

        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):

        * inspector/front-end/HeapSnapshotProxy.js:

        (WebInspector.HeapSnapshotWorker):

        * inspector/front-end/NativeHeapSnapshot.js:

        (WebInspector.NativeHeapSnapshotNode.prototype.serialize):

2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: Native Memory Instrumentation: Generate meta information for HeapSnapshot parser.

        https://bugs.webkit.org/show_bug.cgi?id=110104

Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js

@@WebInspector.HeapSnapshotGenericObjectNode = function(tree, node)

    if (!node)

        return;

    this._name = node.name;

353 this._userProvidedName = node.userProvidedName;

    this._type = node.type;

    this._distance = node.distance;

    this._shallowSize = node.selfSize;

@@WebInspector.HeapSnapshotGenericObjectNode.prototype = {

        var div = document.createElement("div");

        div.className = "source-code event-properties";

        div.style.overflow = "visible";

387

        var data = this.data["object"];

        if (this._prefixObjectCell)

            this._prefixObjectCell(div, data);

391

        var valueSpan = document.createElement("span");

        valueSpan.className = "value console-formatted-" + data.valueStyle;

        valueSpan.textContent = data.value;

        div.appendChild(valueSpan);

        if (this.data.userProvidedName) {

            var nameSpan = document.createElement("span");

            nameSpan.className = "name console-formatted-name";

            nameSpan.textContent = " " + this.data.userProvidedName;

            div.appendChild(nameSpan);

        }

        var idSpan = document.createElement("span");

        idSpan.className = "console-formatted-id";

        idSpan.textContent = " @" + data["nodeId"];

        div.appendChild(idSpan);

408

397409 if (this._postfixObjectCell)

398410 this._postfixObjectCell(div, data);

411

        cell.appendChild(div);

        cell.addStyleClass("disclosure");

        if (this.depth)

@@WebInspector.HeapSnapshotGenericObjectNode.prototype = {

            valueStyle += " detached-dom-tree-node";

        data["object"] = { valueStyle: valueStyle, value: value, nodeId: this.snapshotNodeId };

460 data["userProvidedName"] = this._userProvidedName;

        data["distance"] =  this._distance;

        data["shallowSize"] = Number.withThousandsSeparator(this._shallowSize);

        data["retainedSize"] = Number.withThousandsSeparator(this._retainedSize);

Source/WebCore/inspector/front-end/HeapSnapshotProxy.js

@@WebInspector.HeapSnapshotWorker = function()

    this._callbacks = [];

    this._previousCallbacks = [];

    // There is no support for workers in Chromium DRT.

186 this._worker = typeof InspectorTest === "undefined" ? new WebInspector.HeapSnapshotRealWorker() : new WebInspector.HeapSnapshotFakeWorker();

186 this._worker = /*typeof InspectorTest === "undefined" ? new WebInspector.HeapSnapshotRealWorker() :*/ new WebInspector.HeapSnapshotFakeWorker();

    this._worker.addEventListener("message", this._messageReceived, this);

}

Source/WebCore/inspector/front-end/NativeHeapSnapshot.js

@@WebInspector.NativeHeapSnapshotNode.prototype = {

        return {

            id: this.id(),

            name: this.className(),

112 userProvidedName: this.name(),

            distance: this.distance(),

            nodeIndex: this.nodeIndex,

            retainedSize: this.retainedSize(),