ChangeLog

2013-01-29  Eugene Klyuchnikov  <eustas@chromium.org>

        Web Inspector: [Network] Add cookie column to show presence of request/response cookies.

        https://bugs.webkit.org/show_bug.cgi?id=107441

        Reviewed by NOBODY (OOPS!).

        In some use cases only responses that contain "set-cookie" headers

        are interesting.

        * English.lproj/localizedStrings.js: Added corresponding strings.

        * inspector/front-end/NetworkPanel.js:

        (WebInspector.NetworkLogView.prototype._createTable): Added column.

        (WebInspector.NetworkLogView.prototype._createSortingFunctions): Ditto.

        (WebInspector.NetworkDataGridNode.prototype.createCells): Ditto.

        (WebInspector.NetworkDataGridNode.prototype.refreshRequest): Ditto.

        (WebInspector.NetworkDataGridNode.prototype._refreshCookiesCell): Added.

        (WebInspector.NetworkDataGridNode.CookiesComparator): Added.

2013-01-28  Shinya Kawanaka  <shinyak@chromium.org>

        [Shadow] Gesture event is not fired in ShadowDOM

Source/WebCore/inspector/front-end/NetworkPanel.js

@@WebInspector.NetworkLogView = function(coulmnsVisibilitySetting)

    WebInspector.networkLog.requests.forEach(this._appendRequest.bind(this));

}

98 WebInspector.NetworkLogView._defaultColumnsVisivility = {method: true, status: true, domain: false, type: true, initiator: true, size: true, time: true};

98WebInspector.NetworkLogView._defaultColumnsVisivility = {method: true, status: true, domain: false, type: true, initiator: true, cookies: false, size: true, time: true};

WebInspector.NetworkLogView.prototype = {

    _initializeView: function()

@@WebInspector.NetworkLogView.prototype = {

    _createTable: function()

    {

160 var columns = {name: {}, method: {}, status: {}, domain: {}, type: {}, initiator: {}, size: {}, time: {}, timeline: {}};

160 var columns = {name: {}, method: {}, status: {}, domain: {}, type: {}, initiator: {}, cookies: {}, size: {}, time: {}, timeline: {}};

        columns.name.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Name"), WebInspector.UIString("Path"));

        columns.name.name = WebInspector.UIString("Name");

@@WebInspector.NetworkLogView.prototype = {

        columns.initiator.sortable = true;

        columns.initiator.weight = 10;

        columns.cookies.title = WebInspector.UIString("Cookies");

        columns.cookies.sortable = true;

        columns.cookies.weight = 4

        columns.cookies.aligned = "centered";

        columns.size.titleDOMFragment = this._makeHeaderFragment(WebInspector.UIString("Size"), WebInspector.UIString("Content"));

        columns.size.name = WebInspector.UIString("Size");

        columns.size.sortable = true;

@@WebInspector.NetworkLogView.prototype = {

        this._sortingFunctions.domain = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "domain", false);

        this._sortingFunctions.type = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "mimeType", false);

        this._sortingFunctions.initiator = WebInspector.NetworkDataGridNode.InitiatorComparator;

288 this._sortingFunctions.cookies = WebInspector.NetworkDataGridNode.CookiesComparator;

        this._sortingFunctions.size = WebInspector.NetworkDataGridNode.SizeComparator;

        this._sortingFunctions.time = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "duration", false);

        this._sortingFunctions.timeline = WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, "startTime", false);

@@WebInspector.NetworkDataGridNode.prototype = {

        this._domainCell = this._createDivInTD("domain");

        this._typeCell = this._createDivInTD("type");

        this._initiatorCell = this._createDivInTD("initiator");

1970 this._cookiesCell = this._createDivInTD("cookies");

        this._sizeCell = this._createDivInTD("size");

        this._timeCell = this._createDivInTD("time");

        this._createTimelineCell();

@@WebInspector.NetworkDataGridNode.prototype = {

        this._refreshDomainCell();

        this._refreshTypeCell();

        this._refreshInitiatorCell();

2077 this._refreshCookiesCell();

        this._refreshSizeCell();

        this._refreshTimeCell();

@@WebInspector.NetworkDataGridNode.prototype = {

        }

    },

    _refreshCookiesCell: function()

    {

        this._cookiesCell.removeChildren();

        var value = [];

        var title = [];

        var responseCookies = this._request.responseCookies;

        if (responseCookies && responseCookies.length) {

            value.push("\u25BC");

            title.push(WebInspector.UIString("Cookies received."));

        }

        var requestCookies = this._request.requestCookies;

        if (requestCookies && requestCookies.length) {

            value.push("\u25B2");

            title.push(WebInspector.UIString("Cookies sent."));

        }

        this._cookiesCell.createTextChild(value.join(""));

        this._cookiesCell.title = title.join("\n");

    },

    _refreshSizeCell: function()

    {

        if (this._request.cached) {

@@WebInspector.NetworkDataGridNode.InitiatorComparator = function(a, b)

    return a._request.initiator.lineNumber - b._request.initiator.lineNumber;

}

WebInspector.NetworkDataGridNode.CookiesComparator = function(a, b)

{

    var aScore = (a._request.responseCookies && a._request.responseCookies.length) ? 2 : 0;

    aScore += (a._request.requestCookies && a._request.requestCookies.length) ? 1 : 0;

    var bScore = (b._request.responseCookies && b._request.responseCookies.length) ? 2 : 0;

    bScore += (b._request.requestCookies && b._request.requestCookies.length) ? 1 : 0;

    return bScore - aScore;

}

WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyName, revert, a, b)

{

    var aValue = a._request[propertyName];

Source/WebCore/ChangeLog

Source/WebCore/English.lproj/localizedStrings.js

Source/WebCore/inspector/front-end/NetworkPanel.js