ChangeLog

2012-09-23  Matt Falkenhagen  <falken@chromium.org>

        Skeleton implementation of dialog.showModal()

        https://bugs.webkit.org/show_bug.cgi?id=97425

        Reviewed by NOBODY (OOPS!).

        This adds a basic implementation of showModal(), so the top layer

        can be tested once it is implemented. The main features of

        showModal(), modality and the top layer, are not yet implemented.

        Test: fast/dom/HTMLDialogElement/dialog-show-modal.html

        * html/HTMLDialogElement.cpp:

        (WebCore::HTMLDialogElement::showModal): The same as show(), but throws an error in the cases specified in the spec.

        (WebCore):

        * html/HTMLDialogElement.h:

        (HTMLDialogElement):

        * html/HTMLDialogElement.idl:

2012-09-21  Evan Wallace  <evan.exe@gmail.com>

        [WebSocket] Receiving a large message is really slow

Source/WebCore/html/HTMLDialogElement.cpp

@@void HTMLDialogElement::show()

    setBooleanAttribute(openAttr, true);

}

void HTMLDialogElement::showModal(ExceptionCode& ec)

{

    if (fastHasAttribute(openAttr) || !inDocument()) {

        ec = INVALID_STATE_ERR;

        return;

    }

    setBooleanAttribute(openAttr, true);

}

bool HTMLDialogElement::isPresentationAttribute(const QualifiedName& name) const

{

    // FIXME: Workaround for <https://bugs.webkit.org/show_bug.cgi?id=91058>: modifying an attribute for which there is an attribute selector

Source/WebCore/html/HTMLDialogElement.h

@@public:

    void close(ExceptionCode&);

    void show();

44 void showModal(ExceptionCode&);

private:

    HTMLDialogElement(const QualifiedName&, Document*);

Source/WebCore/html/HTMLDialogElement.idl

@@module html {

        attribute [Reflect] boolean open;

        void close() raises(DOMException);

        void show();

34 void showModal() raises(DOMException);

    };

}

LayoutTests/ChangeLog

2012-09-23  Matt Falkenhagen  <falken@chromium.org>

        Skeleton implementation of dialog.showModal()

        https://bugs.webkit.org/show_bug.cgi?id=97425

        Reviewed by NOBODY (OOPS!).

        Add a test that showModal() opens the dialog or throws an error in the cases specified in the spec.

        * fast/dom/HTMLDialogElement/dialog-show-modal-expected.txt: Added.

        * fast/dom/HTMLDialogElement/dialog-show-modal.html: Added.

2012-09-21  Marcelo Lira  <marcelo.lira@openbossa.org>

        [Qt] REGRESSION: 5 tests started to fail with newer Qt5

LayoutTests/fast/dom/HTMLDialogElement/dialog-show-modal-expected.txt

Tests that showModal() performs the steps specified in the HTML spec. bug 97425

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS computedStyle.getPropertyValue('display') is 'none'

PASS computedStyle.getPropertyValue('display') is 'block'

PASS dialog.showModal(); threw exception Error: INVALID_STATE_ERR: DOM Exception 11.

PASS computedStyle.getPropertyValue('display') is 'none'

PASS dialog.showModal(); threw exception Error: INVALID_STATE_ERR: DOM Exception 11.

PASS successfullyParsed is true

TEST COMPLETE

LayoutTests/fast/dom/HTMLDialogElement/dialog-show-modal.html

<!DOCTYPE html>

<html>

<head>

<script src="../../js/resources/js-test-pre.js"></script>

<script>

if (window.internals)

    internals.settings.setDialogElementEnabled(true);

</script>

</head>

<body>

<dialog id="mydialog">It's my dialog.</dialog>

<script>

description("Tests that showModal() performs the steps specified in the HTML spec. bug 97425");

dialog = document.getElementById('mydialog');

computedStyle = window.getComputedStyle(dialog, null);

shouldBe("computedStyle.getPropertyValue('display')", "'none'");

dialog.showModal();

computedStyle = window.getComputedStyle(dialog, null);

shouldBe("computedStyle.getPropertyValue('display')", "'block'");

// The quoted text in the comments below are from <http://www.whatwg.org/specs/web-apps/current-work/multipage/commands.html#dom-dialog-showmodal>.

// "If dialog already has an open attribute, then throw an InvalidStateError exception."

shouldThrow('dialog.showModal();', "'Error: INVALID_STATE_ERR: DOM Exception 11'");

dialog.close();

shouldBe("computedStyle.getPropertyValue('display')", "'none'");

dialog.parentNode.removeChild(dialog);

// "If dialog is not in a Document, then throw an InvalidStateError exception."

shouldThrow('dialog.showModal();', "'Error: INVALID_STATE_ERR: DOM Exception 11'");

</script>

<script src="../../js/resources/js-test-post.js"></script>

</body>

</html>