COMMIT_MESSAGE

 195185
 2

LayoutTests/ChangeLog

 12012-08-28 Joanmarie Diggs <jdiggs@igalia.com>
 2
 3 Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
 4 https://bugs.webkit.org/show_bug.cgi?id=95185
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 Updated layout test expected results. In all three cases below:
 9 1) Remove objects from the tree representation which did not belong,
 10 but were included as a side effect of AccessibilityUIElement::stringValue()
 11 not having been implemented.
 12 2) Add the stringValue() return value to the tree representation.
 13 Note that the implementation of AccessibilityUIElement::titleUIElement()
 14 will be tested by the existing legend.html layout text. See bug 84137.
 15
 16 * platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Updated.
 17 * platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated.
 18 * platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Updated.
 19
1202012-08-27 Simon Fraser <simon.fraser@apple.com>
221
322 If both left and right (or top and bottom) are specified for sticky, use left (or top)

LayoutTests/platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt

@@On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
88
99
1010AXRole: document frame
11  AXRole: section
12  AXRole: section
13  AXRole: paragraph
14  AXRole: paragraph
 11 AXRole: section AXValue: y
 12 AXRole: section AXValue: End of test
1513PASS successfullyParsed is true
1614
1715TEST COMPLETE

LayoutTests/platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt

@@On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
1313Before:
1414AXRole: scroll pane
1515 AXRole: document frame
16  AXRole: paragraph
 16 AXRole: paragraph AXValue: Before
1717 AXRole: panel
1818 AXRole: scroll pane
1919 AXRole: document frame
2020 AXRole: panel
2121 AXRole: push button
22  AXRole: paragraph
23  AXRole: paragraph
24  AXRole: paragraph
25  AXRole: paragraph
26  AXRole: section
 22 AXRole: paragraph AXValue: After
 23 AXRole: paragraph AXValue: End of test
2724
2825After:
2926AXRole: scroll pane
3027 AXRole: document frame
31  AXRole: paragraph
 28 AXRole: paragraph AXValue: Before
3229 AXRole: panel
33  AXRole: paragraph
34  AXRole: paragraph
35  AXRole: paragraph
36  AXRole: paragraph
37  AXRole: section
 30 AXRole: paragraph AXValue: After
 31 AXRole: paragraph AXValue: End of test
3832
3933PASS frameBodyRole == frameBody.role is false
4034PASS frameGroupRole == frameGroup.role is false

LayoutTests/platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt

11End of test
22Before:
33AXRole: document frame
4  AXRole: link
5  AXRole: section
6  AXRole: panel
7  AXRole: paragraph
8  AXRole: paragraph
 4 AXRole: link AXValue:
 5 AXRole: section AXValue: End of test
96After:
107AXRole: document frame
11  AXRole: section
12  AXRole: panel
13  AXRole: paragraph
14  AXRole: paragraph
 8 AXRole: section AXValue: End of test
159This can cause a crash.
1610
1711On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

Tools/ChangeLog

 12012-08-28 Joanmarie Diggs <jdiggs@igalia.com>
 2
 3 Implement AccessibilityUIElement::titleUIElement() and AccessibilityUIElement::stringValue()
 4 https://bugs.webkit.org/show_bug.cgi?id=95185
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 9 (AccessibilityUIElement::titleUIElement): Implemented
 10 Gets the ATK_RELATION_LABELLED_BY target.
 11 (AccessibilityUIElement::stringValue): Implemented for all roles but ATK_ROLE_PANEL.
 12 Gets the string from atk_text_get_text(). Will implement for ATK_ROLE_PANEL after
 13 bug 95180 is fixed.
 14
1152012-08-24 James Robinson <jamesr@chromium.org>
216
317 WebGL should not flip textures on presentation if contents are unchanged

Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

@@JSStringRef AccessibilityUIElement::attributesOfDocumentLinks()
176176
177177AccessibilityUIElement AccessibilityUIElement::titleUIElement()
178178{
179  // FIXME: implement
180  return 0;
 179
 180 if (!m_element)
 181 return 0;
 182
 183 AtkRelationSet* set = atk_object_ref_relation_set(ATK_OBJECT(m_element));
 184 if (!set)
 185 return 0;
 186
 187 AtkObject* target = 0;
 188 int count = atk_relation_set_get_n_relations(set);
 189 for (int i = 0; i < count; i++) {
 190 AtkRelation* relation = atk_relation_set_get_relation(set, i);
 191 if (atk_relation_get_relation_type(relation) == ATK_RELATION_LABELLED_BY) {
 192 GPtrArray* targetList = atk_relation_get_target(relation);
 193 if (targetList->len)
 194 target = static_cast<AtkObject*>(g_ptr_array_index(targetList, 0));
 195 }
 196 g_object_unref(set);
 197 }
 198
 199 return target ? AccessibilityUIElement(target) : 0;
181200}
182201
183202AccessibilityUIElement AccessibilityUIElement::parentElement()

@@JSStringRef AccessibilityUIElement::description()
252271
253272JSStringRef AccessibilityUIElement::stringValue()
254273{
255  // FIXME: implement
256  return JSStringCreateWithCharacters(0, 0);
 274 if (!m_element || !ATK_IS_TEXT(m_element))
 275 return JSStringCreateWithCharacters(0, 0);
 276
 277 // FIXME: implement properly for ATK_ROLE_PANEL. Prior to doing so, we need
 278 // to fix bug 95180 as well as determine which panels we wish to keep in the
 279 // accessible hierarchy. See, for instance, bug 72811.
 280 AtkRole role = atk_object_get_role(ATK_OBJECT(m_element));
 281 if (role == ATK_ROLE_PANEL)
 282 return JSStringCreateWithCharacters(0, 0);
 283
 284 gchar* text =text = atk_text_get_text(ATK_TEXT(m_element), 0, -1);
 285 GOwnPtr<gchar> axValue(g_strdup_printf("AXValue: %s", text));
 286 g_free(text);
 287
 288 return JSStringCreateWithUTF8CString(axValue.get());
257289}
258290
259291JSStringRef AccessibilityUIElement::language()