ChangeLog

2012-03-31  Rob Buis  <rbuis@rim.com>

        SVGColor dom interface is not created for color property in SVG elements

        https://bugs.webkit.org/show_bug.cgi?id=15012

        Reviewed by NOBODY (OOPS!).

        Create SVGColor instances for the color property when in parsing mode SVGAttributeMode.

        Test: svg/custom/SVGColor-presentation-attribute.svg

        * css/CSSParser.cpp: special case SVGAttribute parsing mode

        (WebCore::parseColorValue):

        * css/CSSStyleApplyProperty.cpp: special case SVGColor handling

        (WebCore::ApplyPropertyColor::applyValue):

        * css/SVGCSSParser.cpp:

        (WebCore::CSSParser::parseSVGValue): remove unreachable code

2012-03-31  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>

        [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail

Source/WebCore/css/CSSParser.cpp

#include "ShadowValue.h"

#include "StylePropertySet.h"

#include "StyleRule.h"

#if ENABLE(SVG)

#include "SVGColor.h"

#endif

#if ENABLE(CSS_FILTERS)

#include "WebKitCSSFilterValue.h"

#endif

@@static bool parseColorValue(StylePropertySet* declaration, int propertyId, const

    CSSParserString cssString;

    cssString.characters = const_cast<UChar*>(string.characters());

    cssString.length = string.length();

#if ENABLE(SVG)

    if (cssParserMode == SVGAttributeMode && propertyId == CSSPropertyColor) {

        RGBA32 color;

        if (!CSSParser::fastParseColor(color, string, strict && string[0] != '#'))

            return false;

        RefPtr<CSSValue> value = SVGColor::createFromColor(color);

        declaration->addParsedProperty(CSSProperty(propertyId, value.release(), important));

        return true;

    }

#endif

    int valueID = cssValueKeywordID(cssString);

    bool validPrimitive = false;

    if (valueID == CSSValueWebkitText)

Source/WebCore/css/CSSStyleApplyProperty.cpp

#include "RenderStyle.h"

#include "RenderView.h"

#include "Settings.h"

#if ENABLE(SVG)

#include "SVGColor.h"

#endif

#include <wtf/StdLibExtras.h>

#include <wtf/UnusedParam.h>

@@public:

    static void applyValue(CSSStyleSelector* selector, CSSValue* value)

    {

#if ENABLE(SVG)

        if (value->isSVGColor()) {

            applyColorValue(selector, static_cast<SVGColor*>(value)->color());

            return;

        }

#endif

        if (!value->isPrimitiveValue())

            return;

Source/WebCore/css/SVGCSSParser.cpp

@@bool CSSParser::parseSVGValue(int propId, bool important)

        }

        break;

    case CSSPropertyColor:                // <color> | inherit

        if ((id >= CSSValueAqua && id <= CSSValueWindowtext) ||

           (id >= CSSValueAliceblue && id <= CSSValueYellowgreen))

            parsedValue = SVGColor::createFromString(value->string);

        else

            parsedValue = parseSVGColor();

        if (parsedValue)

            m_valueList->next();

        break;

    case CSSPropertyStopColor: // TODO : icccolor

    case CSSPropertyFloodColor:

    case CSSPropertyLightingColor:

LayoutTests/ChangeLog

112012-03-31 Rob Buis <rbuis@rim.com>

22

        SVGColor dom interface is not created for color property in SVG elements

        https://bugs.webkit.org/show_bug.cgi?id=15012

        Reviewed by NOBODY (OOPS!).

        Test that SVGColor is created for the presentation attribute and that it is applied.

        * svg/custom/SVGColor-presentation-attribute-expected.txt: Added.

        * svg/custom/SVGColor-presentation-attribute.svg: Added.

2012-03-31  Rob Buis  <rbuis@rim.com>

        XMLSerializer().serializeToString() doesn't generate the XML declaration markup like Opera and Firefox

        https://bugs.webkit.org/show_bug.cgi?id=25206

LayoutTests/svg/custom/SVGColor-presentation-attribute-expected.txt

1PASS

LayoutTests/svg/custom/SVGColor-presentation-attribute.svg

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" onload="runTest()">

<rect id="foo" color="green" fill="currentColor" width="100" height="100"/>

<foreignObject>

<html xmlns="http://www.w3.org/1999/xhtml">

  <body>

    <div id="log">

    </div>

  </body>

</html>

</foreignObject>

<script> <![CDATA[

  if (window.layoutTestController)

    layoutTestController.dumpAsText();

  function log(string) {

    var newDiv = document.createElementNS("http://www.w3.org/1999/xhtml", "div");

    newDiv.textContent = string;

    document.getElementById('log').appendChild(newDiv);

  }

  function runTest()

  {

      var element = document.getElementById('foo');

      if (element.getPresentationAttribute('color') instanceof SVGColor &&

          document.defaultView.getComputedStyle(element).getPropertyValue('color') == 'rgb(0, 128, 0)')

          log('PASS');

      else

          log('FAIL');

  }

]]></script>

</svg>