COMMIT_MESSAGE

matchMedia() MediaQueryList not updating 

https://bugs.webkit.org/show_bug.cgi?id=75903

Reviewed by NOBODY (OOPS!).

Source/WebCore:

Viewport related MediaQueryList listeners were not triggered and the value

of matches were not updated if the document's style selector were not

affected by viewport changes.

The new mehotd Document::viewportDependentStyleSelectorChange updates the

MediaQueryLists but it does nothing else if the style selector is not

affected by viewport changes.

* dom/Document.cpp:

(WebCore::Document::viewportDependentStyleSelectorChange):

(WebCore):

(WebCore::Document::styleSelectorChanged):

(WebCore::Document::updateStyleSelector):

* dom/Document.h:

(Document):

Document::viewportDependentStyleSelectorChange is used in FrameView::layout

allowing the MediaQueryLists to be updated when the viewport changes.

* page/FrameView.cpp:

(WebCore::FrameView::layout):

Test: fast/media/media-query-list-08.html

LayoutTests:

Testing MediaQueryLists listeners related to viewport changes.

* fast/media/media-query-list-08-expected.txt: Added.

* fast/media/media-query-list-08.html: Added.

Skipping the new test in Qt due to an issue in its DumpRenderTree.

* platform/qt/Skipped:

LayoutTests/ChangeLog

2012-02-22  Luiz Agostini  <luiz.agostini@palm.com>

        matchMedia() MediaQueryList not updating

        https://bugs.webkit.org/show_bug.cgi?id=75903

        Reviewed by NOBODY (OOPS!).

        Testing MediaQueryLists listeners related to viewport changes.

        * fast/media/media-query-list-08-expected.txt: Added.

        * fast/media/media-query-list-08.html: Added.

        Skipping the new test in Qt due to an issue in its DumpRenderTree.

        * platform/qt/Skipped:

2012-02-23  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed gardening. Mark two fast/files/ tests as non-flaky.

LayoutTests/fast/media/media-query-list-08-expected.txt

Test the MediaQueryList interface: http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface.

Testing viewport related callbacks

PASS

LayoutTests/fast/media/media-query-list-08.html

<html>

<head>

<title>Test CSSOM View module: MediaQueryList interface</title>

<script type="text/javascript" charset="utf-8">

    if (window.layoutTestController) {

        layoutTestController.dumpAsText();

        layoutTestController.waitUntilDone();

    }

    function log(m) {

        document.getElementById('results').innerHTML += m + '<br>';

    }

    function callback(query) {

        log("PASS");

        if (window.layoutTestController)

            layoutTestController.notifyDone();

    }

    function runTests()

    {

        window.matchMedia("(max-width: 250px)").addListener(callback);

        window.resizeTo(200, 300);

    }

</script>

</head>

<body onload="runTests()">

    <p>Test the MediaQueryList interface: <a href="http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface" title="CSSOM View Module">http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface</a>.</p>

    <p>Testing viewport related callbacks</p>

    <div id="results">

    </div>

</body>

</html>

LayoutTests/platform/qt/Skipped

@@fast/repaint/background-clip-text.html

# Needs layoutTestController.enableAutoResizeMode()

fast/autoresize

# window.resizeTo() does not trigger a relayout in our DumpRenderTree

fast/media/media-query-list-08.html

# This requires didClearWindowObjectForFrameInIsolatedWorld foo in FrameLoaderClient

http/tests/security/isolatedWorld/didClearWindowObject.html

# This needs more investigation

Source/WebCore/ChangeLog

2012-02-23  Luiz Agostini  <luiz.agostini@palm.com>

        matchMedia() MediaQueryList not updating

        https://bugs.webkit.org/show_bug.cgi?id=75903

        Reviewed by NOBODY (OOPS!).

        Viewport related MediaQueryList listeners were not triggered and the value

        of matches were not updated if the document's style selector were not

        affected by viewport changes.

        The new mehotd Document::viewportDependentStyleSelectorChange updates the

        MediaQueryLists but it does nothing else if the style selector is not

        affected by viewport changes.

        * dom/Document.cpp:

        (WebCore::Document::viewportDependentStyleSelectorChange):

        (WebCore):

        (WebCore::Document::styleSelectorChanged):

        (WebCore::Document::updateStyleSelector):

        * dom/Document.h:

        (Document):

        Document::viewportDependentStyleSelectorChange is used in FrameView::layout

        allowing the MediaQueryLists to be updated when the viewport changes.

        * page/FrameView.cpp:

        (WebCore::FrameView::layout):

        Test: fast/media/media-query-list-08.html

2012-02-23  Zoltan Horvath  <zoltan@webkit.org>

        [Qt] Allow to use WebCore imagedecoders

Source/WebCore/dom/Document.cpp

@@void Document::removePendingSheet()

        view()->scrollToFragment(m_url);

}

void Document::viewportDependentStyleSelectorChange(StyleSelectorUpdateFlag updateFlag)

{

    if (styleSelector()->affectedByViewportChange()) {

        // Viewport-dependent media queries may cause us to need completely different style information.

        // Check that here.

        updateStyleSelector(updateFlag);

        InspectorInstrumentation::mediaQueryResultChanged(this);

    }

    if (m_mediaQueryMatcher)

        m_mediaQueryMatcher->styleSelectorChanged();

}

30303042void Document::styleSelectorChanged(StyleSelectorUpdateFlag updateFlag)

30313043{

    updateStyleSelector(updateFlag);

    if (m_mediaQueryMatcher)

        m_mediaQueryMatcher->styleSelectorChanged();

}

void Document::updateStyleSelector(StyleSelectorUpdateFlag updateFlag)

{

    // Don't bother updating, since we haven't loaded all our style info yet

    // and haven't calculated the style selector for the first time.

    if (!attached() || (!m_didCalculateStyleSelector && !haveStylesheetsLoaded())) {

@@void Document::styleSelectorChanged(StyleSelectorUpdateFlag updateFlag)

        if (view())

            view()->scheduleRelayout();

    }

    if (m_mediaQueryMatcher)

        m_mediaQueryMatcher->styleSelectorChanged();

}

void Document::addStyleSheetCandidateNode(Node* node, bool createdByParser)

Source/WebCore/dom/Document.h

@@public:

     * found and is used to calculate the derived styles for all rendering objects.

     */

    void styleSelectorChanged(StyleSelectorUpdateFlag);

496 void viewportDependentStyleSelectorChange(StyleSelectorUpdateFlag);

    bool usesSiblingRules() const { return m_usesSiblingRules || m_usesSiblingRulesOverride; }

    void setUsesSiblingRules(bool b) { m_usesSiblingRulesOverride = b; }

@@private:

    static void didReceiveTask(void*);

1194 void updateStyleSelector(StyleSelectorUpdateFlag);

1195

#if ENABLE(PAGE_VISIBILITY_API)

    PageVisibilityState visibilityState() const;

#endif

Source/WebCore/page/FrameView.cpp

@@void FrameView::layout(bool allowSubtree)

            m_inSynchronousPostLayout = false;

        }

        // Viewport-dependent media queries may cause us to need completely different style information.

        // Check that here.

        if (document->styleSelector()->affectedByViewportChange()) {

            document->styleSelectorChanged(RecalcStyleImmediately);

            InspectorInstrumentation::mediaQueryResultChanged(document);

        }

973 document->viewportDependentStyleSelectorChange(RecalcStyleImmediately);

        // Always ensure our style info is up-to-date. This can happen in situations where

        // the layout beats any sort of style recalc update that needs to occur.