Source/WebCore/ChangeLog

 12011-11-12 Antti Koivisto <antti@apple.com>
 2
 3 REGRESSION(r98542): Rendering error on Google maps
 4 https://bugs.webkit.org/show_bug.cgi?id=71996
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 r98542 exposed that StyleBoxData copy constructor and operator== are missing a field.
 9
 10 Test reduction by David Barr.
 11
 12 Test: fast/css/vertical-align-length-copy-bug.html
 13
 14 * rendering/style/StyleBoxData.cpp:
 15 (WebCore::StyleBoxData::StyleBoxData):
 16 (WebCore::StyleBoxData::operator==):
 17
1182011-11-12 Sheriff Bot <webkit.review.bot@gmail.com>
219
320 Unreviewed, rolling out r100013.
100077

Source/WebCore/rendering/style/StyleBoxData.cpp

@@StyleBoxData::StyleBoxData(const StyleBo
4646 , m_maxWidth(o.m_maxWidth)
4747 , m_minHeight(o.m_minHeight)
4848 , m_maxHeight(o.m_maxHeight)
 49 , m_verticalAlign(o.m_verticalAlign)
4950 , m_zIndex(o.m_zIndex)
5051 , m_hasAutoZIndex(o.m_hasAutoZIndex)
5152 , m_boxSizing(o.m_boxSizing)

@@bool StyleBoxData::operator==(const Styl
6061 && m_maxWidth == o.m_maxWidth
6162 && m_minHeight == o.m_minHeight
6263 && m_maxHeight == o.m_maxHeight
 64 && m_verticalAlign == o.m_verticalAlign
6365 && m_zIndex == o.m_zIndex
6466 && m_hasAutoZIndex == o.m_hasAutoZIndex
6567 && m_boxSizing == o.m_boxSizing;
99841

LayoutTests/ChangeLog

 12011-11-12 Antti Koivisto <antti@apple.com>
 2
 3 REGRESSION(r98542): Rendering error on Google maps
 4 https://bugs.webkit.org/show_bug.cgi?id=71996
 5
 6 Reviewed by NOBODY (OOPS!).
 7
 8 Test reduction by David Barr.
 9
 10 * fast/css/vertical-align-length-copy-bug-expected.txt: Added.
 11 * fast/css/vertical-align-length-copy-bug.html: Added.
 12
1132011-11-12 Sheriff Bot <webkit.review.bot@gmail.com>
214
315 Unreviewed, rolling out r100013.
100077

LayoutTests/fast/css/vertical-align-length-copy-bug-expected.txt

 1Test for https://bugs.webkit.org/show_bug.cgi?id=71996
 2
 3On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 4
 5
 6PASS style.verticalAlign is "-1px"
 7PASS test.offsetTop is 10
 8PASS successfullyParsed is true
 9
 10TEST COMPLETE
 11
0

LayoutTests/fast/css/vertical-align-length-copy-bug.html

 1<!DOCTYPE HTML>
 2<script src="../js/resources/js-test-pre.js"></script>
 3<style>
 4#testDiv a, #testDiv span{display:inline-block;border:1px solid black;}
 5#testDiv a{width:30px;height:30px;text-align:center;line-height:30px;}
 6#testDiv a span{width:10px;height:10px;opacity:0.9;vertical-align:-1px;}
 7</style>
 8<div id=testDiv style="position:absolute">
 9<a><span id=test></span></a>
 10</div>
 11<script>
 12description("Test for https://bugs.webkit.org/show_bug.cgi?id=71996");
 13var test = document.getElementById("test");
 14var style = window.getComputedStyle(test);
 15shouldBeEqualToString("style.verticalAlign", "-1px");
 16shouldBe("test.offsetTop", "10");
 17isSuccessfullyParsed();
 18</script>
0