WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-60613-20110511011251.patch (text/plain), 1.94 KB, created by
Adam Barth
on 2011-05-11 01:12:53 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Adam Barth
Created:
2011-05-11 01:12:53 PDT
Size:
1.94 KB
patch
obsolete
>Index: Tools/ChangeLog >=================================================================== >--- Tools/ChangeLog (revision 86222) >+++ Tools/ChangeLog (working copy) >@@ -1,3 +1,16 @@ >+2011-05-11 Adam Barth <abarth@webkit.org> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ sheriffbot shouldn't spam bugs when it can't figure out who to blame >+ https://bugs.webkit.org/show_bug.cgi?id=60613 >+ >+ This patch limits the number of bugs sheriffbot will spam to three. >+ Ideally, we'd come up with some smarter huerstics, but hopefully this >+ will cut down on the bugmail spam for slow bots. >+ >+ * Scripts/webkitpy/tool/commands/sheriffbot.py: >+ > 2011-05-10 Eric Seidel <eric@webkit.org> > > Reviewed by Adam Barth. >Index: Tools/Scripts/webkitpy/tool/commands/sheriffbot.py >=================================================================== >--- Tools/Scripts/webkitpy/tool/commands/sheriffbot.py (revision 86222) >+++ Tools/Scripts/webkitpy/tool/commands/sheriffbot.py (working copy) >@@ -78,6 +78,7 @@ class SheriffBot(AbstractQueue, StepSequ > > def process_work_item(self, failure_map): > failing_revisions = failure_map.failing_revisions() >+ number_of_failing_revisions = len(failing_revisions) > for revision in failing_revisions: > builders = failure_map.builders_failing_for(revision) > tests = failure_map.tests_failing_for(revision) >@@ -87,7 +88,8 @@ class SheriffBot(AbstractQueue, StepSequ > print "FAILED to fetch CommitInfo for r%s, likely missing ChangeLog" % revision > continue > self._sheriff.post_irc_warning(commit_info, builders) >- self._sheriff.post_blame_comment_on_bug(commit_info, builders, tests) >+ if number_of_failing_revisions <= 3: >+ self._sheriff.post_blame_comment_on_bug(commit_info, builders, tests) > > finally: > for builder in builders:
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
eric
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 60613
: 93085