Attachment 92244 Details for Bug 57647 – Let transparent windowless plugins draw into a graphics context with an alpha channel

[patch] Let transparent windowless plugins draw into a graphics context with an alpha channel

bug-57647-20110504112512.patch (text/plain), 1.86 KB, created by Adam Roben (:aroben) on 2011-05-04 08:24:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adam Roben (:aroben)

Created: 2011-05-04 08:24:54 PDT

Size: 1.86 KB

patch

obsolete

>Subversion Revision: 85749
>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index d4c53fd986c5032d1bf12b7da51d43c8c81f74da..c358c7bbe9cb7bd0a8b1766da2ff753333a92978 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,3 +1,19 @@
>+2011-05-04  Adam Roben  <aroben@apple.com>
>+
>+        Let transparent windowless plugins draw into a graphics context with an alpha channel
>+
>+        Fixes <http://webkit.org/b/57647> <rdar://problem/9168462> Flash plugins with
>+        wmode=transparent have black (instead of transparent) background in WebKit2 on Windows
>+
>+        I had trouble writing a test case for this, so I split that task out into
>+        <http://webkit.org/b/60169>.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
>+        (WebKit::NetscapePlugin::platformPaint): Give the graphics context an alpha channel if this
>+        is a transparent windowless plugin.
>+
> 2011-05-03  Adam Roben  <aroben@apple.com>
> 
>         Remove WebPageProxy::setDrawingArea
>diff --git a/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp b/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp
>index f883bef0f65ebd80097627485832c6df14c16b0c..73741d832178ecb9438ca75d62d2bf70a8f4508a 100644
>--- a/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp
>+++ b/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp
>@@ -179,8 +179,7 @@ void NetscapePlugin::platformPaint(GraphicsContext* context, const IntRect& dirt
> 
>     m_pluginController->willSendEventToPlugin();
>     
>-    // FIXME: Support transparent plugins.
>-    LocalWindowsContext windowsContext(context, dirtyRect, false);
>+    LocalWindowsContext windowsContext(context, dirtyRect, m_isTransparent);
> 
>     m_npWindow.type = NPWindowTypeDrawable;
>     m_npWindow.window = windowsContext.hdc();

Flags:

sam: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 57647: 92244