WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-59924-20110502033648.patch (text/plain), 19.89 KB, created by
Adam Barth
on 2011-05-02 03:36:49 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Adam Barth
Created:
2011-05-02 03:36:49 PDT
Size:
19.89 KB
patch
obsolete
>Subversion Revision: 85465 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 1056770aeedd1817efe25e807bae67a153447ded..4f7fcfd941241794c6a276ccb45142a8fb332fef 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,15 @@ >+2011-05-02 Adam Barth <abarth@webkit.org> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ PLATFORM(MAC) should (almost!) build with strict PassOwnPtr >+ https://bugs.webkit.org/show_bug.cgi?id=59924 >+ >+ * css/CSSGrammar.y: >+ * platform/graphics/mac/SimpleFontDataMac.mm: >+ - Memory management for the font cache is somewhat... complext. >+ This will require some careful thought to sort out. >+ > 2011-05-01 Abhishek Arya <inferno@chromium.org> > > Reviewed by Eric Carlson. >diff --git a/Source/WebCore/css/CSSGrammar.y b/Source/WebCore/css/CSSGrammar.y >index 309f05b399a875d47861bcf452ac39c3087c9909..d1005058cd7faa5c15c490cd0058ffd5ad2956a4 100644 >--- a/Source/WebCore/css/CSSGrammar.y >+++ b/Source/WebCore/css/CSSGrammar.y >@@ -1450,7 +1450,7 @@ function: > CSSParser* p = static_cast<CSSParser*>(parser); > CSSParserFunction* f = p->createFloatingFunction(); > f->name = $1; >- f->args = p->sinkFloatingValueList($3); >+ f->args = adoptPtr(p->sinkFloatingValueList($3)); > $$.id = 0; > $$.unit = CSSParserValue::Function; > $$.function = f; >@@ -1459,7 +1459,7 @@ function: > CSSParser* p = static_cast<CSSParser*>(parser); > CSSParserFunction* f = p->createFloatingFunction(); > f->name = $1; >- f->args = 0; >+ f->args = nullptr; > $$.id = 0; > $$.unit = CSSParserValue::Function; > $$.function = f; >@@ -1568,7 +1568,7 @@ calc_function: > CSSParser* p = static_cast<CSSParser*>(parser); > CSSParserFunction* f = p->createFloatingFunction(); > f->name = $1; >- f->args = p->sinkFloatingValueList($3); >+ f->args = adoptPtr(p->sinkFloatingValueList($3)); > $$.id = 0; > $$.unit = CSSParserValue::Function; > $$.function = f; >@@ -1593,7 +1593,7 @@ min_or_max_function: > CSSParser* p = static_cast<CSSParser*>(parser); > CSSParserFunction* f = p->createFloatingFunction(); > f->name = $1; >- f->args = p->sinkFloatingValueList($3); >+ f->args = adoptPtr(p->sinkFloatingValueList($3)); > $$.id = 0; > $$.unit = CSSParserValue::Function; > $$.function = f; >diff --git a/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm b/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm >index 7780db807756cd5109d379ad4c2b92445dc17eec..5870dc8c9e5ce1f11a572355d4764219e84003b8 100644 >--- a/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm >+++ b/Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm >@@ -28,6 +28,10 @@ > */ > > #import "config.h" >+ >+// FIXME: Remove this define! >+#define LOOSE_PASS_OWN_PTR >+ > #import "SimpleFontData.h" > > #import "BlockExceptions.h" >diff --git a/Source/WebKit/mac/ChangeLog b/Source/WebKit/mac/ChangeLog >index 88a4c8d4578de3b5277c64c4d46e078d5321ffdc..3fa963bb0b3778e3067ca1c84476cad90fdc3f3c 100644 >--- a/Source/WebKit/mac/ChangeLog >+++ b/Source/WebKit/mac/ChangeLog >@@ -1,3 +1,21 @@ >+2011-05-02 Adam Barth <abarth@webkit.org> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ PLATFORM(MAC) should (almost!) build with strict PassOwnPtr >+ https://bugs.webkit.org/show_bug.cgi?id=59924 >+ >+ * History/WebHistory.mm: >+ (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]): >+ * Plugins/WebBaseNetscapePluginView.mm: >+ (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): >+ * WebCoreSupport/WebFrameLoaderClient.mm: >+ (WebFrameLoaderClient::savePlatformDataToCachedFrame): >+ * WebView/WebView.mm: >+ (-[WebView _injectMailQuirksScript]): >+ (-[WebView _injectOutlookQuirksScript]): >+ (toStringVector): >+ > 2011-05-01 Ryosuke Niwa <rniwa@webkit.org> > > Reviewed by Eric Seidel. >diff --git a/Source/WebKit/mac/History/WebHistory.mm b/Source/WebKit/mac/History/WebHistory.mm >index 6e3ebce1c5bfca8960f4a4eb88659619c718f8af..a51cc4d5d041922b823baebac82ecddf630941d1 100644 >--- a/Source/WebKit/mac/History/WebHistory.mm >+++ b/Source/WebKit/mac/History/WebHistory.mm >@@ -826,7 +826,7 @@ static inline WebHistoryDateKey dateKey(NSTimeInterval date) > if ([method length]) > item->setLastVisitWasHTTPNonGet([method caseInsensitiveCompare:@"GET"] && (![[url scheme] caseInsensitiveCompare:@"http"] || ![[url scheme] caseInsensitiveCompare:@"https"])); > >- item->setRedirectURLs(0); >+ item->setRedirectURLs(PassOwnPtr<Vector<String> >()); > > NSArray *entries = [[NSArray alloc] initWithObjects:entry, nil]; > [self _sendNotification:WebHistoryItemsAddedNotification entries:entries]; >diff --git a/Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm b/Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm >index 14c27f3131a4fbd7600b50b159f9f79f6dbebc2c..5212aaf4933a9167e807188f5a9b8ed8a3a253c2 100644 >--- a/Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm >+++ b/Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm >@@ -161,7 +161,7 @@ String WebHaltablePlugin::pluginName() const > _mode = NP_EMBED; > > _loadManually = loadManually; >- _haltable = new WebHaltablePlugin(self); >+ _haltable = adoptPtr(new WebHaltablePlugin(self)); > return self; > } > >diff --git a/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm b/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm >index 94340d544e33a779fe16f8f4cd629e61fbf0efcb..277a3516dd0c00a006eeb268b2e2f408e1f1369c 100644 >--- a/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm >+++ b/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm >@@ -1205,8 +1205,8 @@ void WebFrameLoaderClient::setTitle(const StringWithDirection& title, const KURL > > void WebFrameLoaderClient::savePlatformDataToCachedFrame(CachedFrame* cachedFrame) > { >- WebCachedFramePlatformData* webPlatformData = new WebCachedFramePlatformData([m_webFrame->_private->webFrameView documentView]); >- cachedFrame->setCachedFramePlatformData(webPlatformData); >+ OwnPtr<WebCachedFramePlatformData> webPlatformData = adoptPtr(new WebCachedFramePlatformData([m_webFrame->_private->webFrameView documentView])); >+ cachedFrame->setCachedFramePlatformData(webPlatformData.release()); > } > > void WebFrameLoaderClient::transitionToCommittedFromCachedFrame(CachedFrame* cachedFrame) >diff --git a/Source/WebKit/mac/WebView/WebView.mm b/Source/WebKit/mac/WebView/WebView.mm >index b0d917ff9b29bb04134060f89798e72cabab9dfd..bc9572b3d774d24bffa8982563d98e219fc1c1b8 100644 >--- a/Source/WebKit/mac/WebView/WebView.mm >+++ b/Source/WebKit/mac/WebView/WebView.mm >@@ -642,7 +642,7 @@ static NSString *leakMailQuirksUserScriptContents() > { > static NSString *mailQuirksScriptContents = leakMailQuirksUserScriptContents(); > core(self)->group().addUserScriptToWorld(core([WebScriptWorld world]), >- mailQuirksScriptContents, KURL(), 0, 0, InjectAtDocumentEnd, InjectInAllFrames); >+ mailQuirksScriptContents, KURL(), PassOwnPtr<Vector<String> >(), PassOwnPtr<Vector<String> >(), InjectAtDocumentEnd, InjectInAllFrames); > } > > static bool needsOutlookQuirksScript() >@@ -663,7 +663,7 @@ static NSString *leakOutlookQuirksUserScriptContents() > { > static NSString *outlookQuirksScriptContents = leakOutlookQuirksUserScriptContents(); > core(self)->group().addUserScriptToWorld(core([WebScriptWorld world]), >- outlookQuirksScriptContents, KURL(), 0, 0, InjectAtDocumentEnd, InjectInAllFrames); >+ outlookQuirksScriptContents, KURL(), PassOwnPtr<Vector<String> >(), PassOwnPtr<Vector<String> >(), InjectAtDocumentEnd, InjectInAllFrames); > } > > - (void)_commonInitializationWithFrameName:(NSString *)frameName groupName:(NSString *)groupName usesDocumentViews:(BOOL)usesDocumentViews >@@ -2563,14 +2563,14 @@ static PassOwnPtr<Vector<String> > toStringVector(NSArray* patterns) > // Convert the patterns into Vectors. > NSUInteger count = [patterns count]; > if (count == 0) >- return 0; >- Vector<String>* patternsVector = new Vector<String>; >+ return PassOwnPtr<Vector<String> >(); >+ OwnPtr<Vector<String> > patternsVector = adoptPtr(new Vector<String>); > for (NSUInteger i = 0; i < count; ++i) { > id entry = [patterns objectAtIndex:i]; > if ([entry isKindOfClass:[NSString class]]) > patternsVector->append(String((NSString*)entry)); > } >- return patternsVector; >+ return patternsVector.release(); > } > > + (void)_addUserScriptToGroup:(NSString *)groupName world:(WebScriptWorld *)world source:(NSString *)source url:(NSURL *)url >diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog >index 7c08fcc6a7996b167fc1b28302796b7733a53d20..cddd5b6ad6f8f6e4967b39d77c18b399d39760d2 100644 >--- a/Source/WebKit2/ChangeLog >+++ b/Source/WebKit2/ChangeLog >@@ -1,3 +1,33 @@ >+2011-05-02 Adam Barth <abarth@webkit.org> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ PLATFORM(MAC) should (almost!) build with strict PassOwnPtr >+ https://bugs.webkit.org/show_bug.cgi?id=59924 >+ >+ * Platform/CoreIPC/Connection.cpp: >+ (CoreIPC::Connection::sendSyncMessage): >+ (CoreIPC::Connection::waitForSyncReply): >+ (CoreIPC::Connection::dispatchSyncMessage): >+ * Platform/CoreIPC/Connection.h: >+ (CoreIPC::Connection::Message::releaseArguments): >+ - The memory management for this class is very strange. I wrote a >+ large comment. Hopefully a kind soul will come by and fix it. >+ * Shared/Plugins/Netscape/NetscapePluginModule.cpp: >+ (WebKit::NetscapePluginModule::unload): >+ * UIProcess/API/mac/WKView.mm: >+ (-[WKView _setFindIndicator:fadeOut:]): >+ * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: >+ (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): >+ * WebProcess/InjectedBundle/InjectedBundle.cpp: >+ (WebKit::toStringVector): >+ * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: >+ (WebKit::NetscapePluginStream::stop): >+ * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: >+ (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient): >+ * WebProcess/WebPage/DrawingArea.cpp: >+ (WebKit::DrawingArea::create): >+ > 2011-04-29 Brian Weinstein <bweinstein@apple.com> > > Reviewed by Dan Bernstein. >diff --git a/Source/WebKit2/Platform/CoreIPC/Connection.cpp b/Source/WebKit2/Platform/CoreIPC/Connection.cpp >index 34de023a4e70fb930ba047c5904d0626501b932c..077b35ebafd80773ef31617ac7a4ef734386c27f 100644 >--- a/Source/WebKit2/Platform/CoreIPC/Connection.cpp >+++ b/Source/WebKit2/Platform/CoreIPC/Connection.cpp >@@ -370,7 +370,7 @@ PassOwnPtr<ArgumentDecoder> Connection::sendSyncMessage(MessageID messageID, uin > > if (!isValid()) { > didFailToSendSyncMessage(); >- return 0; >+ return PassOwnPtr<ArgumentDecoder>(); > } > > // Push the pending sync reply information on our stack. >@@ -378,7 +378,7 @@ PassOwnPtr<ArgumentDecoder> Connection::sendSyncMessage(MessageID messageID, uin > MutexLocker locker(m_syncReplyStateMutex); > if (!m_shouldWaitForSyncReplies) { > didFailToSendSyncMessage(); >- return 0; >+ return PassOwnPtr<ArgumentDecoder>(); > } > > m_pendingSyncReplies.append(PendingSyncReply(syncRequestID)); >@@ -440,7 +440,7 @@ PassOwnPtr<ArgumentDecoder> Connection::waitForSyncReply(uint64_t syncRequestID, > // If that happens, we need to stop waiting, or we'll hang since we won't get > // any more incoming messages. > if (!isValid()) >- return 0; >+ return PassOwnPtr<ArgumentDecoder>(); > > // We didn't find a sync reply yet, keep waiting. > #if PLATFORM(WIN) >@@ -454,7 +454,7 @@ PassOwnPtr<ArgumentDecoder> Connection::waitForSyncReply(uint64_t syncRequestID, > if (m_client) > m_client->syncMessageSendTimedOut(this); > >- return 0; >+ return PassOwnPtr<ArgumentDecoder>(); > } > > void Connection::processIncomingSyncReply(PassOwnPtr<ArgumentDecoder> arguments) >@@ -596,10 +596,10 @@ void Connection::dispatchSyncMessage(MessageID messageID, ArgumentDecoder* argum > } > > // Create our reply encoder. >- ArgumentEncoder* replyEncoder = ArgumentEncoder::create(syncRequestID).leakPtr(); >+ OwnPtr<ArgumentEncoder> replyEncoder = ArgumentEncoder::create(syncRequestID); > >- // Hand off both the decoder and encoder to the client.. >- SyncReplyMode syncReplyMode = m_client->didReceiveSyncMessage(this, messageID, arguments, replyEncoder); >+ // Hand off both the decoder and encoder to the client. >+ SyncReplyMode syncReplyMode = m_client->didReceiveSyncMessage(this, messageID, arguments, replyEncoder.get()); > > // FIXME: If the message was invalid, we should send back a SyncMessageError. > ASSERT(!arguments->isInvalid()); >@@ -611,7 +611,7 @@ void Connection::dispatchSyncMessage(MessageID messageID, ArgumentDecoder* argum > } > > // Send the reply. >- sendSyncReply(replyEncoder); >+ sendSyncReply(replyEncoder.release()); > } > > void Connection::didFailToSendSyncMessage() >diff --git a/Source/WebKit2/Platform/CoreIPC/Connection.h b/Source/WebKit2/Platform/CoreIPC/Connection.h >index 875403463be073d1624f3427461dd22fa0a13b22..4ffae92e12eb9f5698557ca12dd6e5045adad132 100644 >--- a/Source/WebKit2/Platform/CoreIPC/Connection.h >+++ b/Source/WebKit2/Platform/CoreIPC/Connection.h >@@ -174,14 +174,19 @@ private: > > PassOwnPtr<T> releaseArguments() > { >- T* arguments = m_arguments; >+ OwnPtr<T> arguments = adoptPtr(m_arguments); > m_arguments = 0; > >- return arguments; >+ return arguments.release(); > } > > private: > MessageID m_messageID; >+ // The memory management of this class is very unusual. The class acts >+ // as if it has an owning reference to m_arguments (e.g., accepting a >+ // PassOwnPtr in its constructor) in all ways except that it does not >+ // deallocate m_arguments on destruction. >+ // FIXME: Does this leak m_arguments on destruction? > T* m_arguments; > }; > >diff --git a/Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp b/Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp >index c5c0a9085b91b483123c6374ad772a4bb16c5639..642e3f2116f4016605d31277841605ce95a44686 100644 >--- a/Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp >+++ b/Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp >@@ -256,7 +256,7 @@ void NetscapePluginModule::unload() > { > ASSERT(!m_isInitialized); > >- m_module = 0; >+ m_module = nullptr; > } > > } // namespace WebKit >diff --git a/Source/WebKit2/UIProcess/API/mac/WKView.mm b/Source/WebKit2/UIProcess/API/mac/WKView.mm >index e4bcf0859975dbd3e1b78b6d294a13af1d017de4..729825414d047de731d184a9aea273e9dce36fd2 100644 >--- a/Source/WebKit2/UIProcess/API/mac/WKView.mm >+++ b/Source/WebKit2/UIProcess/API/mac/WKView.mm >@@ -2202,7 +2202,7 @@ static void drawPageBackground(CGContextRef context, WebPageProxy* page, const I > - (void)_setFindIndicator:(PassRefPtr<FindIndicator>)findIndicator fadeOut:(BOOL)fadeOut > { > if (!findIndicator) { >- _data->_findIndicatorWindow = 0; >+ _data->_findIndicatorWindow = nullptr; > return; > } > >diff --git a/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm b/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm >index d29a4cbd34bb5ecfc4bfab4f60bf7f2d820055af..62a0ffe081e2e08040ab2f85028f3c2c3e398dfe 100644 >--- a/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm >+++ b/Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm >@@ -140,7 +140,7 @@ void WebFullScreenManagerMac::setRootFullScreenLayer(WebCore::GraphicsLayer* lay > m_page->send(Messages::WebFullScreenManagerProxy::ExitAcceleratedCompositingMode()); > if (m_rootLayer) { > m_rootLayer->removeAllChildren(); >- m_rootLayer = 0; >+ m_rootLayer = nullptr; > } > return; > } >diff --git a/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp b/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp >index f0d71e2fc6707de5445b7966c5f2e617ace9ddad..46ed22e424c684c3aff173b6c8ed88a035f26722 100644 >--- a/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp >+++ b/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp >@@ -212,20 +212,20 @@ bool InjectedBundle::isPageBoxVisible(WebFrame* frame, int pageIndex) > static PassOwnPtr<Vector<String> > toStringVector(ImmutableArray* patterns) > { > if (!patterns) >- return 0; >+ return PassOwnPtr<Vector<String> >(); > > size_t size = patterns->size(); > if (!size) >- return 0; >+ return PassOwnPtr<Vector<String> >(); > >- Vector<String>* patternsVector = new Vector<String>; >+ OwnPtr<Vector<String> > patternsVector = adoptPtr(new Vector<String>); > patternsVector->reserveInitialCapacity(size); > for (size_t i = 0; i < size; ++i) { > WebString* entry = patterns->at<WebString>(i); > if (entry) > patternsVector->uncheckedAppend(entry->string()); > } >- return patternsVector; >+ return patternsVector.release(); > } > > void InjectedBundle::addUserScript(WebPageGroupProxy* pageGroup, InjectedBundleScriptWorld* scriptWorld, const String& source, const String& url, ImmutableArray* whitelist, ImmutableArray* blacklist, WebCore::UserScriptInjectionTime injectionTime, WebCore::UserContentInjectedFrames injectedFrames) >diff --git a/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp b/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp >index 8bd076d67098bab4613eeb35b598337d28a9f0d8..9b1a0659c548286beb9a9d0a79f5751168126509 100644 >--- a/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp >+++ b/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePluginStream.cpp >@@ -293,7 +293,7 @@ void NetscapePluginStream::stop(NPReason reason) > return; > } > >- m_deliveryData = 0; >+ m_deliveryData = nullptr; > m_deliveryDataTimer.stop(); > > if (m_transferMode == NP_ASFILE || m_transferMode == NP_ASFILEONLY) { >diff --git a/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp b/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp >index 5ac01742f45062122910fc259d162616e594c67f..8a98195197bf37badd4e3c2509f06c29023766c5 100644 >--- a/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp >+++ b/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp >@@ -40,7 +40,7 @@ using namespace WebCore; > namespace WebKit { > > WebInspectorFrontendClient::WebInspectorFrontendClient(WebPage* page, WebPage* inspectorPage) >- : InspectorFrontendClientLocal(page->corePage()->inspectorController(), inspectorPage->corePage(), new Settings()) >+ : InspectorFrontendClientLocal(page->corePage()->inspectorController(), inspectorPage->corePage(), adoptPtr(new Settings())) > , m_page(page) > { > } >diff --git a/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp b/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp >index 17d8dd9a0df112118ea10385db1e68433af39b44..a2975c8775f529d78384643c0545b861f3ff557e 100644 >--- a/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp >+++ b/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp >@@ -48,7 +48,7 @@ PassOwnPtr<DrawingArea> DrawingArea::create(WebPage* webPage, const WebPageCreat > #if PLATFORM(MAC) || PLATFORM(WIN) || PLATFORM(QT) > return DrawingAreaImpl::create(webPage, parameters); > #else >- return 0; >+ return PassOwnPtr<DrawingArea>(); > #endif > case DrawingAreaTypeChunkedUpdate: > return adoptPtr(new ChunkedUpdateDrawingArea(webPage)); >@@ -58,7 +58,7 @@ PassOwnPtr<DrawingArea> DrawingArea::create(WebPage* webPage, const WebPageCreat > #endif > } > >- return 0; >+ return PassOwnPtr<DrawingArea>(); > } > > DrawingArea::DrawingArea(DrawingAreaType type, WebPage* webPage)
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=91905">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 59924
: 91905