Attachment 84330 Details for Bug 48742 – Patch

[patch] Patch

bug-48742-20110301170848.patch (text/plain), 2.57 KB, created by Oliver Hunt on 2011-03-01 17:08:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Oliver Hunt

Created: 2011-03-01 17:08:49 PST

Size: 2.57 KB

patch

obsolete

>Subversion Revision: 80013
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 372fa4bf4adf4b1759be06807328761f9b045a05..e66ee23474d7c4a062ecad0af07f0ba8a7e885cd 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2011-03-01  Oliver Hunt  <oliver@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Misaligned memory access in CloneDeserializer on all ARM arch.
>+        https://bugs.webkit.org/show_bug.cgi?id=48742
>+
>+        Add a CPU class for architectures that need aligned addresses
>+        for memory access.
>+
>+        * wtf/Platform.h:
>+
> 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
> 
>         Reviewed by Kenneth Rohde Christiansen.
>diff --git a/Source/JavaScriptCore/wtf/Platform.h b/Source/JavaScriptCore/wtf/Platform.h
>index f00c1c3c912738e396111ca9baa6c435be073791..225b3541da4496705d823aea0684e8790d340e9c 100644
>--- a/Source/JavaScriptCore/wtf/Platform.h
>+++ b/Source/JavaScriptCore/wtf/Platform.h
>@@ -349,7 +349,9 @@
> 
> #endif /* ARM */
> 
>-
>+#if CPU(ARM) || CPU(MIPS)
>+#define WTF_CPU_NEEDS_ALIGNED_ACCESS 1
>+#endif
> 
> /* ==== OS() - underlying operating system; only to be used for mandated low-level services like 
>    virtual memory, not to choose a GUI toolkit ==== */
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0d835b4555eaffe6ba424ee9fc680a6885f14d40..e75dd6544c77922400bb32b855513e8cbdbae506 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2011-03-01  Oliver Hunt  <oliver@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Misaligned memory access in CloneDeserializer on all ARM arch.
>+        https://bugs.webkit.org/show_bug.cgi?id=48742
>+
>+        Push platforms that need aligned memory access down the
>+        endian independent serialization and deserialization
>+        paths.
>+
>+        * bindings/js/SerializedScriptValue.cpp:
>+
> 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
> 
>         Reviewed by Kenneth Rohde Christiansen.
>diff --git a/Source/WebCore/bindings/js/SerializedScriptValue.cpp b/Source/WebCore/bindings/js/SerializedScriptValue.cpp
>index 300d5b078a434e1e2f554e8e422c1ec78117fb67..41ad198e100445c73cfc10f6a359867acc2d76d4 100644
>--- a/Source/WebCore/bindings/js/SerializedScriptValue.cpp
>+++ b/Source/WebCore/bindings/js/SerializedScriptValue.cpp
>@@ -53,7 +53,7 @@
> using namespace JSC;
> using namespace std;
> 
>-#if CPU(BIG_ENDIAN) || CPU(MIDDLE_ENDIAN)
>+#if CPU(BIG_ENDIAN) || CPU(MIDDLE_ENDIAN) || CPU(NEEDS_ALIGNED_ACCESS)
> #define ASSUME_LITTLE_ENDIAN 0
> #else
> #define ASSUME_LITTLE_ENDIAN 1

Flags:

joepeck: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 48742: 72929 | 73345 | 84330