Attachment 82171 Details for Bug 54287 – Proposed patch with testing field filled in.

[patch] Proposed patch with testing field filled in.

cors.txt (text/plain), 2.31 KB, created by Bill Budge on 2011-02-11 14:01:14 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Bill Budge

Created: 2011-02-11 14:01:14 PST

Size: 2.31 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 78338)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2011-02-11  Bill Budge  <bbudge@chromium.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        SubresourceLoader should expose finish time
>+        https://bugs.webkit.org/show_bug.cgi?id=54287
>+
>+        No tests needed, exposes trivial functionality.
>+
>+        * loader/SubresourceLoader.cpp:
>+        * loader/SubresourceLoader.h:
>+
> 2011-02-10  Pavel Feldman  <pfeldman@chromium.org>
> 
>         Reviewed by Yury Semikhatsky.
>Index: Source/WebCore/loader/SubresourceLoader.cpp
>===================================================================
>--- Source/WebCore/loader/SubresourceLoader.cpp	(revision 78338)
>+++ Source/WebCore/loader/SubresourceLoader.cpp	(working copy)
>@@ -46,6 +46,7 @@ static WTF::RefCountedLeakCounter subres
> SubresourceLoader::SubresourceLoader(Frame* frame, SubresourceLoaderClient* client, bool sendResourceLoadCallbacks, bool shouldContentSniff)
>     : ResourceLoader(frame, sendResourceLoadCallbacks, shouldContentSniff)
>     , m_client(client)
>+    , m_finishTime(0.0)
>     , m_loadingMultipartContent(false)
> {
> #ifndef NDEBUG
>@@ -177,6 +178,7 @@ void SubresourceLoader::didFinishLoading
>     // Calling removeSubresourceLoader will likely result in a call to deref, so we must protect ourselves.
>     RefPtr<SubresourceLoader> protect(this);
> 
>+    m_finishTime = finishTime;
>     if (m_client)
>         m_client->didFinishLoading(this);
>     
>Index: Source/WebCore/loader/SubresourceLoader.h
>===================================================================
>--- Source/WebCore/loader/SubresourceLoader.h	(revision 78338)
>+++ Source/WebCore/loader/SubresourceLoader.h	(working copy)
>@@ -43,6 +43,8 @@ namespace WebCore {
> 
>         void clearClient() { m_client = 0; }
> 
>+        double finishTime() { return m_finishTime; }
>+
>     private:
>         SubresourceLoader(Frame*, SubresourceLoaderClient*, bool sendResourceLoadCallbacks, bool shouldContentSniff);
>         virtual ~SubresourceLoader();
>@@ -60,6 +62,7 @@ namespace WebCore {
>         virtual void didCancel(const ResourceError&);
> 
>         SubresourceLoaderClient* m_client;
>+        double m_finishTime;
>         bool m_loadingMultipartContent;
>     };
>

Flags:

levin: review-
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 54287: 82137 | 82138 | 82171 | 82379 | 82380 | 82383 | 82386 | 82388 | 82394 | 82397 | 82401