Attachment 81707 Details for Bug 54041 – Patch

[patch] Patch

bug-54041-20110208154214.patch (text/plain), 4.22 KB, created by Andy Estes on 2011-02-08 15:42:15 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Estes

Created: 2011-02-08 15:42:15 PST

Size: 4.22 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 77982)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2011-02-08  Andy Estes  <aestes@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
>+        https://bugs.webkit.org/show_bug.cgi?id=54041
>+
>+        * html/HTMLElement.cpp:
>+        (WebCore::HTMLElement::setContentEditable): Setting the contentEditable
>+        attribute to 'plaintext-only' should not throw an exception.
>+
> 2011-02-08  Levi Weintraub  <leviw@chromium.org>
> 
>         Reviewed by Ryosuke Niwa.
>Index: Source/WebCore/html/HTMLElement.cpp
>===================================================================
>--- Source/WebCore/html/HTMLElement.cpp	(revision 77962)
>+++ Source/WebCore/html/HTMLElement.cpp	(working copy)
>@@ -735,6 +735,8 @@ void HTMLElement::setContentEditable(con
>         setAttribute(contenteditableAttr, "true", ec);
>     else if (equalIgnoringCase(enabled, "false"))
>         setAttribute(contenteditableAttr, "false", ec);
>+    else if (equalIgnoringCase(enabled, "plaintext-only"))
>+        setAttribute(contenteditableAttr, "plaintext-only");
>     else if (equalIgnoringCase(enabled, "inherit"))
>         removeAttribute(contenteditableAttr, ec);
>     else
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 77982)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2011-02-08  Andy Estes  <aestes@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
>+        https://bugs.webkit.org/show_bug.cgi?id=54041
>+
>+        * fast/dom/HTMLElement/set-value-caseinsensitive.html:
>+
> 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
> 
>         Unskip a series of tests that seem to be passing locally. Also unskip
>Index: LayoutTests/fast/dom/HTMLElement/set-value-caseinsensitive.html
>===================================================================
>--- LayoutTests/fast/dom/HTMLElement/set-value-caseinsensitive.html	(revision 77962)
>+++ LayoutTests/fast/dom/HTMLElement/set-value-caseinsensitive.html	(working copy)
>@@ -13,12 +13,17 @@
> <div id="div2" contenteditable="true">
>     <p id="p2" contenteditable="false"></p>
> </div>
>+<div id="div3" contenteditable="true">
>+    <p id="p3" contenteditable="false"></p>
>+</div>
> <script>
> description('When contentEditable is set to a new value, the new value can be case-insensitive.')
> 
> document.getElementById("div1").contentEditable = "TRue";
> document.getElementById("p1").contentEditable = "faLSE";
> document.getElementById("p2").contentEditable = "inHERIT";
>+document.getElementById("div3").contentEditable = "PlainText-Only"
>+document.getElementById("p3").contentEditable = "Inherit"
> 
> shouldBe('document.getElementById("div1").getAttribute("contentEditable")','"true"');
> shouldBe('document.getElementById("div1").contentEditable', '"true"');
>@@ -36,9 +41,21 @@ shouldBe('document.getElementById("p2").
> shouldBe('document.getElementById("p2").isContentEditable', 'true');
> shouldBe('window.getComputedStyle(p2, "").getPropertyValue("-webkit-user-modify")', '"read-write"');
> 
>+shouldBe('document.getElementById("div3").hasAttribute("contentEditable")','true');
>+shouldBe('document.getElementById("div3").contentEditable', '"plaintext-only"');
>+shouldBe('document.getElementById("div3").isContentEditable', 'true');
>+shouldBe('window.getComputedStyle(div3, "").getPropertyValue("-webkit-user-modify")', '"read-write-plaintext-only"');
>+
>+shouldBe('document.getElementById("p3").hasAttribute("contentEditable")','false');
>+shouldBe('document.getElementById("p3").contentEditable', '"inherit"');
>+shouldBe('document.getElementById("p3").isContentEditable', 'true');
>+shouldBe('window.getComputedStyle(p3, "").getPropertyValue("-webkit-user-modify")', '"read-write-plaintext-only"');
>+
> document.getElementById("div1").style.display= 'none';
> document.getElementById("p1").style.display= 'none';
> document.getElementById("div2").style.display= 'none';
>+document.getElementById("div3").style.display= 'none';
>+
> 
> window.successfullyParsed = true;
> </script>

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 54041: 81707