Attachment 79397 Details for Bug 52702 – Proposed Patch

[patch] Proposed Patch

updatedRect.patch (text/plain), 1.43 KB, created by Joone Hur on 2011-01-19 00:01:21 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Joone Hur

Created: 2011-01-19 00:01:21 PST

Size: 1.43 KB

patch

obsolete

>diff --git a/Source/WebKit/gtk/ChangeLog b/Source/WebKit/gtk/ChangeLog
>index ef1f2aa..b86e3b5 100644
>--- a/Source/WebKit/gtk/ChangeLog
>+++ b/Source/WebKit/gtk/ChangeLog
>@@ -1,3 +1,15 @@
>+2011-01-18  Joone Hur  <joone.hur@collabora.co.uk>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [GTK] No need to invalidate empty areas in ChromeClient::invalidateContentsAndWindow
>+        https://bugs.webkit.org/show_bug.cgi?id=52702
>+
>+        Don't call gdk_window_invalidate_rect if an updated rectangle is empty.
>+
>+        * WebCoreSupport/ChromeClientGtk.cpp:
>+        (WebKit::ChromeClient::invalidateContentsAndWindow): 
>+
> 2011-01-17  Philippe Normand  <pnormand@igalia.com>
> 
>         Unreviewed, build fix for 2 GTK tests html file paths.
>diff --git a/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp b/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
>index 8b6a483..04ee8ba 100644
>--- a/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
>+++ b/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
>@@ -377,7 +377,7 @@ void ChromeClient::invalidateContentsAndWindow(const IntRect& updateRect, bool i
>     GdkRectangle rect = updateRect;
>     GdkWindow* window = gtk_widget_get_window(GTK_WIDGET(m_webView));
> 
>-    if (window) {
>+    if (window && !updateRect.isEmpty()) {
>         gdk_window_invalidate_rect(window, &rect, FALSE);
>         // We don't currently do immediate updates since they delay other UI elements.
>         //if (immediate)

Actions: View | Formatted Diff | Diff

Attachments on bug 52702: 79397